Core23\Form\Handler\AbstractFormHandler

Complexity

Total Complexity

11

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	validate()	0	3	1
B	handle()	0	31	8
A	preProcess()	0	3	1
A	postProcess()	0	3	1

<?php

declare(strict_types=1);

/*
 * (c) Christian Gripp <mail@core23.de>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Core23\Form\Handler;

use Core23\Form\Handler\Exception\InvalidCallbackException;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

abstract class AbstractFormHandler implements FormHandlerInterface
{
    final public function handle(FormInterface $form, Request $request, callable $callback): ?Response
    {
        if (null !== $response = $this->preProcess($form, $request)) {

Are you sure the assignment to $response is correct as $this->preProcess($form, $request) targeting Core23\Form\Handler\AbstractFormHandler::preProcess() seems to always return null.

The condition null !== $response = $this->preProcess($form, $request) is always false.

            return $response;
        }

        $form->handleRequest($request);

        if (!$form->isSubmitted() || !$form->isValid()) {
            return null;
        }

        if (null !== $response = $this->validate($form, $request)) {

Are you sure the assignment to $response is correct as $this->validate($form, $request) targeting Core23\Form\Handler\AbstractFormHandler::validate() seems to always return null.

The condition null !== $response = $this->validate($form, $request) is always false.

            return $response;
        }

        if (!$this->process($form, $request)) {
            return null;
        }

        $response = $callback();

        if (!$response instanceof Response) {
            throw new InvalidCallbackException('Invalid callback response.');
        }

        if (null !== $response = $this->postProcess($form, $request, $response)) {
            return $response;
        }

        return null;
    }

    /**
     * Executes before form validating and processing is started.
     */
    protected function preProcess(FormInterface $form, Request $request): ?Response
    {
        return null;
    }

    /**
     * Executes after preprocessing and before form processing is started.
     */
    protected function validate(FormInterface $form, Request $request): ?Response

The parameter $form is not used and could be removed.

The parameter $request is not used and could be removed.

    {
        return null;
    }

    /**
     * Executes the form processing.
     */
    abstract protected function process(FormInterface $form, Request $request): bool;

    /**
     * Executes after form processing is finished and filters response.
     */
    protected function postProcess(FormInterface $form, Request $request, Response $response): ?Response
    {
        return $response;
    }
}