Core23SitemapBundleTest::testBuild() - Code Metrics - Inspection of "[BUILD] Added more strict phpstan rules" - core23/SitemapBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

by Christian

created 2019-07-31 17:19 UTC

Core23SitemapBundleTest::testBuild() A

↳ Parent: Core23SitemapBundleTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

/*
 * (c) Christian Gripp <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Core23\SitemapBundle\Tests;

use Core23\SitemapBundle\Core23SitemapBundle;
use Core23\SitemapBundle\DependencyInjection\Compiler\SitemapCompilerPass;
use Core23\SitemapBundle\DependencyInjection\Core23SitemapExtension;
use PHPUnit\Framework\TestCase;
use Symfony\Component\DependencyInjection\ContainerBuilder;

final class Core23SitemapBundleTest extends TestCase
{
    public function testGetContainerExtension(): void
    {
        $bundle = new Core23SitemapBundle();

        static::assertInstanceOf(Core23SitemapExtension::class, $bundle->getContainerExtension());
    }

    public function testBuild(): void
    {
        $containerBuilder = $this->createMock(ContainerBuilder::class);

        $containerBuilder->expects(static::once())->method('addCompilerPass')
            ->with(static::isInstanceOf(SitemapCompilerPass::class))
        ;

        $bundle = new Core23SitemapBundle();
        $bundle->build($containerBuilder);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			/*
4			* (c) Christian Gripp <[email protected]>
5			*
6			* For the full copyright and license information, please view the LICENSE
7			* file that was distributed with this source code.
8			*/
9
10			namespace Core23\SitemapBundle\Tests;
11
12			use Core23\SitemapBundle\Core23SitemapBundle;
13			use Core23\SitemapBundle\DependencyInjection\Compiler\SitemapCompilerPass;
14			use Core23\SitemapBundle\DependencyInjection\Core23SitemapExtension;
15			use PHPUnit\Framework\TestCase;
16			use Symfony\Component\DependencyInjection\ContainerBuilder;
17
18			final class Core23SitemapBundleTest extends TestCase
19			{
20			public function testGetContainerExtension(): void
21			{
22			$bundle = new Core23SitemapBundle();
23
24			static::assertInstanceOf(Core23SitemapExtension::class, $bundle->getContainerExtension());
25			}
26
27			public function testBuild(): void
28			{
29			$containerBuilder = $this->createMock(ContainerBuilder::class);
30
31			$containerBuilder->expects(static::once())->method('addCompilerPass')
32			->with(static::isInstanceOf(SitemapCompilerPass::class))
33			;
34
35			$bundle = new Core23SitemapBundle();
36			$bundle->build($containerBuilder);
			0 ignored issues – show Documentation introduced 2019-03-21 17:52 UTC by Report Bug Copy Issue Report `$containerBuilder` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...ction\ContainerBuilder>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
37			}
38			}
39

core23 / SitemapBundle

GitHub Access Token became invalid

Pull Request — master (#10)

Core23SitemapBundleTest::testBuild() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like