These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | |||
3 | declare(strict_types=1); |
||
4 | |||
5 | /* |
||
6 | * (c) Christian Gripp <[email protected]> |
||
7 | * |
||
8 | * For the full copyright and license information, please view the LICENSE |
||
9 | * file that was distributed with this source code. |
||
10 | */ |
||
11 | |||
12 | namespace Core23\SitemapBundle\Definition; |
||
13 | |||
14 | final class DefintionManager implements DefintionManagerInterface |
||
15 | { |
||
16 | /** |
||
17 | * Collection of available sitemap definitions. |
||
18 | * |
||
19 | * @var SitemapDefinitionInterface[] |
||
20 | */ |
||
21 | private $sitemaps; |
||
22 | |||
23 | public function __construct() |
||
24 | { |
||
25 | $this->sitemaps = []; |
||
26 | } |
||
27 | |||
28 | /** |
||
29 | * {@inheritdoc} |
||
30 | */ |
||
31 | public function addDefinition(string $id, array $configuration = []): DefintionManagerInterface |
||
32 | { |
||
33 | $this->add($id, new SitemapDefinition($id, $configuration)); |
||
34 | |||
35 | return $this; |
||
0 ignored issues
–
show
|
|||
36 | } |
||
37 | |||
38 | /** |
||
39 | * {@inheritdoc} |
||
40 | */ |
||
41 | public function getAll(): array |
||
42 | { |
||
43 | return $this->sitemaps; |
||
44 | } |
||
45 | |||
46 | /** |
||
47 | * @param string $code |
||
48 | * @param SitemapDefinitionInterface $sitemap |
||
49 | * |
||
50 | * @return DefintionManagerInterface |
||
51 | */ |
||
52 | private function add(string $code, SitemapDefinitionInterface $sitemap): DefintionManagerInterface |
||
53 | { |
||
54 | $this->sitemaps[$code] = $sitemap; |
||
55 | |||
56 | return $this; |
||
57 | } |
||
58 | } |
||
59 |
If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design.
Let’s take a look at an example:
Our function
my_function
expects aPost
object, and outputs the author of the post. The base classPost
returns a simple string and outputting a simple string will work just fine. However, the child classBlogPost
which is a sub-type ofPost
instead decided to return anobject
, and is therefore violating the SOLID principles. If aBlogPost
were passed tomy_function
, PHP would not complain, but ultimately fail when executing thestrtoupper
call in its body.