DefintionManager::__construct() - Code Metrics - core23/SitemapBundle - Measure and Improve Code Quality continuously with Scrutinizer

DefintionManager::__construct() A
last analyzed 2019-12-08 07:53 UTC

↳ Parent: DefintionManager

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

declare(strict_types=1);

/*
 * (c) Christian Gripp <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Core23\SitemapBundle\Definition;

final class DefintionManager implements DefintionManagerInterface
{
    /**
     * Collection of available sitemap definitions.
     *
     * @var SitemapDefinitionInterface[]
     */
    private $sitemaps;

    public function __construct()
    {
        $this->sitemaps = [];
    }

    public function addDefinition(string $id, array $configuration = []): DefintionManagerInterface
    {
        $this->add($id, new SitemapDefinition($id, $configuration));

        return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function getAll(): array
    {
        return $this->sitemaps;
    }

    private function add(string $code, SitemapDefinitionInterface $sitemap): DefintionManagerInterface
    {
        $this->sitemaps[$code] = $sitemap;

        return $this;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* (c) Christian Gripp <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Core23\SitemapBundle\Definition;
13
14			final class DefintionManager implements DefintionManagerInterface
15			{
16			/**
17			* Collection of available sitemap definitions.
18			*
19			* @var SitemapDefinitionInterface[]
20			*/
21			private $sitemaps;
22
23			public function __construct()
24			{
25			$this->sitemaps = [];
26			}
27
28			public function addDefinition(string $id, array $configuration = []): DefintionManagerInterface
29			{
30			$this->add($id, new SitemapDefinition($id, $configuration));
31
32			return $this;
			0 ignored issues – show Bug Best Practice introduced 2018-10-20 20:27 UTC by Report Bug Copy Issue Report The return type of `return $this;` (`Core23\SitemapBundle\Definition\DefintionManager`) is incompatible with the return type declared by the interface `Core23\SitemapBundle\Def...nterface::addDefinition` of type `self`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
33			}
34
35			public function getAll(): array
36			{
37			return $this->sitemaps;
38			}
39
40			private function add(string $code, SitemapDefinitionInterface $sitemap): DefintionManagerInterface
41			{
42			$this->sitemaps[$code] = $sitemap;
43
44			return $this;
45			}
46			}
47

core23 / SitemapBundle

GitHub Access Token became invalid

DefintionManager::__construct() A last analyzed 2019-12-08 07:53 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

DefintionManager::__construct() A
last analyzed 2019-12-08 07:53 UTC