BulkDestroyRequest   A
last analyzed

Complexity

Total Complexity 6

Size/Duplication

Total Lines 63
Duplicated Lines 100 %

Coupling/Cohesion

Components 0
Dependencies 0

Importance

Changes 0
Metric Value
wmc 6
lcom 0
cbo 0
dl 63
loc 63
rs 10
c 0
b 0
f 0

5 Methods

Rating   Name   Duplication   Size   Complexity  
A handle() 8 8 2
A buildClass() 9 9 1
A getOptions() 6 6 1
A generateClassNameFromTable() 3 3 1
A getDefaultNamespace() 4 4 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Savannabits\JetstreamInertiaGenerator\Generators;
4
5
use Symfony\Component\Console\Input\InputOption;
6
7 View Code Duplication
class BulkDestroyRequest extends ClassGenerator {
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
8
9
    /**
10
     * The name and signature of the console command.
11
     *
12
     * @var string
13
     */
14
    protected $name = 'jig:generate:request:bulk-destroy';
15
16
    /**
17
     * The console command description.
18
     *
19
     * @var string
20
     */
21
    protected $description = 'Generate a Bulk Destroy request class';
22
23
    /**
24
     * Execute the console command.
25
     *
26
     * @return mixed
27
     */
28
    public function handle()
29
    {
30
        $force = $this->option('force');
31
32
        if ($this->generateClass($force)){
33
            $this->info('Generating '.$this->classFullName.' finished');
34
        }
35
    }
36
37
    protected function buildClass() {
38
39
        return view('jig::bulk-destroy-request', [
0 ignored issues
show
Bug introduced by
The method render does only exist in Illuminate\Contracts\View\View, but not in Illuminate\Contracts\View\Factory.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
40
            'modelBaseName' => $this->modelBaseName,
41
            'modelDotNotation' => $this->modelDotNotation,
42
            'modelWithNamespaceFromDefault' => $this->modelWithNamespaceFromDefault,
43
            'modelVariableName' => $this->modelVariableName,
44
        ])->render();
45
    }
46
47
    protected function getOptions() {
48
        return [
49
            ['model-name', 'm', InputOption::VALUE_OPTIONAL, 'Generates a code for the given model'],
50
            ['force', 'f', InputOption::VALUE_NONE, 'Force will delete files before regenerating request'],
51
        ];
52
    }
53
54
    public function generateClassNameFromTable($tableName) {
55
        return 'BulkDestroy'.$this->modelBaseName;
56
    }
57
58
    /**
59
     * Get the default namespace for the class.
60
     *
61
     * @param string $rootNamespace
62
     * @return string
63
     */
64
    protected function getDefaultNamespace(string $rootNamespace)
65
    {
66
        return $rootNamespace.'\Http\Requests\Admin\\'.$this->modelWithNamespaceFromDefault;
67
    }
68
69
}
70