Password::encrypt() - Code Metrics - controlabs/php-password-helper - Measure and Improve Code Quality continuously with Scrutinizer

Password::encrypt() A
last analyzed 2018-10-29 17:08 UTC

↳ Parent: Password

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	5
cts	5
cp	1
rs	9.9332
c	0
b	0
f	0
cc	2
nc	2
nop	3
crap	2

<?php

namespace Controlabs\Helper;

class Password
{
    protected const SHA_512 = 'sha512';

    public function encrypt(string $password, string $salt = null, string $algorithm = self::SHA_512): PasswordData
    {
        if (!$salt) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $salt = hash($algorithm, uniqid(strval(mt_rand(1, mt_getrandmax())), true));
        }

        $password = hash($algorithm, $password . $salt);

        return new PasswordData($password, $salt);
    }

    public function verify(string $encrypted, string $password, string $salt, string $algorithm = self::SHA_512): bool
    {
        return $encrypted === $this->encrypt($password, $salt, $algorithm)->password();
    }
}


1		<?php
2
3		namespace Controlabs\Helper;
4
5		class Password
6		{
7		protected const SHA_512 = 'sha512';
8
9	1	public function encrypt(string $password, string $salt = null, string $algorithm = self::SHA_512): PasswordData
10		{
11	1	if (!$salt) {
		0 ignored issues – show Bug Best Practice introduced 2018-10-25 17:40 UTC by Report Bug Copy Issue Report The expression `$salt` of type `null\|string` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
12	1	$salt = hash($algorithm, uniqid(strval(mt_rand(1, mt_getrandmax())), true));
13		}
14
15	1	$password = hash($algorithm, $password . $salt);
16
17	1	return new PasswordData($password, $salt);
18		}
19
20	1	public function verify(string $encrypted, string $password, string $salt, string $algorithm = self::SHA_512): bool
21		{
22	1	return $encrypted === $this->encrypt($password, $salt, $algorithm)->password();
23		}
24		}
25

controlabs / php-password-helper

Password::encrypt() A last analyzed 2018-10-29 17:08 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Password::encrypt() A
last analyzed 2018-10-29 17:08 UTC