AccessLoggerMiddleware::process() - Code Metrics - Inspection of "Logger" - contredanse/mfts-server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( fc05cd...bc2e67 )

by Sébastien

created 2019-01-04 14:51 UTC

AccessLoggerMiddleware::process() A

↳ Parent: AccessLoggerMiddleware

Complexity

Conditions	3
Paths	0

Size

Total Lines	19
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
cc	3
eloc	13
nc	0
nop	2
dl	0
loc	19
ccs	0
cts	16
cp	0
crap	12
rs	9.8333
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace App\Middleware;

use App\Infra\Log\AccessLogger;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;

class AccessLoggerMiddleware implements MiddlewareInterface
{
    /**
     * @var AccessLogger
     */
    private $accessLogger;

    public function __construct(AccessLogger $accessLogger)
    {
        $this->accessLogger = $accessLogger;
    }

    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $response = $handler->handle($request);

        $ip = $this->getClientIp($request);
        $email = $this->getEmail($request);

        try {
            $this->accessLogger->log(
                $response->getStatusCode() === 200 ? AccessLogger::TYPE_LOGIN_SUCCESS :
				AccessLogger::TYPE_LOGIN_FAILURE,
                $email,
                $ip
            );
        } catch (\Throwable $e) {
            // Discard any error
            error_log('AccessLoggerMiddleware failure' . $e->getMessage());
        } finally {
            return $response;
        }
    }

    private function getEmail(ServerRequestInterface $request): string {
		$body = $request->getParsedBody();
		return trim($body['email'] ?? '');
	}

    private function getClientIp(ServerRequestInterface $request): ?string
    {
        $serverParams = $request->getServerParams();
        if (isset($serverParams['REMOTE_ADDR'])) {
            return $serverParams['REMOTE_ADDR'];
        }
        return null;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace App\Middleware;
6
7			use App\Infra\Log\AccessLogger;
8			use Psr\Http\Message\ResponseInterface;
9			use Psr\Http\Message\ServerRequestInterface;
10			use Psr\Http\Server\MiddlewareInterface;
11			use Psr\Http\Server\RequestHandlerInterface;
12
13			class AccessLoggerMiddleware implements MiddlewareInterface
14			{
15			/**
16			* @var AccessLogger
17			*/
18			private $accessLogger;
19
20			public function __construct(AccessLogger $accessLogger)
21			{
22			$this->accessLogger = $accessLogger;
23			}
24
25			public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
26			{
27			$response = $handler->handle($request);
28
29			$ip = $this->getClientIp($request);
30			$email = $this->getEmail($request);
31
32			try {
33			$this->accessLogger->log(
34			$response->getStatusCode() === 200 ? AccessLogger::TYPE_LOGIN_SUCCESS :
35			AccessLogger::TYPE_LOGIN_FAILURE,
36			$email,
37			$ip
38			);
39			} catch (\Throwable $e) {
40			// Discard any error
41			error_log('AccessLoggerMiddleware failure' . $e->getMessage());
42			} finally {
43			return $response;
44			}
45			}
46
47			private function getEmail(ServerRequestInterface $request): string {
48			$body = $request->getParsedBody();
49			return trim($body['email'] ?? '');
50			}
51
52			private function getClientIp(ServerRequestInterface $request): ?string
53			{
54			$serverParams = $request->getServerParams();
55			if (isset($serverParams['REMOTE_ADDR'])) {
56			return $serverParams['REMOTE_ADDR'];
57			}
58			return null;
59			}
60			}
61

contredanse / mfts-server

Push — master ( fc05cd...bc2e67 )

AccessLoggerMiddleware::process() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like