Handler::handle() - Code Metrics - Inspection of "add json-rpc 2.0 protocol" - contamobi/CmobiRabbitmqBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f8a04a...bca97c )

by Daniel

created 2016-03-10 22:42 UTC

Handler::handle() B

↳ Parent: Handler

Complexity

Conditions	4
Paths	3

Size

Total Lines	22
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	1	Features	2

Metric	Value
c	4
b	1
f	2
dl	0
loc	22
rs	8.9197
cc	4
eloc	17
nc	3
nop	2

<?php

namespace Cmobi\RabbitmqBundle\Rpc;

use Cmobi\RabbitmqBundle\Rpc\Controller\RpcControllerResolver;
use Cmobi\RabbitmqBundle\Rpc\Exception\InvalidBodyAMQPMessageException;
use Cmobi\RabbitmqBundle\Rpc\Exception\JsonRpcInternalErrorException;
use Cmobi\RabbitmqBundle\Rpc\Request\RpcRequestCollectionInterface;
use Cmobi\RabbitmqBundle\Rpc\Response\JsonRpcResponse;
use Cmobi\RabbitmqBundle\Rpc\Response\JsonRpcResponseCollection;
use Cmobi\RabbitmqBundle\Rpc\Response\RpcResponseCollectionInterface;
use Symfony\Component\DependencyInjection\ContainerAwareTrait;

class Handler
{
    use ContainerAwareTrait;

    private $resolver;

    public function __construct()
    {
        $this->resolver = new RpcControllerResolver();
    }

    public function handle(RpcRequestCollectionInterface $requests, RpcResponseCollectionInterface $responses)
    {
        foreach ($requests as $request) {

            $controller = $this->getResolver()->getController($request);
            $arguments = $this->getResolver()->getArguments($request, $controller);
            $response = call_user_func_array($controller, $arguments);

            if (!is_string($response) || is_null($response)) {
                $previous = new InvalidBodyAMQPMessageException('Invalid Body: Content should be string and not null.');
                $exception = new JsonRpcInternalErrorException($previous);
                $error = new JsonRpcResponse([], $exception);
                $error->setId($request->id);
                $error->setMethod($request->method);
                $responses->add($error);
            } else {
                $response = new JsonRpcResponse($response);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $response->setId($request->id);
                $response->setMethod($request->method);
                $responses->add($response);
            }
        }
    }

    /**
     * @return RpcControllerResolver
     */
    public function getResolver()
    {
        return $this->resolver;
    }

    /**
     * @return \Symfony\Component\DependencyInjection\ContainerInterface
     */
    public function getContainer()
    {
        return $this->container;
    }
}

1			<?php
2
3			namespace Cmobi\RabbitmqBundle\Rpc;
4
5			use Cmobi\RabbitmqBundle\Rpc\Controller\RpcControllerResolver;
6			use Cmobi\RabbitmqBundle\Rpc\Exception\InvalidBodyAMQPMessageException;
7			use Cmobi\RabbitmqBundle\Rpc\Exception\JsonRpcInternalErrorException;
8			use Cmobi\RabbitmqBundle\Rpc\Request\RpcRequestCollectionInterface;
9			use Cmobi\RabbitmqBundle\Rpc\Response\JsonRpcResponse;
10			use Cmobi\RabbitmqBundle\Rpc\Response\JsonRpcResponseCollection;
11			use Cmobi\RabbitmqBundle\Rpc\Response\RpcResponseCollectionInterface;
12			use Symfony\Component\DependencyInjection\ContainerAwareTrait;
13
14			class Handler
15			{
16			use ContainerAwareTrait;
17
18			private $resolver;
19
20			public function __construct()
21			{
22			$this->resolver = new RpcControllerResolver();
23			}
24
25			public function handle(RpcRequestCollectionInterface $requests, RpcResponseCollectionInterface $responses)
26			{
27			foreach ($requests as $request) {
			0 ignored issues – show Bug introduced 2016-03-09 22:20 UTC by Report Bug Copy Issue Report The expression `$requests` of type `object<Cmobi\RabbitmqBun...estCollectionInterface>` is not traversable. Loading history...
28			$controller = $this->getResolver()->getController($request);
29			$arguments = $this->getResolver()->getArguments($request, $controller);
30			$response = call_user_func_array($controller, $arguments);
31
32			if (!is_string($response) \|\| is_null($response)) {
33			$previous = new InvalidBodyAMQPMessageException('Invalid Body: Content should be string and not null.');
34			$exception = new JsonRpcInternalErrorException($previous);
35			$error = new JsonRpcResponse([], $exception);
36			$error->setId($request->id);
37			$error->setMethod($request->method);
38			$responses->add($error);
39			} else {
40			$response = new JsonRpcResponse($response);
			0 ignored issues – show Documentation introduced 2016-03-10 22:45 UTC by Report Bug Copy Issue Report `$response` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
41			$response->setId($request->id);
42			$response->setMethod($request->method);
43			$responses->add($response);
44			}
45			}
46			}
47
48			/**
49			* @return RpcControllerResolver
50			*/
51			public function getResolver()
52			{
53			return $this->resolver;
54			}
55
56			/**
57			* @return \Symfony\Component\DependencyInjection\ContainerInterface
58			*/
59			public function getContainer()
60			{
61			return $this->container;
62			}
63			}

contamobi / CmobiRabbitmqBundle

Push — master ( f8a04a...bca97c )

Handler::handle() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like