RpcRequestCollection::__construct() - Code Metrics - Inspection of "improve bundle, add priority on client" - contamobi/CmobiRabbitmqBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b48de3...82623c )

by Daniel

created 2016-03-21 14:18 UTC

RpcRequestCollection::__construct() A

↳ Parent: RpcRequestCollection

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

namespace Cmobi\RabbitmqBundle\Rpc\Request;


class RpcRequestCollection implements RpcRequestCollectionInterface, \IteratorAggregate, \Countable
{
    private $priority;
    public $requests = [];

    public function __construct($priority = RpcRequestCollectionInterface::PRIORITY_LOW)
    {
        $this->priority = $this->changePriority($priority);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
    }

    public function getIterator()
    {
        return new \ArrayIterator($this->requests);
    }

    public function count()
    {
        return count($this->requests);
    }

    public function add(RpcRequestInterface $request)
    {
        $key = array_search($request, $this->requests, true);

        if ($key !== false) {
            unset($this->requests[$key]);
        }
        $this->requests[] = $request;
    }

    public function all()
    {
        return $this->requests;
    }

    public function get($id)
    {
        if (isset($this->requests[$id])) {
            return $this->requests[$id];
        }

        return null;
    }

    /**
     * @param RpcRequest $request
     * @return string|int|null
     */
    public function getRequestIndex(RpcRequest $request)
    {
        return array_search($request, $this->requests);
    }

    /**
     * @param $id
     */
    public function remove($id)
    {
        unset($this->requests[$id]);
    }

    /**
     * @param RpcRequestCollection $collection
     */
    public function addCollection(RpcRequestCollection $collection)
    {
        foreach ($collection->all() as $id => $request) {
            unset($this->requests[$id]);
            $this->requests[$id] = $request;
        }
    }

    /**
     * @param $priorityNumber
     */
    public function changePriority($priorityNumber)
    {
        if (!decoct(octdec($priorityNumber) == $priorityNumber)) {
            $priorityNumber = decoct($priorityNumber);
        }
        $this->priority = $priorityNumber;
    }

    /**
     * Return octect priority
     *
     * @return int
     */
    public function getPriority()
    {
        return $this->priority;
    }
}

1			<?php
2
3			namespace Cmobi\RabbitmqBundle\Rpc\Request;
4
5
6			class RpcRequestCollection implements RpcRequestCollectionInterface, \IteratorAggregate, \Countable
7			{
8			private $priority;
9			public $requests = [];
10
11			public function __construct($priority = RpcRequestCollectionInterface::PRIORITY_LOW)
12			{
13			$this->priority = $this->changePriority($priority);
			0 ignored issues – show Bug introduced 2016-03-21 14:22 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$this->priority` is correct as `$this->changePriority($priority)` (which targets `Cmobi\RabbitmqBundle\Rpc...ction::changePriority()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
14			}
15
16			public function getIterator()
17			{
18			return new \ArrayIterator($this->requests);
19			}
20
21			public function count()
22			{
23			return count($this->requests);
24			}
25
26			public function add(RpcRequestInterface $request)
27			{
28			$key = array_search($request, $this->requests, true);
29
30			if ($key !== false) {
31			unset($this->requests[$key]);
32			}
33			$this->requests[] = $request;
34			}
35
36			public function all()
37			{
38			return $this->requests;
39			}
40
41			public function get($id)
42			{
43			if (isset($this->requests[$id])) {
44			return $this->requests[$id];
45			}
46
47			return null;
48			}
49
50			/**
51			* @param RpcRequest $request
52			* @return string\|int\|null
53			*/
54			public function getRequestIndex(RpcRequest $request)
55			{
56			return array_search($request, $this->requests);
57			}
58
59			/**
60			* @param $id
61			*/
62			public function remove($id)
63			{
64			unset($this->requests[$id]);
65			}
66
67			/**
68			* @param RpcRequestCollection $collection
69			*/
70			public function addCollection(RpcRequestCollection $collection)
71			{
72			foreach ($collection->all() as $id => $request) {
73			unset($this->requests[$id]);
74			$this->requests[$id] = $request;
75			}
76			}
77
78			/**
79			* @param $priorityNumber
80			*/
81			public function changePriority($priorityNumber)
82			{
83			if (!decoct(octdec($priorityNumber) == $priorityNumber)) {
84			$priorityNumber = decoct($priorityNumber);
85			}
86			$this->priority = $priorityNumber;
87			}
88
89			/**
90			* Return octect priority
91			*
92			* @return int
93			*/
94			public function getPriority()
95			{
96			return $this->priority;
97			}
98			}

contamobi / CmobiRabbitmqBundle

Push — master ( b48de3...82623c )

RpcRequestCollection::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like