Cmobi\RabbitmqBundle\Tests\Routing\Loader\YamlRpcLoaderTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	64
Duplicated Lines	31.25 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	2
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testLoadRouteInstance()	10	10	1
A	testLoadRouteName()	10	10	1
B	createParser()	0	29	2
A	getBundle()	0	8	1

<?php

namespace Cmobi\RabbitmqBundle\Tests\Routing\Loader;

use Cmobi\RabbitmqBundle\Routing\Loader\YamlRpcLoader;
use Cmobi\RabbitmqBundle\Tests\BaseTestCase;
use Symfony\Bundle\FrameworkBundle\Controller\ControllerNameParser;

class YamlRpcLoaderTest extends BaseTestCase
{

    public function testLoadRouteInstance()

This method seems to be duplicated in your project.

    {
        $parser = $this->createParser();
        $path = __DIR__ . '/../../app/config';
        $loader = new YamlRpcLoader($this->getContainer(), $path, $parser);

It seems like $this->getContainer() can be null; however, __construct() does not accept null, maybe add an additional type check?

        $methodCollection = $loader->load('rpc_routing.yml');
        $method = $methodCollection->get('cmobi_rabbitmq');

        $this->assertInstanceOf('Cmobi\RabbitmqBundle\Routing\Method', $method);
    }

    public function testLoadRouteName()

This method seems to be duplicated in your project.

    {
        $parser = $this->createParser();
        $path = __DIR__ . '/../../app/config';
        $loader = new YamlRpcLoader($this->getContainer(), $path, $parser);

It seems like $this->getContainer() can be null; however, __construct() does not accept null, maybe add an additional type check?

        $methodCollection = $loader->load('rpc_routing.yml');
        $method = $methodCollection->get('cmobi_rabbitmq');

        $this->assertSame('default', $method->getName());
    }

    private function createParser()
    {
        $bundles = array(
            'FooBundle' => array($this->getBundle('TestBundle\FooBundle', 'FooBundle')),
        );

        $kernel = $this->getMock('Symfony\Component\HttpKernel\KernelInterface');
        $kernel
            ->expects($this->any())
            ->method('getBundle')
            ->will($this->returnCallback(function ($bundle) use ($bundles) {
                if (!isset($bundles[$bundle])) {
                    throw new \InvalidArgumentException(sprintf('Invalid bundle name "%s"', $bundle));
                }

                return $bundles[$bundle];
            }))
        ;
        $bundles = [
            'FooBundle' => $this->getBundle('Cmobi\RabbitmqBUndle\FooBundle', 'CmobiRabbitmqBundle'),
        ];
        $kernel
            ->expects($this->any())
            ->method('getBundles')
            ->will($this->returnValue($bundles))
        ;

        return new ControllerNameParser($kernel);
    }

    private function getBundle($namespace, $name)
    {
        $bundle = $this->getMock('Symfony\Component\HttpKernel\Bundle\BundleInterface');
        $bundle->expects($this->any())->method('getName')->will($this->returnValue($name));
        $bundle->expects($this->any())->method('getNamespace')->will($this->returnValue($namespace));

        return $bundle;
    }
}