contamobi / CmobiRabbitmqBundle

Rpc/BaseService.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
      */
     public function createCallback()
     {
-        $callback = function (AMQPMessage $message) {
+        $callback = function(AMQPMessage $message) {
 
             $responseCollection = $this->rpcMessager->getResponseCollection();
             $requestCollection = $this->rpcMessager->getRequestCollection();

Doc Comments +1 added lines, -1 removed lines

@@ -93,7 +93,7 @@
 
     /**
      * @param AMQPMessage $message
-     * @param $content
+     * @param AMQPMessage $content
      */
     public function publish(AMQPMessage $message, $content)
     {

Routing/Loader/YamlRpcLoader.php

Doc Comments +3 added lines

@@ -34,6 +34,9 @@
         throw new ResourceNotFoundException(sprintf('No routes found for "%s".', $path));
     }
 
+    /**
+     * @param string $path
+     */
     public function matchCollection($path, MethodCollection $methods)
     {
         foreach ($methods as $name => $method) {

Tests/Routing/Loader/YamlRpcLoaderTest.php

Doc Comments +4 added lines

@@ -61,6 +61,10 @@
         return new ControllerNameParser($kernel);
     }
 
+    /**
+     * @param string $namespace
+     * @param string $name
+     */
     private function getBundle($namespace, $name)
     {
         $bundle = $this->getMock('Symfony\Component\HttpKernel\Bundle\BundleInterface');

Spacing +3 added lines, -3 removed lines

@@ -12,7 +12,7 @@ 
     public function testLoadRouteInstance()
     {
         $parser = $this->createParser();
-        $path = __DIR__ . '/../../app/config';
+        $path = __DIR__.'/../../app/config';
         $loader = new YamlRpcLoader($this->getContainer(), $path, $parser);
         $methodCollection = $loader->load('rpc_routing.yml');
         $method = $methodCollection->get('cmobi_rabbitmq');
@@ -23,7 +23,7 @@ 
     public function testLoadRouteName()
     {
         $parser = $this->createParser();
-        $path = __DIR__ . '/../../app/config';
+        $path = __DIR__.'/../../app/config';
         $loader = new YamlRpcLoader($this->getContainer(), $path, $parser);
         $methodCollection = $loader->load('rpc_routing.yml');
         $method = $methodCollection->get('cmobi_rabbitmq');
@@ -41,7 +41,7 @@ 
         $kernel
             ->expects($this->any())
             ->method('getBundle')
-            ->will($this->returnCallback(function ($bundle) use ($bundles) {
+            ->will($this->returnCallback(function($bundle) use ($bundles) {
                 if (!isset($bundles[$bundle])) {
                     throw new \InvalidArgumentException(sprintf('Invalid bundle name "%s"', $bundle));
                 }

Rpc/RpcClient.php

Doc Comments +1 added lines, -1 removed lines

@@ -164,7 +164,7 @@
     }
 
     /**
-     * @param $body
+     * @param string $body
      */
     private function handleRequest($body)
     {

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use Cmobi\RabbitmqBundle\Rpc\Request\RpcRequest;
 use Cmobi\RabbitmqBundle\Rpc\Request\RpcRequestCollection;
 use Cmobi\RabbitmqBundle\Rpc\Request\RpcRequestCollectionInterface;
-use Cmobi\RabbitmqBundle\Rpc\Request\RpcRequestInterface;
 use Cmobi\RabbitmqBundle\Rpc\Response\RpcResponse;
 use Cmobi\RabbitmqBundle\Rpc\Response\RpcResponseCollection;
 use PhpAmqpLib\Channel\AbstractChannel;

Spacing +4 added lines, -4 removed lines

@@ -42,7 +42,7 @@ 
      */
     public function onResponse(AMQPMessage $rep)
     {
-        if($rep->get('correlation_id') == $this->correlationId) {
+        if ($rep->get('correlation_id') == $this->correlationId) {
             $this->response = $rep->body;
         }
     }
@@ -192,8 +192,8 @@ 
         $expire = self::DEFAULT_TTL
     )
     {
-        list($callbackQueue, ,) = $this->getChannel()->queue_declare(
-            'callback_to_' . $this->getQueueName() . uniqid('', true), false, false, false, true, false, [
+        list($callbackQueue,,) = $this->getChannel()->queue_declare(
+            'callback_to_'.$this->getQueueName().uniqid('', true), false, false, false, true, false, [
                 'x-message-ttl' => ['I', $expire],
                 'x-max-priority' => ['I', RpcRequestCollectionInterface::PRIORITY_MAX]
             ]
@@ -214,7 +214,7 @@ 
         );
         $this->getChannel()->basic_publish($msg, '', $this->getQueueName());
 
-        while(!$this->response) {
+        while (!$this->response) {
             $this->getChannel()->wait();
         }
         $this->getChannel()->close();

Rpc/Exception/RpcInvalidRequestException.php

Spacing +1 added lines, -1 removed lines

@@ -7,7 +7,7 @@
 {
     const ERROR_CODE = -32600;
 
-    public function __construct($message = null,\Exception $previous = null)
+    public function __construct($message = null, \Exception $previous = null)
     {
         if (is_null($message)) {
             $message = 'Invalid Request';