WorkerQueueBag - Code Metrics - Inspection of "add optionResolver to QueueBags" - contamobi/CmobiRabbitmqBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 248a24...bb02de )

by Daniel

created 2017-01-05 21:15 UTC

WorkerQueueBag A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	208
Duplicated Lines	12.5 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	22
lcom	1
cbo	1
dl	26
loc	208
rs	10
c	0
b	0
f	0

22 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	13	1
A	setQueue()	0	4	1
A	getQueue()	0	4	1
A	setBasicQos()	0	4	1
A	getBasicQos()	0	4	1
A	getPassive()	0	4	1
A	getDurable()	0	4	1
A	getExclusive()	0	4	1
A	getAutoDelete()	0	4	1
A	getNoWait()	0	4	1
A	getTicket()	0	4	1
A	getConsumerTag()	0	4	1
A	getNoAck()	0	4	1
A	getNoLocal()	0	4	1
A	setArguments()	0	4	1
A	getArguments()	0	4	1
A	getQueueDeclare()	13	13	1
A	getQueueConsume()	13	13	1
A	getExchangeDeclare()	0	4	1
A	getExchange()	0	4	1
A	getType()	0	4	1
A	registerOptions()	0	6	1

How to fix Duplicated Code

<?php

namespace Cmobi\RabbitmqBundle\Transport\Worker;

use Cmobi\RabbitmqBundle\Queue\QueueBagInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class WorkerQueueBag implements QueueBagInterface
{
    private $resolver;
    private $options;

    public function __construct(
        $queueName,
        $basicQos = 1,
        array $arguments = null
    ) {
        $this->resolver = new OptionsResolver();
        $this->resolver->setDefaults([
            'queue_name' => $queueName,
            'basic_qos' => $basicQos,
            'arguments' => $arguments
        ]);
        $this->options = $this->resolver->resolve([]);
    }

    /**
     * @param $queue
     */
    public function setQueue($queue)
    {
        $this->options['queue_name'] = $queue;
    }

    /**
     * @return string|mixed
     */
    public function getQueue()
    {
        return $this->options['queue_name'];
    }

    /**
     * @param $qos
     */
    public function setBasicQos($qos)
    {
        $this->options['basic_qos'] = $qos;
    }

    /**
     * @return int
     */
    public function getBasicQos()
    {
        return $this->options['basic_qos'];
    }

    /**
     * @return bool
     */
    public function getPassive()
    {
        return false;
    }

    /**
     * @return bool
     */
    public function getDurable()
    {
        return true;
    }

    /**
     * @return bool
     */
    public function getExclusive()
    {
        return false;
    }

    /**
     * @return bool
     */
    public function getAutoDelete()
    {
        return false;
    }

    /**
     * @return bool
     */
    public function getNoWait()
    {
        return false;
    }

    /**
     * @return null
     */
    public function getTicket()
    {
        return null;
    }

    /**
     * @return string
     */
    public function getConsumerTag()
    {
        return '';
    }

    /**
     * @return bool
     */
    public function getNoAck()
    {
        return false;
    }

    /**
     * @return bool
     */
    public function getNoLocal()
    {
        return false;
    }

    /**
     * @param array $arguments
     */
    public function setArguments(array $arguments)
    {
        $this->options['arguments'] = $arguments;
    }

    /**
     * @return string
     */
    public function getArguments()
    {
        return $this->options['arguments'];
    }

    /**
     * @return array
     */
    public function getQueueDeclare()

    {
        return [
            $this->getQueue(),
            $this->getPassive(),
            $this->getDurable(),
            $this->getExclusive(),
            $this->getAutoDelete(),
            $this->getNoWait(),
            $this->getArguments(),
            $this->getTicket(),
        ];
    }

    /**
     * @return array
     */
    public function getQueueConsume()

    {
        return [
            $this->getQueue(),
            $this->getConsumerTag(),
            $this->getNoLocal(),
            $this->getNoAck(),
            $this->getExclusive(),
            $this->getNoWait(),
            $this->getTicket(),
            $this->getArguments(),
        ];
    }

    /**
     * @return array|false
     */
    public function getExchangeDeclare()
    {
        return false;
    }

    /**
     * @return string
     */
    public function getExchange()
    {
        return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @return string
     */
    public function getType()
    {
        return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @param array $options
     * @return QueueBagInterface
     */
    public function registerOptions(array $options)
    {
        $this->options = $this->resolver->resolve($options);

        return $this;
    }
}


1		<?php
2
3		namespace Cmobi\RabbitmqBundle\Transport\Worker;
4
5		use Cmobi\RabbitmqBundle\Queue\QueueBagInterface;
6		use Symfony\Component\OptionsResolver\OptionsResolver;
7
8		class WorkerQueueBag implements QueueBagInterface
9		{
10		private $resolver;
11		private $options;
12
13		public function __construct(
14		$queueName,
15		$basicQos = 1,
16		array $arguments = null
17		) {
18		$this->resolver = new OptionsResolver();
19		$this->resolver->setDefaults([
20		'queue_name' => $queueName,
21		'basic_qos' => $basicQos,
22		'arguments' => $arguments
23		]);
24		$this->options = $this->resolver->resolve([]);
25		}
26
27		/**
28		* @param $queue
29		*/
30		public function setQueue($queue)
31		{
32		$this->options['queue_name'] = $queue;
33		}
34
35		/**
36		* @return string\|mixed
37		*/
38		public function getQueue()
39		{
40		return $this->options['queue_name'];
41		}
42
43		/**
44		* @param $qos
45		*/
46		public function setBasicQos($qos)
47		{
48		$this->options['basic_qos'] = $qos;
49		}
50
51		/**
52		* @return int
53		*/
54		public function getBasicQos()
55		{
56		return $this->options['basic_qos'];
57		}
58
59		/**
60		* @return bool
61		*/
62		public function getPassive()
63		{
64		return false;
65		}
66
67		/**
68		* @return bool
69		*/
70		public function getDurable()
71		{
72		return true;
73		}
74
75		/**
76		* @return bool
77		*/
78		public function getExclusive()
79		{
80		return false;
81		}
82
83		/**
84		* @return bool
85		*/
86		public function getAutoDelete()
87		{
88		return false;
89		}
90
91		/**
92		* @return bool
93		*/
94		public function getNoWait()
95		{
96		return false;
97		}
98
99		/**
100		* @return null
101		*/
102		public function getTicket()
103		{
104		return null;
105		}
106
107		/**
108		* @return string
109		*/
110		public function getConsumerTag()
111		{
112		return '';
113		}
114
115		/**
116		* @return bool
117		*/
118		public function getNoAck()
119		{
120		return false;
121		}
122
123		/**
124		* @return bool
125		*/
126		public function getNoLocal()
127		{
128		return false;
129		}
130
131		/**
132		* @param array $arguments
133		*/
134		public function setArguments(array $arguments)
135		{
136		$this->options['arguments'] = $arguments;
137		}
138
139		/**
140		* @return string
141		*/
142		public function getArguments()
143		{
144		return $this->options['arguments'];
145		}
146
147		/**
148		* @return array
149		*/
150	View Code Duplication	public function getQueueDeclare()
		0 ignored issues – show Duplication introduced 2017-01-05 21:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
151		{
152		return [
153		$this->getQueue(),
154		$this->getPassive(),
155		$this->getDurable(),
156		$this->getExclusive(),
157		$this->getAutoDelete(),
158		$this->getNoWait(),
159		$this->getArguments(),
160		$this->getTicket(),
161		];
162		}
163
164		/**
165		* @return array
166		*/
167	View Code Duplication	public function getQueueConsume()
		0 ignored issues – show Duplication introduced 2017-01-05 21:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
168		{
169		return [
170		$this->getQueue(),
171		$this->getConsumerTag(),
172		$this->getNoLocal(),
173		$this->getNoAck(),
174		$this->getExclusive(),
175		$this->getNoWait(),
176		$this->getTicket(),
177		$this->getArguments(),
178		];
179		}
180
181		/**
182		* @return array\|false
183		*/
184		public function getExchangeDeclare()
185		{
186		return false;
187		}
188
189		/**
190		* @return string
191		*/
192		public function getExchange()
193		{
194		return false;
		0 ignored issues – show Bug Best Practice introduced 2016-12-28 18:51 UTC by Report Bug Copy Issue Report The return type of `return false;` (`false`) is incompatible with the return type declared by the interface `Cmobi\RabbitmqBundle\Que...gInterface::getExchange` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
195		}
196
197		/**
198		* @return string
199		*/
200		public function getType()
201		{
202		return false;
		0 ignored issues – show Bug Best Practice introduced 2016-12-28 18:51 UTC by Report Bug Copy Issue Report The return type of `return false;` (`false`) is incompatible with the return type declared by the interface `Cmobi\RabbitmqBundle\Que...ueBagInterface::getType` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
203		}
204
205		/**
206		* @param array $options
207		* @return QueueBagInterface
208		*/
209		public function registerOptions(array $options)
210		{
211		$this->options = $this->resolver->resolve($options);
212
213		return $this;
214		}
215		}
216

contamobi / CmobiRabbitmqBundle

Push — master ( 248a24...bb02de )

WorkerQueueBag A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

22 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like