RpcQueueBag - Code Metrics - Inspection of "add optionResolver to QueueBags" - contamobi/CmobiRabbitmqBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 248a24...bb02de )

by Daniel

created 2017-01-05 21:15 UTC

RpcQueueBag A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	220
Duplicated Lines	19.55 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	23
lcom	1
cbo	1
dl	43
loc	220
rs	10
c	0
b	0
f	0

23 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	17	17	1
A	setQueue()	0	4	1
A	getQueue()	0	4	1
A	setBasicQos()	0	4	1
A	getBasicQos()	0	4	1
A	setAutoDelete()	0	4	1
A	getAutoDelete()	0	4	1
A	setArguments()	0	4	1
A	getArguments()	0	4	1
A	getPassive()	0	4	1
A	getDurable()	0	4	1
A	getExclusive()	0	4	1
A	getNoWait()	0	4	1
A	getTicket()	0	4	1
A	getConsumerTag()	0	4	1
A	getNoAck()	0	4	1
A	getNoLocal()	0	4	1
A	getExchangeDeclare()	0	4	1
A	getExchange()	0	4	1
A	getType()	0	4	1
A	getQueueDeclare()	13	13	1
A	getQueueConsume()	13	13	1
A	registerOptions()	0	6	1

How to fix Duplicated Code

<?php

namespace Cmobi\RabbitmqBundle\Transport\Rpc;

use Cmobi\RabbitmqBundle\Queue\QueueBagInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class RpcQueueBag implements QueueBagInterface
{
    private $resolver;
    private $options;

    public function __construct(

        $queueName,
        $basicQos = 1,
        $durable = false,
        $autoDelete = true,
        array $arguments = null
    ) {
        $this->resolver = new OptionsResolver();
        $this->resolver->setDefaults([
            'queue_name' => $queueName,
            'basic_qos' => $basicQos,
            'durable' => $durable,
            'auto_delete' => $autoDelete,
            'arguments' => $arguments
        ]);
        $this->options = $this->resolver->resolve([]);
    }

    /**
     * @param $queue
     */
    public function setQueue($queue)
    {
        $this->options['queue_name'] = $queue;
    }

    /**
     * @return string|mixed
     */
    public function getQueue()
    {
        return $this->options['queue_name'];
    }

    /**
     * @param $qos
     */
    public function setBasicQos($qos)
    {
        $this->options['basic_qos'] = $qos;
    }

    /**
     * @return int
     */
    public function getBasicQos()
    {
        return $this->options['basic_qos'];
    }

    /**
     * @param $autoDelete
     */
    public function setAutoDelete($autoDelete)
    {
        $this->options['auto_delete'] = $autoDelete;
    }

    /**
     * @return bool
     */
    public function getAutoDelete()
    {
        return $this->options['auto_delete'];
    }

    /**
     * @param array $arguments
     */
    public function setArguments(array $arguments)
    {
        $this->options['arguments'] = $arguments;
    }

    /**
     * @return string
     */
    public function getArguments()
    {
        return $this->options['arguments'];
    }

    /**
     * @return bool
     */
    public function getPassive()
    {
        return false;
    }

    /**
     * @return bool
     */
    public function getDurable()
    {
        return false;
    }

    /**
     * @return bool
     */
    public function getExclusive()
    {
        return false;
    }

    /**
     * @return bool
     */
    public function getNoWait()
    {
        return false;
    }

    /**
     * @return null
     */
    public function getTicket()
    {
        return null;
    }

    /**
     * @return string
     */
    public function getConsumerTag()
    {
        return '';
    }

    /**
     * @return bool
     */
    public function getNoAck()
    {
        return false;
    }

    /**
     * @return bool
     */
    public function getNoLocal()
    {
        return false;
    }

    /**
     * @return array|false
     */
    public function getExchangeDeclare()
    {
        return false;
    }

    /**
     * @return string
     */
    public function getExchange()
    {
        return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @return string
     */
    public function getType()
    {
        return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @return array
     */
    public function getQueueDeclare()

    {
        return [
            $this->getQueue(),
            $this->getPassive(),
            $this->getDurable(),
            $this->getExclusive(),
            $this->getAutoDelete(),
            $this->getNoWait(),
            $this->getArguments(),
            $this->getTicket(),
        ];
    }

    /**
     * @return array
     */
    public function getQueueConsume()

    {
        return [
            $this->getQueue(),
            $this->getConsumerTag(),
            $this->getNoLocal(),
            $this->getNoAck(),
            $this->getExclusive(),
            $this->getNoWait(),
            $this->getTicket(),
            $this->getArguments(),
        ];
    }

    /**
     * @param array $options
     * @return QueueBagInterface
     */
    public function registerOptions(array $options)
    {
        $this->options = $this->resolver->resolve($options);

        return $this;
    }
}


1		<?php
2
3		namespace Cmobi\RabbitmqBundle\Transport\Rpc;
4
5		use Cmobi\RabbitmqBundle\Queue\QueueBagInterface;
6		use Symfony\Component\OptionsResolver\OptionsResolver;
7
8		class RpcQueueBag implements QueueBagInterface
9		{
10		private $resolver;
11		private $options;
12
13	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2017-01-05 21:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14		$queueName,
15		$basicQos = 1,
16		$durable = false,
17		$autoDelete = true,
18		array $arguments = null
19		) {
20		$this->resolver = new OptionsResolver();
21		$this->resolver->setDefaults([
22		'queue_name' => $queueName,
23		'basic_qos' => $basicQos,
24		'durable' => $durable,
25		'auto_delete' => $autoDelete,
26		'arguments' => $arguments
27		]);
28		$this->options = $this->resolver->resolve([]);
29		}
30
31		/**
32		* @param $queue
33		*/
34		public function setQueue($queue)
35		{
36		$this->options['queue_name'] = $queue;
37		}
38
39		/**
40		* @return string\|mixed
41		*/
42		public function getQueue()
43		{
44		return $this->options['queue_name'];
45		}
46
47		/**
48		* @param $qos
49		*/
50		public function setBasicQos($qos)
51		{
52		$this->options['basic_qos'] = $qos;
53		}
54
55		/**
56		* @return int
57		*/
58		public function getBasicQos()
59		{
60		return $this->options['basic_qos'];
61		}
62
63		/**
64		* @param $autoDelete
65		*/
66		public function setAutoDelete($autoDelete)
67		{
68		$this->options['auto_delete'] = $autoDelete;
69		}
70
71		/**
72		* @return bool
73		*/
74		public function getAutoDelete()
75		{
76		return $this->options['auto_delete'];
77		}
78
79		/**
80		* @param array $arguments
81		*/
82		public function setArguments(array $arguments)
83		{
84		$this->options['arguments'] = $arguments;
85		}
86
87		/**
88		* @return string
89		*/
90		public function getArguments()
91		{
92		return $this->options['arguments'];
93		}
94
95		/**
96		* @return bool
97		*/
98		public function getPassive()
99		{
100		return false;
101		}
102
103		/**
104		* @return bool
105		*/
106		public function getDurable()
107		{
108		return false;
109		}
110
111		/**
112		* @return bool
113		*/
114		public function getExclusive()
115		{
116		return false;
117		}
118
119		/**
120		* @return bool
121		*/
122		public function getNoWait()
123		{
124		return false;
125		}
126
127		/**
128		* @return null
129		*/
130		public function getTicket()
131		{
132		return null;
133		}
134
135		/**
136		* @return string
137		*/
138		public function getConsumerTag()
139		{
140		return '';
141		}
142
143		/**
144		* @return bool
145		*/
146		public function getNoAck()
147		{
148		return false;
149		}
150
151		/**
152		* @return bool
153		*/
154		public function getNoLocal()
155		{
156		return false;
157		}
158
159		/**
160		* @return array\|false
161		*/
162		public function getExchangeDeclare()
163		{
164		return false;
165		}
166
167		/**
168		* @return string
169		*/
170		public function getExchange()
171		{
172		return false;
		0 ignored issues – show Bug Best Practice introduced 2016-12-28 18:51 UTC by Report Bug Copy Issue Report The return type of `return false;` (`false`) is incompatible with the return type declared by the interface `Cmobi\RabbitmqBundle\Que...gInterface::getExchange` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
173		}
174
175		/**
176		* @return string
177		*/
178		public function getType()
179		{
180		return false;
		0 ignored issues – show Bug Best Practice introduced 2016-12-28 18:51 UTC by Report Bug Copy Issue Report The return type of `return false;` (`false`) is incompatible with the return type declared by the interface `Cmobi\RabbitmqBundle\Que...ueBagInterface::getType` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
181		}
182
183		/**
184		* @return array
185		*/
186	View Code Duplication	public function getQueueDeclare()
		0 ignored issues – show Duplication introduced 2017-01-05 21:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
187		{
188		return [
189		$this->getQueue(),
190		$this->getPassive(),
191		$this->getDurable(),
192		$this->getExclusive(),
193		$this->getAutoDelete(),
194		$this->getNoWait(),
195		$this->getArguments(),
196		$this->getTicket(),
197		];
198		}
199
200		/**
201		* @return array
202		*/
203	View Code Duplication	public function getQueueConsume()
		0 ignored issues – show Duplication introduced 2017-01-05 21:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
204		{
205		return [
206		$this->getQueue(),
207		$this->getConsumerTag(),
208		$this->getNoLocal(),
209		$this->getNoAck(),
210		$this->getExclusive(),
211		$this->getNoWait(),
212		$this->getTicket(),
213		$this->getArguments(),
214		];
215		}
216
217		/**
218		* @param array $options
219		* @return QueueBagInterface
220		*/
221		public function registerOptions(array $options)
222		{
223		$this->options = $this->resolver->resolve($options);
224
225		return $this;
226		}
227		}
228

contamobi / CmobiRabbitmqBundle

Push — master ( 248a24...bb02de )

RpcQueueBag A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

23 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like