WorkerBuilder::__construct() - Code Metrics - Inspection of "Migration to msf bundle" - contamobi/CmobiRabbitmqBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Daniel

created 2016-12-28 18:40 UTC

WorkerBuilder::__construct() A

↳ Parent: WorkerBuilder

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	7
Ratio	100 %

Importance

Changes

Metric	Value
dl	7
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	3

<?php

namespace Cmobi\RabbitmqBundle\Transport\Worker;

use Cmobi\RabbitmqBundle\Connection\ConnectionManager;
use Cmobi\RabbitmqBundle\Connection\Exception\InvalidAMQPChannelException;
use Cmobi\RabbitmqBundle\Queue\Queue;
use Cmobi\RabbitmqBundle\Queue\QueueBuilderInterface;
use Cmobi\RabbitmqBundle\Queue\QueueServiceInterface;
use Psr\Log\LoggerInterface;

class WorkerBuilder implements QueueBuilderInterface

{
    private $connectionManager;
    private $logger;
    private $parameters;

    public function __construct(ConnectionManager $connManager, LoggerInterface $logger, array $parameters)
    {
        $this->connectionManager = $connManager;
        $this->logger = $logger;
        $this->parameters = $parameters;
        $this->channel = null;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @param $queueName
     * @param QueueServiceInterface $queueService
     *
     * @return Queue
     *
     * @throws InvalidAMQPChannelException
     */
    public function buildQueue($queueName, QueueServiceInterface $queueService)
    {
        $qos = 1;

        if (array_key_exists('cmobi_rabbitmq.basic_qos', $this->parameters)) {
            $qos = $this->parameters['cmobi_rabbitmq.basic_qos'];
        }
        $rpcQueueBag = new WorkerQueueBag($queueName, $qos);

        $queue = new Queue($this->getConnectionManager(), $rpcQueueBag, $this->logger);
        $queueCallback = new WorkerQueueCallback($queueService);
        $queue->setCallback($queueCallback);

        return $queue;
    }

    /**
     * @return ConnectionManager
     */
    public function getConnectionManager()
    {
        return $this->connectionManager;
    }

    /**
     * @return string|false
     */
    public function getExchangeName()
    {
        return false;
    }

    /**
     * @return string|false
     */
    public function getExchangeType()
    {
        return false;
    }
}


1		<?php
2
3		namespace Cmobi\RabbitmqBundle\Transport\Worker;
4
5		use Cmobi\RabbitmqBundle\Connection\ConnectionManager;
6		use Cmobi\RabbitmqBundle\Connection\Exception\InvalidAMQPChannelException;
7		use Cmobi\RabbitmqBundle\Queue\Queue;
8		use Cmobi\RabbitmqBundle\Queue\QueueBuilderInterface;
9		use Cmobi\RabbitmqBundle\Queue\QueueServiceInterface;
10		use Psr\Log\LoggerInterface;
11
12	View Code Duplication	class WorkerBuilder implements QueueBuilderInterface
		0 ignored issues – show Duplication introduced 2016-12-28 18:51 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		private $connectionManager;
15		private $logger;
16		private $parameters;
17
18		public function __construct(ConnectionManager $connManager, LoggerInterface $logger, array $parameters)
19		{
20		$this->connectionManager = $connManager;
21		$this->logger = $logger;
22		$this->parameters = $parameters;
23		$this->channel = null;
		0 ignored issues – show Bug introduced 2016-12-28 18:51 UTC by Report Bug Copy Issue Report The property `channel` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24		}
25
26		/**
27		* @param $queueName
28		* @param QueueServiceInterface $queueService
29		*
30		* @return Queue
31		*
32		* @throws InvalidAMQPChannelException
33		*/
34		public function buildQueue($queueName, QueueServiceInterface $queueService)
35		{
36		$qos = 1;
37
38		if (array_key_exists('cmobi_rabbitmq.basic_qos', $this->parameters)) {
39		$qos = $this->parameters['cmobi_rabbitmq.basic_qos'];
40		}
41		$rpcQueueBag = new WorkerQueueBag($queueName, $qos);
42
43		$queue = new Queue($this->getConnectionManager(), $rpcQueueBag, $this->logger);
44		$queueCallback = new WorkerQueueCallback($queueService);
45		$queue->setCallback($queueCallback);
46
47		return $queue;
48		}
49
50		/**
51		* @return ConnectionManager
52		*/
53		public function getConnectionManager()
54		{
55		return $this->connectionManager;
56		}
57
58		/**
59		* @return string\|false
60		*/
61		public function getExchangeName()
62		{
63		return false;
64		}
65
66		/**
67		* @return string\|false
68		*/
69		public function getExchangeType()
70		{
71		return false;
72		}
73		}
74

contamobi / CmobiRabbitmqBundle

Pull Request — master (#1)

WorkerBuilder::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like