RpcQueueCallback::toClosure() - Code Metrics - Inspection of "Migration to msf bundle" - contamobi/CmobiRabbitmqBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Daniel

created 2016-12-28 18:40 UTC

RpcQueueCallback::toClosure() A

↳ Parent: RpcQueueCallback

Complexity

Conditions	1
Paths	1

Size

Total Lines	20
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	12
nc	1
nop	0

<?php

namespace Cmobi\RabbitmqBundle\Transport\Rpc;

use Cmobi\RabbitmqBundle\Queue\CmobiAMQPMessage;
use Cmobi\RabbitmqBundle\Queue\QueueCallbackInterface;
use Cmobi\RabbitmqBundle\Queue\QueueServiceInterface;
use PhpAmqpLib\Message\AMQPMessage;

class RpcQueueCallback implements QueueCallbackInterface
{
    private $queueService;

    public function __construct(QueueServiceInterface $queueService)
    {
        $this->queueService = $queueService;
    }

    /**
     * @return QueueServiceInterface
     */
    public function getQueueService()
    {
        return $this->queueService;
    }

    /**
     * @return \Closure
     */
    public function toClosure()
    {
        return function (AMQPMessage $message) {
            $response = $this->getQueueService()->handle($message);

            $amqpResponse = new CmobiAMQPMessage(
                (string) $response,
                ['correlation_id' => $message->get('correlation_id')]
            );

            $message->delivery_info['channel']->basic_publish(
                $amqpResponse,
                '',
                $message->get('reply_to')
            );
            $message->delivery_info['channel']->basic_ack(
                $message->delivery_info['delivery_tag']
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            );
        };
    }
}


1			<?php
2
3			namespace Cmobi\RabbitmqBundle\Transport\Rpc;
4
5			use Cmobi\RabbitmqBundle\Queue\CmobiAMQPMessage;
6			use Cmobi\RabbitmqBundle\Queue\QueueCallbackInterface;
7			use Cmobi\RabbitmqBundle\Queue\QueueServiceInterface;
8			use PhpAmqpLib\Message\AMQPMessage;
9
10			class RpcQueueCallback implements QueueCallbackInterface
11			{
12			private $queueService;
13
14			public function __construct(QueueServiceInterface $queueService)
15			{
16			$this->queueService = $queueService;
17			}
18
19			/**
20			* @return QueueServiceInterface
21			*/
22			public function getQueueService()
23			{
24			return $this->queueService;
25			}
26
27			/**
28			* @return \Closure
29			*/
30			public function toClosure()
31			{
32			return function (AMQPMessage $message) {
33			$response = $this->getQueueService()->handle($message);
34
35			$amqpResponse = new CmobiAMQPMessage(
36			(string) $response,
37			['correlation_id' => $message->get('correlation_id')]
38			);
39
40			$message->delivery_info['channel']->basic_publish(
41			$amqpResponse,
42			'',
43			$message->get('reply_to')
44			);
45			$message->delivery_info['channel']->basic_ack(
46			$message->delivery_info['delivery_tag']
			0 ignored issues – show Documentation introduced 2016-12-28 18:51 UTC by Report Bug Copy Issue Report `$message->delivery_info['delivery_tag']` is of type `object<PhpAmqpLib\Channel\AMQPChannel>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
47			);
48			};
49			}
50			}
51

contamobi / CmobiRabbitmqBundle

Pull Request — master (#1)

RpcQueueCallback::toClosure() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like