WorkerQueueBag - Code Metrics - Inspection of "Migration to msf bundle" - contamobi/CmobiRabbitmqBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Daniel

created 2016-12-28 18:40 UTC

WorkerQueueBag A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	284
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	30
lcom	1
cbo	0
dl	284
loc	284
rs	10
c	0
b	0
f	0

30 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	29	29	1
A	setQueue()	4	4	1
A	getQueue()	4	4	1
A	setBasicQos()	4	4	1
A	getBasicQos()	4	4	1
A	setPassive()	4	4	1
A	getPassive()	4	4	1
A	setDurable()	4	4	1
A	getDurable()	4	4	1
A	setExclusive()	4	4	1
A	getExclusive()	4	4	1
A	setAutoDelete()	4	4	1
A	getAutoDelete()	4	4	1
A	setNoWait()	4	4	1
A	getNoWait()	4	4	1
A	setArguments()	4	4	1
A	getArguments()	4	4	1
A	setTicket()	4	4	1
A	getTicket()	4	4	1
A	setConsumerTag()	4	4	1
A	getConsumerTag()	4	4	1
A	setNoAck()	4	4	1
A	getNoAck()	4	4	1
A	setNoLocal()	4	4	1
A	getNoLocal()	4	4	1
A	getQueueDeclare()	13	13	1
A	getQueueConsume()	13	13	1
A	getExchangeDeclare()	4	4	1
A	getExchange()	4	4	1
A	getType()	4	4	1

How to fix Duplicated Code

<?php

namespace Cmobi\RabbitmqBundle\Transport\Worker;

use Cmobi\RabbitmqBundle\Queue\QueueBagInterface;

class WorkerQueueBag implements QueueBagInterface

{
    private $options;

    public function __construct(
        $queue,
        $basicQos = 1,
        $passive = false,
        $durable = true,
        $exclusive = false,
        $autoDelete = false,
        $noWait = false,
        array $arguments = null,
        $ticket = null,
        $consumerTag = '',
        $noAck = false,
        $noLocal = false
    ) {
        $this->options = [
            'queue' => $queue,
            'basic_qos' => $basicQos,
            'passive' => $passive,
            'durable' => $durable,
            'exclusive' => $exclusive,
            'auto_delete' => $autoDelete,
            'no_wait' => $noWait,
            'arguments' => $arguments,
            'ticket' => $ticket,
            'consumer_tag' => $consumerTag,
            'no_ack' => $noAck,
            'no_local' => $noLocal,
        ];
    }

    /**
     * @param $queue
     */
    public function setQueue($queue)
    {
        $this->options['queue'] = $queue;
    }

    /**
     * @return string|mixed
     */
    public function getQueue()
    {
        return $this->options['queue'];
    }

    /**
     * @param $qos
     */
    public function setBasicQos($qos)
    {
        $this->options['basic_qos'] = $qos;
    }

    /**
     * @return int
     */
    public function getBasicQos()
    {
        return $this->options['basic_qos'];
    }

    /**
     * @param $passive
     */
    public function setPassive($passive)
    {
        $this->options['passive'] = $passive;
    }

    /**
     * @return bool
     */
    public function getPassive()
    {
        return $this->options['passive'];
    }

    /**
     * @param $durable
     */
    public function setDurable($durable)
    {
        $this->options['durable'] = $durable;
    }

    /**
     * @return bool
     */
    public function getDurable()
    {
        return $this->options['durable'];
    }

    /**
     * @param $exclusive
     */
    public function setExclusive($exclusive)
    {
        $this->options['exclusive'] = $exclusive;
    }

    /**
     * @return bool
     */
    public function getExclusive()
    {
        return $this->options['exclusive'];
    }

    /**
     * @param $autoDelete
     */
    public function setAutoDelete($autoDelete)
    {
        $this->options['auto_delete'] = $autoDelete;
    }

    /**
     * @return bool
     */
    public function getAutoDelete()
    {
        return $this->options['auto_delete'];
    }

    /**
     * @param $noWait
     */
    public function setNoWait($noWait)
    {
        $this->options['no_wait'] = $noWait;
    }

    /**
     * @return bool
     */
    public function getNoWait()
    {
        return $this->options['no_wait'];
    }

    /**
     * @param array $arguments
     */
    public function setArguments(array $arguments)
    {
        $this->options['arguments'] = $arguments;
    }

    /**
     * @return string
     */
    public function getArguments()
    {
        return $this->options['arguments'];
    }

    /**
     * @param $ticket
     */
    public function setTicket($ticket)
    {
        $this->options['ticket'] = $ticket;
    }

    /**
     * @return string
     */
    public function getTicket()
    {
        return $this->options['ticket'];
    }

    /**
     * @param $consumerTag
     */
    public function setConsumerTag($consumerTag)
    {
        $this->options['consumer_tag'] = $consumerTag;
    }

    /**
     * @return string
     */
    public function getConsumerTag()
    {
        return $this->options['consumer_tag'];
    }

    /**
     * @param $noAck
     */
    public function setNoAck($noAck)
    {
        $this->options['no_ack'] = $noAck;
    }

    /**
     * @return bool
     */
    public function getNoAck()
    {
        return $this->options['no_ack'];
    }

    /**
     * @param $noLocal
     */
    public function setNoLocal($noLocal)
    {
        $this->options['no_local'] = $noLocal;
    }

    /**
     * @return bool
     */
    public function getNoLocal()
    {
        return $this->options['no_local'];
    }

    /**
     * @return array
     */
    public function getQueueDeclare()
    {
        return [
            $this->getQueue(),
            $this->getPassive(),
            $this->getDurable(),
            $this->getExclusive(),
            $this->getAutoDelete(),
            $this->getNoWait(),
            $this->getArguments(),
            $this->getTicket(),
        ];
    }

    /**
     * @return array
     */
    public function getQueueConsume()
    {
        return [
            $this->getQueue(),
            $this->getConsumerTag(),
            $this->getNoLocal(),
            $this->getNoAck(),
            $this->getExclusive(),
            $this->getNoWait(),
            $this->getTicket(),
            $this->getArguments(),
        ];
    }

    /**
     * @return array|false
     */
    public function getExchangeDeclare()
    {
        return false;
    }

    /**
     * @return string
     */
    public function getExchange()
    {
        return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @return string
     */
    public function getType()
    {
        return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1		<?php
2
3		namespace Cmobi\RabbitmqBundle\Transport\Worker;
4
5		use Cmobi\RabbitmqBundle\Queue\QueueBagInterface;
6
7	View Code Duplication	class WorkerQueueBag implements QueueBagInterface
		0 ignored issues – show Duplication introduced 2016-12-28 18:51 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
8		{
9		private $options;
10
11		public function __construct(
12		$queue,
13		$basicQos = 1,
14		$passive = false,
15		$durable = true,
16		$exclusive = false,
17		$autoDelete = false,
18		$noWait = false,
19		array $arguments = null,
20		$ticket = null,
21		$consumerTag = '',
22		$noAck = false,
23		$noLocal = false
24		) {
25		$this->options = [
26		'queue' => $queue,
27		'basic_qos' => $basicQos,
28		'passive' => $passive,
29		'durable' => $durable,
30		'exclusive' => $exclusive,
31		'auto_delete' => $autoDelete,
32		'no_wait' => $noWait,
33		'arguments' => $arguments,
34		'ticket' => $ticket,
35		'consumer_tag' => $consumerTag,
36		'no_ack' => $noAck,
37		'no_local' => $noLocal,
38		];
39		}
40
41		/**
42		* @param $queue
43		*/
44		public function setQueue($queue)
45		{
46		$this->options['queue'] = $queue;
47		}
48
49		/**
50		* @return string\|mixed
51		*/
52		public function getQueue()
53		{
54		return $this->options['queue'];
55		}
56
57		/**
58		* @param $qos
59		*/
60		public function setBasicQos($qos)
61		{
62		$this->options['basic_qos'] = $qos;
63		}
64
65		/**
66		* @return int
67		*/
68		public function getBasicQos()
69		{
70		return $this->options['basic_qos'];
71		}
72
73		/**
74		* @param $passive
75		*/
76		public function setPassive($passive)
77		{
78		$this->options['passive'] = $passive;
79		}
80
81		/**
82		* @return bool
83		*/
84		public function getPassive()
85		{
86		return $this->options['passive'];
87		}
88
89		/**
90		* @param $durable
91		*/
92		public function setDurable($durable)
93		{
94		$this->options['durable'] = $durable;
95		}
96
97		/**
98		* @return bool
99		*/
100		public function getDurable()
101		{
102		return $this->options['durable'];
103		}
104
105		/**
106		* @param $exclusive
107		*/
108		public function setExclusive($exclusive)
109		{
110		$this->options['exclusive'] = $exclusive;
111		}
112
113		/**
114		* @return bool
115		*/
116		public function getExclusive()
117		{
118		return $this->options['exclusive'];
119		}
120
121		/**
122		* @param $autoDelete
123		*/
124		public function setAutoDelete($autoDelete)
125		{
126		$this->options['auto_delete'] = $autoDelete;
127		}
128
129		/**
130		* @return bool
131		*/
132		public function getAutoDelete()
133		{
134		return $this->options['auto_delete'];
135		}
136
137		/**
138		* @param $noWait
139		*/
140		public function setNoWait($noWait)
141		{
142		$this->options['no_wait'] = $noWait;
143		}
144
145		/**
146		* @return bool
147		*/
148		public function getNoWait()
149		{
150		return $this->options['no_wait'];
151		}
152
153		/**
154		* @param array $arguments
155		*/
156		public function setArguments(array $arguments)
157		{
158		$this->options['arguments'] = $arguments;
159		}
160
161		/**
162		* @return string
163		*/
164		public function getArguments()
165		{
166		return $this->options['arguments'];
167		}
168
169		/**
170		* @param $ticket
171		*/
172		public function setTicket($ticket)
173		{
174		$this->options['ticket'] = $ticket;
175		}
176
177		/**
178		* @return string
179		*/
180		public function getTicket()
181		{
182		return $this->options['ticket'];
183		}
184
185		/**
186		* @param $consumerTag
187		*/
188		public function setConsumerTag($consumerTag)
189		{
190		$this->options['consumer_tag'] = $consumerTag;
191		}
192
193		/**
194		* @return string
195		*/
196		public function getConsumerTag()
197		{
198		return $this->options['consumer_tag'];
199		}
200
201		/**
202		* @param $noAck
203		*/
204		public function setNoAck($noAck)
205		{
206		$this->options['no_ack'] = $noAck;
207		}
208
209		/**
210		* @return bool
211		*/
212		public function getNoAck()
213		{
214		return $this->options['no_ack'];
215		}
216
217		/**
218		* @param $noLocal
219		*/
220		public function setNoLocal($noLocal)
221		{
222		$this->options['no_local'] = $noLocal;
223		}
224
225		/**
226		* @return bool
227		*/
228		public function getNoLocal()
229		{
230		return $this->options['no_local'];
231		}
232
233		/**
234		* @return array
235		*/
236		public function getQueueDeclare()
237		{
238		return [
239		$this->getQueue(),
240		$this->getPassive(),
241		$this->getDurable(),
242		$this->getExclusive(),
243		$this->getAutoDelete(),
244		$this->getNoWait(),
245		$this->getArguments(),
246		$this->getTicket(),
247		];
248		}
249
250		/**
251		* @return array
252		*/
253		public function getQueueConsume()
254		{
255		return [
256		$this->getQueue(),
257		$this->getConsumerTag(),
258		$this->getNoLocal(),
259		$this->getNoAck(),
260		$this->getExclusive(),
261		$this->getNoWait(),
262		$this->getTicket(),
263		$this->getArguments(),
264		];
265		}
266
267		/**
268		* @return array\|false
269		*/
270		public function getExchangeDeclare()
271		{
272		return false;
273		}
274
275		/**
276		* @return string
277		*/
278		public function getExchange()
279		{
280		return false;
		0 ignored issues – show Bug Best Practice introduced 2016-12-28 18:51 UTC by Report Bug Copy Issue Report The return type of `return false;` (`false`) is incompatible with the return type declared by the interface `Cmobi\RabbitmqBundle\Que...gInterface::getExchange` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
281		}
282
283		/**
284		* @return string
285		*/
286		public function getType()
287		{
288		return false;
		0 ignored issues – show Bug Best Practice introduced 2016-12-28 18:51 UTC by Report Bug Copy Issue Report The return type of `return false;` (`false`) is incompatible with the return type declared by the interface `Cmobi\RabbitmqBundle\Que...ueBagInterface::getType` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
289		}
290		}
291

contamobi / CmobiRabbitmqBundle

Pull Request — master (#1)

WorkerQueueBag A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

30 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like