SiteProcess::getTransport() - Code Metrics - Inspection of "setWorkingDirectory() controls remote execution di..." - consolidation/site-process - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( eaa33d...895a47 )

by Greg

created 2019-02-15 16:25 UTC

SiteProcess::getTransport() A

↳ Parent: SiteProcess

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php
namespace Consolidation\SiteProcess;

use Consolidation\SiteAlias\AliasRecord;
use Consolidation\SiteProcess\Transport\DockerComposeTransport;
use Consolidation\SiteProcess\Util\ArgumentProcessor;
use Consolidation\SiteProcess\Transport\LocalTransport;
use Consolidation\SiteProcess\Transport\SshTransport;
use Consolidation\SiteProcess\Transport\TransportInterface;
use Consolidation\Config\Util\Interpolator;
use Consolidation\SiteProcess\Util\ShellOperatorInterface;
use Consolidation\SiteProcess\Util\Escape;

/**
 * A wrapper around Symfony Process that uses site aliases
 * (https://github.com/consolidation/site-alias)
 *
 * - Interpolate arguments using values from the alias
 *   e.g. `$process = new SiteProcess($alias, ['git', '-C', '{{root}}']);`
 * - Make remote calls via ssh as if they were local.
 */
class SiteProcess extends ProcessBase
{
    /** @var AliasRecord */
    protected $siteAlias;
    /** @var string[] */
    protected $args;
    /** @var string[] */
    protected $options;
    /** @var string[] */
    protected $optionsPassedAsArgs;
    /** @var string */
    protected $cd_remote;
    /** @var TransportInterface */
    protected $transport;

    /**
     * Process arguments and options per the site alias and build the
     * actual command to run.
     */
    public function __construct(AliasRecord $siteAlias, TransportInterface $transport, $args, $options = [], $optionsPassedAsArgs = [])
    {
        $this->siteAlias = $siteAlias;
        $this->transport = $transport;
        $this->args = $args;
        $this->options = $options;
        $this->optionsPassedAsArgs = $optionsPassedAsArgs;

        parent::__construct([]);
    }

    /**
     * Get a starting directory for the remote process.
     *
     * @return string|null
     */
    public function getWorkingDirectory()
    {
        return $this->cd_remote;
    }

    /**
     * Set a starting directory for the remote process.
     *
     * @param string $cd_remote
     *
     * @return \Consolidation\SiteProcess\SiteProcess
     */
    public function setWorkingDirectory($cd_remote)
    {
        $this->cd_remote = $cd_remote;
        return $this;
    }

    /**
     * Set a starting directory for the initial/local process.
     *
     * @param string $cd
     *
     * @return \Consolidation\SiteProcess\SiteProcess
     */
    public function setWorkingDirectoryLocal($cd)
    {
        return parent::setWorkingDirectory($cd);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Get the starting directory for the initial/local process.
     *
     * @return string|null;

     */
    public function getWorkingDirectoryLocal()
    {
        return parent::getWorkingDirectory();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     *
     * @param bool $shouldUseSiteRoot
     * @return $this|\Symfony\Component\Process\Process
     * @throws \Exception
     */
    public function chdirToSiteRoot($shouldUseSiteRoot = true)
    {
        if (!$shouldUseSiteRoot || !$this->siteAlias->hasRoot()) {
            return $this;
        }

        return $this->setWorkingDirectory($this->siteAlias->root());
    }

    /**
     * Take all of our individual arguments and process them for use.
     */
    protected function processArgs()
    {
        $transport = $this->getTransport($this->siteAlias);
        $transport->configure($this);

        $processor = new ArgumentProcessor();
        $selectedArgs = $processor->selectArgs(
            $this->siteAlias,
            $this->args,
            $this->options,
            $this->optionsPassedAsArgs
        );

        // Ask the transport to drop in a 'cd' if needed.
        if ($this->getWorkingDirectory()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $selectedArgs = $transport->addChdir($this->getWorkingDirectory(), $selectedArgs);
        }

        // Do any necessary interpolation on the selected arguments.
        $processedArgs = $this->interpolate($selectedArgs);

        // Wrap the command with 'ssh' or some other transport if this is
        // a remote command; otherwise, leave it as-is.
        return $transport->wrap($processedArgs);
    }

    public function setTransport($transport)
    {
        $this->transport = $transport;
    }

    /**
     * Ask the transport manager for the correct transport for the
     * provided alias.
     */
    protected function getTransport(AliasRecord $siteAlias)

    {
        return $this->transport;
    }

    /**
     * @inheritDoc
     */
    public function getCommandLine()
    {
        $commandLine = parent::getCommandLine();
        if (empty($commandLine)) {
            $processedArgs = $this->processArgs();
            $commandLine = Escape::argsForSite($this->siteAlias, $processedArgs);
            $commandLine = implode(' ', $commandLine);
            $this->setCommandLine($commandLine);
        }
        return $commandLine;
    }

    /**
     * @inheritDoc
     */
    public function start(callable $callback = null, $env = array())
    {
        $cmd = $this->getCommandLine();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        parent::start($callback, $env);
    }

    /**
     * @inheritDoc
     */
    public function wait(callable $callback = null)
    {
        $return = parent::wait($callback);
        return $return;
    }

    /**
     * interpolate examines each of the arguments in the provided argument list
     * and replaces any token found therein with the value for that key as
     * pulled from the given site alias.
     *
     * Example: "git -C {{root}} status"
     *
     * The token "{{root}}" will be converted to a value via $siteAlias->get('root').
     * The result will replace the token.
     *
     * It is possible to use dot notation in the keys to access nested elements
     * within the site alias record.
     *
     * @param AliasRecord $siteAlias
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param type $args
     * @return type
     */
    protected function interpolate($args)
    {
        $interpolator = new Interpolator();
        return array_map(
            function ($arg) use ($interpolator) {
                if ($arg instanceof ShellOperatorInterface) {
                    return $arg;
                }
                return $interpolator->interpolate($this->siteAlias, $arg, false);
            },
            $args
        );
    }
}


1			<?php
2			namespace Consolidation\SiteProcess;
3
4			use Consolidation\SiteAlias\AliasRecord;
5			use Consolidation\SiteProcess\Transport\DockerComposeTransport;
6			use Consolidation\SiteProcess\Util\ArgumentProcessor;
7			use Consolidation\SiteProcess\Transport\LocalTransport;
8			use Consolidation\SiteProcess\Transport\SshTransport;
9			use Consolidation\SiteProcess\Transport\TransportInterface;
10			use Consolidation\Config\Util\Interpolator;
11			use Consolidation\SiteProcess\Util\ShellOperatorInterface;
12			use Consolidation\SiteProcess\Util\Escape;
13
14			/**
15			* A wrapper around Symfony Process that uses site aliases
16			* (https://github.com/consolidation/site-alias)
17			*
18			* - Interpolate arguments using values from the alias
19			* e.g. `$process = new SiteProcess($alias, ['git', '-C', '{{root}}']);`
20			* - Make remote calls via ssh as if they were local.
21			*/
22			class SiteProcess extends ProcessBase
23			{
24			/** @var AliasRecord */
25			protected $siteAlias;
26			/** @var string[] */
27			protected $args;
28			/** @var string[] */
29			protected $options;
30			/** @var string[] */
31			protected $optionsPassedAsArgs;
32			/** @var string */
33			protected $cd_remote;
34			/** @var TransportInterface */
35			protected $transport;
36
37			/**
38			* Process arguments and options per the site alias and build the
39			* actual command to run.
40			*/
41			public function __construct(AliasRecord $siteAlias, TransportInterface $transport, $args, $options = [], $optionsPassedAsArgs = [])
42			{
43			$this->siteAlias = $siteAlias;
44			$this->transport = $transport;
45			$this->args = $args;
46			$this->options = $options;
47			$this->optionsPassedAsArgs = $optionsPassedAsArgs;
48
49			parent::__construct([]);
50			}
51
52			/**
53			* Get a starting directory for the remote process.
54			*
55			* @return string\|null
56			*/
57			public function getWorkingDirectory()
58			{
59			return $this->cd_remote;
60			}
61
62			/**
63			* Set a starting directory for the remote process.
64			*
65			* @param string $cd_remote
66			*
67			* @return \Consolidation\SiteProcess\SiteProcess
68			*/
69			public function setWorkingDirectory($cd_remote)
70			{
71			$this->cd_remote = $cd_remote;
72			return $this;
73			}
74
75			/**
76			* Set a starting directory for the initial/local process.
77			*
78			* @param string $cd
79			*
80			* @return \Consolidation\SiteProcess\SiteProcess
81			*/
82			public function setWorkingDirectoryLocal($cd)
83			{
84			return parent::setWorkingDirectory($cd);
			0 ignored issues – show Comprehensibility Bug introduced 2019-02-15 12:34 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`setWorkingDirectory()` instead of `setWorkingDirectoryLocal()`). Are you sure this is correct? If so, you might want to change this to `$this->setWorkingDirectory()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
85			}
86
87			/**
88			* Get the starting directory for the initial/local process.
89			*
90			* @return string\|null;
			0 ignored issues – show Documentation introduced 2019-02-15 12:34 UTC by Report Bug Copy Issue Report The doc-type `string\|null;` could not be parsed: Expected "\|" or "end of type", but got ";" at position 11. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
91			*/
92			public function getWorkingDirectoryLocal()
93			{
94			return parent::getWorkingDirectory();
			0 ignored issues – show Comprehensibility Bug introduced 2019-02-15 12:34 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getWorkingDirectory()` instead of `getWorkingDirectoryLocal()`). Are you sure this is correct? If so, you might want to change this to `$this->getWorkingDirectory()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
95			}
96
97			/**
98			*
99			* @param bool $shouldUseSiteRoot
100			* @return $this\|\Symfony\Component\Process\Process
101			* @throws \Exception
102			*/
103			public function chdirToSiteRoot($shouldUseSiteRoot = true)
104			{
105			if (!$shouldUseSiteRoot \|\| !$this->siteAlias->hasRoot()) {
106			return $this;
107			}
108
109			return $this->setWorkingDirectory($this->siteAlias->root());
110			}
111
112			/**
113			* Take all of our individual arguments and process them for use.
114			*/
115			protected function processArgs()
116			{
117			$transport = $this->getTransport($this->siteAlias);
118			$transport->configure($this);
119
120			$processor = new ArgumentProcessor();
121			$selectedArgs = $processor->selectArgs(
122			$this->siteAlias,
123			$this->args,
124			$this->options,
125			$this->optionsPassedAsArgs
126			);
127
128			// Ask the transport to drop in a 'cd' if needed.
129			if ($this->getWorkingDirectory()) {
			0 ignored issues – show Bug Best Practice introduced 2019-02-15 12:34 UTC by Report Bug Copy Issue Report The expression `$this->getWorkingDirectory()` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
130			$selectedArgs = $transport->addChdir($this->getWorkingDirectory(), $selectedArgs);
131			}
132
133			// Do any necessary interpolation on the selected arguments.
134			$processedArgs = $this->interpolate($selectedArgs);
135
136			// Wrap the command with 'ssh' or some other transport if this is
137			// a remote command; otherwise, leave it as-is.
138			return $transport->wrap($processedArgs);
139			}
140
141			public function setTransport($transport)
142			{
143			$this->transport = $transport;
144			}
145
146			/**
147			* Ask the transport manager for the correct transport for the
148			* provided alias.
149			*/
150			protected function getTransport(AliasRecord $siteAlias)
			0 ignored issues – show Unused Code introduced 2019-01-04 02:11 UTC by Report Bug Copy Issue Report The parameter `$siteAlias` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
151			{
152			return $this->transport;
153			}
154
155			/**
156			* @inheritDoc
157			*/
158			public function getCommandLine()
159			{
160			$commandLine = parent::getCommandLine();
161			if (empty($commandLine)) {
162			$processedArgs = $this->processArgs();
163			$commandLine = Escape::argsForSite($this->siteAlias, $processedArgs);
164			$commandLine = implode(' ', $commandLine);
165			$this->setCommandLine($commandLine);
166			}
167			return $commandLine;
168			}
169
170			/**
171			* @inheritDoc
172			*/
173			public function start(callable $callback = null, $env = array())
174			{
175			$cmd = $this->getCommandLine();
			0 ignored issues – show Unused Code introduced 2018-10-27 17:58 UTC by Report Bug Copy Issue Report `$cmd` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
176			parent::start($callback, $env);
177			}
178
179			/**
180			* @inheritDoc
181			*/
182			public function wait(callable $callback = null)
183			{
184			$return = parent::wait($callback);
185			return $return;
186			}
187
188			/**
189			* interpolate examines each of the arguments in the provided argument list
190			* and replaces any token found therein with the value for that key as
191			* pulled from the given site alias.
192			*
193			* Example: "git -C {{root}} status"
194			*
195			* The token "{{root}}" will be converted to a value via $siteAlias->get('root').
196			* The result will replace the token.
197			*
198			* It is possible to use dot notation in the keys to access nested elements
199			* within the site alias record.
200			*
201			* @param AliasRecord $siteAlias
			0 ignored issues – show Bug introduced 2018-10-28 01:00 UTC by Report Bug Copy Issue Report There is no parameter named `$siteAlias`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
202			* @param type $args
203			* @return type
204			*/
205			protected function interpolate($args)
206			{
207			$interpolator = new Interpolator();
208			return array_map(
209			function ($arg) use ($interpolator) {
210			if ($arg instanceof ShellOperatorInterface) {
211			return $arg;
212			}
213			return $interpolator->interpolate($this->siteAlias, $arg, false);
214			},
215			$args
216			);
217			}
218			}
219

consolidation / site-process

Push — master ( eaa33d...895a47 )

SiteProcess::getTransport() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like