Completed
Pull Request — master (#25)
by Moshe
01:21
created
src/Util/ArgumentProcessor.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 namespace Consolidation\SiteProcess\Util;
3 3
 
4 4
 use Consolidation\SiteAlias\AliasRecord;
5
-use Symfony\Component\Process\Process;
6
-use Consolidation\SiteProcess\Transport\TransportInterface;
7 5
 
8 6
 /**
9 7
  * ArgumentProcessor takes a set of arguments and options from the caller
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -18,10 +18,10 @@
 block discarded – undo
18 18
      * to be executed and orders them as needed.
19 19
      *
20 20
      * @param AliasRecord $siteAlias Description of
21
-     * @param array $args Command and arguments to execute (source)
22
-     * @param array $options key / value pair of option and value in include
21
+     * @param string[] $args Command and arguments to execute (source)
22
+     * @param string[] $options key / value pair of option and value in include
23 23
      *   in final arguments
24
-     * @param array $optionsPassedAsArgs key / value pair of option and value
24
+     * @param string[] $optionsPassedAsArgs key / value pair of option and value
25 25
      *   to include in final arguments after the '--' argument.
26 26
      * @return array Command and arguments to execute
27 27
      */
Please login to merge, or discard this patch.
src/Remo/RemoCommands.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,8 +3,6 @@
 block discarded – undo
3 3
 namespace Consolidation\SiteProcess\Remo;
4 4
 
5 5
 use Consolidation\SiteProcess\SiteProcess;
6
-
7
-use Consolidation\SiteAlias\SiteAliasManagerAwareInterface;
8 6
 use Consolidation\SiteAlias\SiteAliasManagerAwareTrait;
9 7
 use Consolidation\SiteAlias\SiteAliasManager;
10 8
 
Please login to merge, or discard this patch.
src/Util/RealtimeOutputHandler.php 2 patches
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -109,6 +109,8 @@
 block discarded – undo
109 109
 
110 110
     /**
111 111
      * Make sure that every line in $buffer begins with a MARKER_ERR.
112
+     * @param string $buffer
113
+     * @param string $marker
112 114
      */
113 115
     protected function addMarker($buffer, $marker)
114 116
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -1,9 +1,7 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace Consolidation\SiteProcess\Util;
3 3
 
4
-use Consolidation\SiteAlias\AliasRecord;
5 4
 use Symfony\Component\Process\Process;
6
-use Consolidation\Config\Util\Interpolator;
7 5
 use Symfony\Component\Console\Output\OutputInterface;
8 6
 use Symfony\Component\Console\Output\NullOutput;
9 7
 
Please login to merge, or discard this patch.
src/Transport/DockerComposeTransport.php 1 patch
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -2,12 +2,7 @@
 block discarded – undo
2 2
 
3 3
 namespace Consolidation\SiteProcess\Transport;
4 4
 
5
-use Psr\Log\LoggerInterface;
6
-use Symfony\Component\Console\Style\OutputStyle;
7 5
 use Symfony\Component\Process\Process;
8
-use Consolidation\SiteProcess\Util\RealtimeOutputHandler;
9
-use Consolidation\SiteProcess\Util\Escape;
10
-use Symfony\Component\Console\Output\ConsoleOutputInterface;
11 6
 use Consolidation\SiteAlias\AliasRecord;
12 7
 use Consolidation\SiteProcess\Util\Shell;
13 8
 
Please login to merge, or discard this patch.
src/SiteProcess.php 2 patches
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -2,10 +2,7 @@
 block discarded – undo
2 2
 namespace Consolidation\SiteProcess;
3 3
 
4 4
 use Consolidation\SiteAlias\AliasRecord;
5
-use Consolidation\SiteProcess\Transport\DockerComposeTransport;
6 5
 use Consolidation\SiteProcess\Util\ArgumentProcessor;
7
-use Consolidation\SiteProcess\Transport\LocalTransport;
8
-use Consolidation\SiteProcess\Transport\SshTransport;
9 6
 use Consolidation\SiteProcess\Transport\TransportInterface;
10 7
 use Consolidation\Config\Util\Interpolator;
11 8
 use Consolidation\SiteProcess\Util\ShellOperatorInterface;
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
     }
59 59
 
60 60
     /**
61
-     * @param string $cwd
61
+     * @param string $cd
62 62
      */
63 63
     public function setCd($cd)
64 64
     {
@@ -170,7 +170,6 @@  discard block
 block discarded – undo
170 170
      * It is possible to use dot notation in the keys to access nested elements
171 171
      * within the site alias record.
172 172
      *
173
-     * @param AliasRecord $siteAlias
174 173
      * @param type $args
175 174
      * @return type
176 175
      */
Please login to merge, or discard this patch.
src/ProcessBase.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
      * @param string|null $cwd     The working directory or null to use the working dir of the current PHP process
45 45
      * @param array|null $env     The environment variables or null to use the same environment as the current PHP process
46 46
      * @param mixed|null $input   The input as stream resource, scalar or \Traversable, or null for no input
47
-     * @param int|float|null $timeout The timeout in seconds or null to disable
47
+     * @param integer $timeout The timeout in seconds or null to disable
48 48
      * @return Process
49 49
      */
50 50
     public static function fromShellCommandline($command, $cwd = null, array $env = null, $input = null, $timeout = 60)
@@ -66,6 +66,9 @@  discard block
 block discarded – undo
66 66
         return $this->output;
67 67
     }
68 68
 
69
+    /**
70
+     * @return OutputInterface
71
+     */
69 72
     protected function realtimeStderr()
70 73
     {
71 74
         if ($this->stderr) {
@@ -181,7 +184,7 @@  discard block
 block discarded – undo
181 184
     /**
182 185
      * Return a realTime output object.
183 186
      *
184
-     * @return callable
187
+     * @return RealtimeOutputHandler
185 188
      */
186 189
     public function showRealtime()
187 190
     {
Please login to merge, or discard this patch.
src/Transport/TransportInterface.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,6 +16,7 @@  discard block
 block discarded – undo
16 16
     /**
17 17
      * Configure ourselves based on the settings of the process object
18 18
      * (e.g. isTty()).
19
+     * @return void
19 20
      */
20 21
     public function configure(Process $process);
21 22
 
@@ -25,7 +26,6 @@  discard block
 block discarded – undo
25 26
      * alias points at a remote system, though, then the arguments are
26 27
      * escaped and wrapped in an appropriate ssh command.
27 28
      *
28
-     * @param AliasRecord $siteAlias alias record of target site.
29 29
      * @param array $args arguments provided by caller.
30 30
      * @return array command and arguments to execute.
31 31
      */
@@ -33,6 +33,8 @@  discard block
 block discarded – undo
33 33
 
34 34
     /**
35 35
      * addChdir adds an appropriate 'chdir' / 'cd' command for the transport.
36
+     * @param string $cd
37
+     * @param \Consolidation\SiteProcess\SiteProcess $process
36 38
      */
37 39
     public function addChdir($cd, $args, $process);
38 40
 }
Please login to merge, or discard this patch.