Issues in SiteAliasTrait.php (master) - Issues in master - consolidation/site-alias - Measure and Improve Code Quality continuously with Scrutinizer

Issues (50)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/SiteAliasTrait.php (11 issues)

Labels

Bug 11

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Consolidation\SiteAlias;

use Consolidation\Config\Config;
use Consolidation\Config\ConfigInterface;
use Consolidation\Config\Util\ArrayUtil;
use Consolidation\SiteAlias\Util\FsUtils;

/**
 * Common implementation of some SiteAlias methods.
 */
trait SiteAliasTrait
{
    /**
     * @inheritdoc
     */
    public function hasRoot()
    {
        return $this->has('root');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @inheritdoc
     *
     * @throws \Exception when the alias does not specify a root.
     */
    public function root()
    {
        if (!$this->hasRoot()) {
            throw new \Exception('Site alias ' . $this->name . ' does not specify a root.');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
        $root = $this->get('root');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        if ($this->isLocal()) {
            return FsUtils::realpath($root);
        }
        return $root;
    }

    /**
     * @inheritdoc
     */
    public function uri()
    {
        return $this->get('uri');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @inheritdoc
     */
    public function setUri($uri)
    {
        return $this->set('uri', $uri);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @inheritdoc
     */
    public function remoteHostWithUser()
    {
        $result = $this->remoteHost();
        if (!empty($result) && $this->hasRemoteUser()) {
            $result = $this->remoteUser() . '@' . $result;
        }
        return $result;
    }

    /**
     * @inheritdoc
     */
    public function remoteUser()
    {
        return $this->get('user');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @inheritdoc
     */
    public function hasRemoteUser()
    {
        return $this->has('user');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @inheritdoc
     */
    public function remoteHost()
    {
        return $this->get('host');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @inheritdoc
     */
    public function isRemote()
    {
        return $this->has('host');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @inheritdoc
     */
    public function isLocal()
    {
        return !$this->isRemote() && !$this->isContainer();
    }

    /**
     * @inheritdoc
     */
    public function isContainer()
    {
        return $this->has('docker');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @inheritdoc
     */
    public function isNone()
    {
        return empty($this->root()) && $this->isLocal();
    }

    /**
     * @inheritdoc
     */
    public function localRoot()
    {
        if ($this->isLocal() && $this->hasRoot()) {
            return $this->root();
        }

        return false;
    }

    /**
     * os returns the OS that this alias record points to. For local alias
     * records, PHP_OS will be returned. For remote alias records, the
     * value from the `os` element will be returned. If there is no `os`
     * element, then the default assumption is that the remote system is Linux.
     *
     * @return string
     *   Linux
     *   WIN* (e.g. WINNT)
     *   CYGWIN
     *   MINGW* (e.g. MINGW32)
     */
    public function os()
    {
        if ($this->isLocal()) {
            return PHP_OS;
        }
        return $this->get('os', 'Linux');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2			namespace Consolidation\SiteAlias;
3
4			use Consolidation\Config\Config;
5			use Consolidation\Config\ConfigInterface;
6			use Consolidation\Config\Util\ArrayUtil;
7			use Consolidation\SiteAlias\Util\FsUtils;
8
9			/**
10			* Common implementation of some SiteAlias methods.
11			*/
12			trait SiteAliasTrait
13			{
14			/**
15			* @inheritdoc
16			*/
17			public function hasRoot()
18			{
19			return $this->has('root');
			0 ignored issues – show Bug introduced 2019-03-02 02:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `has()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20			}
21
22			/**
23			* @inheritdoc
24			*
25			* @throws \Exception when the alias does not specify a root.
26			*/
27			public function root()
28			{
29			if (!$this->hasRoot()) {
30			throw new \Exception('Site alias ' . $this->name . ' does not specify a root.');
			0 ignored issues – show Bug introduced 2019-03-02 02:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `name` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
31			}
32			$root = $this->get('root');
			0 ignored issues – show Bug introduced 2019-03-02 02:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
33			if ($this->isLocal()) {
34			return FsUtils::realpath($root);
35			}
36			return $root;
37			}
38
39			/**
40			* @inheritdoc
41			*/
42			public function uri()
43			{
44			return $this->get('uri');
			0 ignored issues – show Bug introduced 2019-03-02 02:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
45			}
46
47			/**
48			* @inheritdoc
49			*/
50			public function setUri($uri)
51			{
52			return $this->set('uri', $uri);
			0 ignored issues – show Bug introduced 2019-03-02 02:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `set()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
53			}
54
55			/**
56			* @inheritdoc
57			*/
58			public function remoteHostWithUser()
59			{
60			$result = $this->remoteHost();
61			if (!empty($result) && $this->hasRemoteUser()) {
62			$result = $this->remoteUser() . '@' . $result;
63			}
64			return $result;
65			}
66
67			/**
68			* @inheritdoc
69			*/
70			public function remoteUser()
71			{
72			return $this->get('user');
			0 ignored issues – show Bug introduced 2019-03-02 02:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
73			}
74
75			/**
76			* @inheritdoc
77			*/
78			public function hasRemoteUser()
79			{
80			return $this->has('user');
			0 ignored issues – show Bug introduced 2019-03-02 02:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `has()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
81			}
82
83			/**
84			* @inheritdoc
85			*/
86			public function remoteHost()
87			{
88			return $this->get('host');
			0 ignored issues – show Bug introduced 2019-03-02 02:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
89			}
90
91			/**
92			* @inheritdoc
93			*/
94			public function isRemote()
95			{
96			return $this->has('host');
			0 ignored issues – show Bug introduced 2019-03-02 02:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `has()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
97			}
98
99			/**
100			* @inheritdoc
101			*/
102			public function isLocal()
103			{
104			return !$this->isRemote() && !$this->isContainer();
105			}
106
107			/**
108			* @inheritdoc
109			*/
110			public function isContainer()
111			{
112			return $this->has('docker');
			0 ignored issues – show Bug introduced 2019-03-02 02:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `has()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
113			}
114
115			/**
116			* @inheritdoc
117			*/
118			public function isNone()
119			{
120			return empty($this->root()) && $this->isLocal();
121			}
122
123			/**
124			* @inheritdoc
125			*/
126			public function localRoot()
127			{
128			if ($this->isLocal() && $this->hasRoot()) {
129			return $this->root();
130			}
131
132			return false;
133			}
134
135			/**
136			* os returns the OS that this alias record points to. For local alias
137			* records, PHP_OS will be returned. For remote alias records, the
138			* value from the `os` element will be returned. If there is no `os`
139			* element, then the default assumption is that the remote system is Linux.
140			*
141			* @return string
142			* Linux
143			* WIN* (e.g. WINNT)
144			* CYGWIN
145			* MINGW* (e.g. MINGW32)
146			*/
147			public function os()
148			{
149			if ($this->isLocal()) {
150			return PHP_OS;
151			}
152			return $this->get('os', 'Linux');
			0 ignored issues – show Bug introduced 2019-03-02 02:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
153			}
154			}
155

consolidation / site-alias

Issues (50)

Security Analysis no request data

src/SiteAliasTrait.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like