ExecTaskTest::testExecStackCommandInterface() - Code Metrics - Inspection of "Allow CommandStack to exec other tasks." - consolidation/robo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#726)

unknown

created 2018-04-26 01:17 UTC

ExecTaskTest::testExecStackCommandInterface() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	8
rs	9.4285
cc	1
eloc	6
nc	1
nop	0

<?php

use AspectMock\Test as test;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

class ExecTaskTest extends \Codeception\TestCase\Test
namespace YourVendor;

class YourClass { }
{
    /**
     * @var \AspectMock\Proxy\ClassProxy
     */
    protected $process;

    protected function _before()

    {
        $this->process = test::double('Symfony\Component\Process\Process', [
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
            'run' => false,
            'start' => false,
            'getOutput' => 'Hello world',
            'getExitCode' => 0,
            'logger' => new \Psr\Log\NullLogger(),
        ]);
        test::double('Robo\Task\Base\Exec', ['output' => new \Symfony\Component\Console\Output\NullOutput()]);
    }

    public function testExec()

    {
        $task = new \Robo\Task\Base\Exec('ls');
        $task->setLogger(new \Psr\Log\NullLogger());

        $result = $task->run();
        $this->process->verifyInvoked('run');
        verify($result->getMessage())->equals('Hello world');
        verify($result->getExitCode())->equals(0);
    }

    public function testExecInBackground()

    {
        $task = new \Robo\Task\Base\Exec('ls');
        $task->setLogger(new \Psr\Log\NullLogger());

        $result = $task->background()->run();
        $this->process->verifyInvoked('start');
        $this->process->verifyNeverInvoked('run');
        verify('exit code was not received', $result->getExitCode())->notEquals(100);
    }

    public function testGetCommand()
    {
        verify((new \Robo\Task\Base\Exec('ls'))->getCommand())->equals('ls');
    }

    public function testExecStack()
    {
        $task = new \Robo\Task\Base\ExecStack();
        $task->setLogger(new \Psr\Log\NullLogger());

        $task
            ->exec('ls')
            ->exec('cd /')
            ->exec('cd home')
            ->run();
        $this->process->verifyInvoked('run', 3);
    }

    public function testExecStackCommand()
    {
        verify((new \Robo\Task\Base\ExecStack())
            ->exec('ls')
            ->exec('cd /')
            ->exec('cd home')
            ->getCommand()
        )->equals('ls && cd / && cd home');
    }

    public function testExecStackCommandInterface()
    {
        verify((new \Robo\Task\Base\ExecStack())
            ->exec('ls')
            ->exec((new \Robo\Task\Vcs\GitStack('git'))->add('-A')->pull())
            ->getCommand()
        )->equals('ls && git add -A && git pull');
    }
};


1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2017-04-19 01:04 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 4 and the first side effect is on line 81. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2		use AspectMock\Test as test;
		0 ignored issues – show Bug introduced 2017-04-19 01:04 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `test`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
3
4		class ExecTaskTest extends \Codeception\TestCase\Test
		0 ignored issues – show Coding Style Compatibility introduced 2016-09-13 23:47 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
5		{
6		/**
7		* @var \AspectMock\Proxy\ClassProxy
8		*/
9		protected $process;
10
11	View Code Duplication	protected function _before()
		0 ignored issues – show Duplication introduced 2017-08-02 21:58 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
12		{
13		$this->process = test::double('Symfony\Component\Process\Process', [
		0 ignored issues – show Documentation Bug introduced 2016-09-13 23:47 UTC by Report Bug Copy Issue Report It seems like `\AspectMock\Test::double...\Psr\Log\NullLogger()))` can also be of type `object<AspectMock\Proxy\InstanceProxy>`. However, the property `$process` is declared as type `object<AspectMock\Proxy\ClassProxy>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
14		'run' => false,
15		'start' => false,
16		'getOutput' => 'Hello world',
17		'getExitCode' => 0,
18		'logger' => new \Psr\Log\NullLogger(),
19		]);
20		test::double('Robo\Task\Base\Exec', ['output' => new \Symfony\Component\Console\Output\NullOutput()]);
21		}
22
23	View Code Duplication	public function testExec()
		0 ignored issues – show Duplication introduced 2016-09-13 23:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
24		{
25		$task = new \Robo\Task\Base\Exec('ls');
26		$task->setLogger(new \Psr\Log\NullLogger());
27
28		$result = $task->run();
29		$this->process->verifyInvoked('run');
30		verify($result->getMessage())->equals('Hello world');
31		verify($result->getExitCode())->equals(0);
32		}
33
34	View Code Duplication	public function testExecInBackground()
		0 ignored issues – show Duplication introduced 2016-09-13 23:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		{
36		$task = new \Robo\Task\Base\Exec('ls');
37		$task->setLogger(new \Psr\Log\NullLogger());
38
39		$result = $task->background()->run();
40		$this->process->verifyInvoked('start');
41		$this->process->verifyNeverInvoked('run');
42		verify('exit code was not received', $result->getExitCode())->notEquals(100);
43		}
44
45		public function testGetCommand()
46		{
47		verify((new \Robo\Task\Base\Exec('ls'))->getCommand())->equals('ls');
48		}
49
50		public function testExecStack()
51		{
52		$task = new \Robo\Task\Base\ExecStack();
53		$task->setLogger(new \Psr\Log\NullLogger());
54
55		$task
56		->exec('ls')
57		->exec('cd /')
58		->exec('cd home')
59		->run();
60		$this->process->verifyInvoked('run', 3);
61		}
62
63		public function testExecStackCommand()
64		{
65		verify((new \Robo\Task\Base\ExecStack())
66		->exec('ls')
67		->exec('cd /')
68		->exec('cd home')
69		->getCommand()
70		)->equals('ls && cd / && cd home');
71		}
72
73		public function testExecStackCommandInterface()
74		{
75		verify((new \Robo\Task\Base\ExecStack())
76		->exec('ls')
77		->exec((new \Robo\Task\Vcs\GitStack('git'))->add('-A')->pull())
78		->getCommand()
79		)->equals('ls && git add -A && git pull');
80		}
81		};
82

consolidation / robo

Pull Request — master (#726)

ExecTaskTest::testExecStackCommandInterface() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like