Completed
Pull Request — master (#924)
by Greg
02:26
created
src/Common/ResourceExistenceChecker.php 2 patches
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -90,25 +90,25 @@
 block discarded – undo
90 90
         $this->checkResources($targets);
91 91
     }
92 92
 
93
-   /**
94
-    * Wrapper method around phps is_dir()
95
-    *
96
-    * @param string $directory
97
-    *
98
-    * @return bool
99
-    */
93
+    /**
94
+     * Wrapper method around phps is_dir()
95
+     *
96
+     * @param string $directory
97
+     *
98
+     * @return bool
99
+     */
100 100
     protected function isDir($directory)
101 101
     {
102 102
         return is_dir($directory);
103 103
     }
104 104
 
105
-   /**
106
-    * Wrapper method around phps file_exists()
107
-    *
108
-    * @param string $file
109
-    *
110
-    * @return bool
111
-    */
105
+    /**
106
+     * Wrapper method around phps file_exists()
107
+     *
108
+     * @param string $file
109
+     *
110
+     * @return bool
111
+     */
112 112
     protected function isFile($file)
113 113
     {
114 114
         return file_exists($file);
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
      * @param string $type
49 49
      *   Allowed values: "file", "dir", "fileAndDir".
50 50
      *
51
-     * @return bool
51
+     * @return boolean|null
52 52
      */
53 53
     protected function checkResource($resource, $type)
54 54
     {
Please login to merge, or discard this patch.
src/Task/Remote/Rsync.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -353,7 +353,7 @@
 block discarded – undo
353 353
     }
354 354
 
355 355
     /**
356
-     * @param array|string $pattern
356
+     * @param string[] $pattern
357 357
      *
358 358
      * @return $this
359 359
      */
Please login to merge, or discard this patch.
tests/unit/Task/HgTest.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -1,7 +1,5 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-use AspectMock\Test as test;
4
-
5 3
 class HgTest extends \Codeception\TestCase\Test
6 4
 {
7 5
     /**
Please login to merge, or discard this patch.
src/Common/ExecCommand.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
      *
152 152
      * @param string $cmd
153 153
      *
154
-     * @return bool|string
154
+     * @return string|false
155 155
      */
156 156
     protected function findExecutable($cmd)
157 157
     {
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
     }
181 181
 
182 182
     /**
183
-     * @return bool|string
183
+     * @return string|false
184 184
      */
185 185
     protected function findProjectBin()
186 186
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@
 block discarded – undo
89 89
     protected function findProjectBin()
90 90
     {
91 91
         $cwd = getcwd();
92
-        $candidates = [ __DIR__ . '/../../vendor/bin', __DIR__ . '/../../bin', $cwd . '/vendor/bin' ];
92
+        $candidates = [__DIR__ . '/../../vendor/bin', __DIR__ . '/../../bin', $cwd . '/vendor/bin'];
93 93
 
94 94
         // If this project is inside a vendor directory, give highest priority
95 95
         // to that directory.
Please login to merge, or discard this patch.
tests/unit/Common/CommandArgumentsTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
      *
80 80
      * @covers ::args
81 81
      *
82
-     * @param string $expected
82
+     * @param string $expectedLinux
83 83
      * @param array $args
84 84
      */
85 85
     public function testArgs($expectedLinux, $expectedWindows, $args)
Please login to merge, or discard this patch.
src/Task/Base/Exec.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
     protected $command;
44 44
 
45 45
     /**
46
-     * @param string|\Robo\Contract\CommandInterface $command
46
+     * @param string $command
47 47
      */
48 48
     public function __construct($command)
49 49
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Robo\Task\Base;
4 4
 
5
-use Robo\Common\ExecTrait;
6 5
 use Robo\Contract\CommandInterface;
7 6
 use Robo\Contract\PrintedInterface;
8 7
 use Robo\Contract\SimulatedInterface;
Please login to merge, or discard this patch.
src/Task/Testing/Codecept.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use Robo\Exception\TaskException;
6 6
 use Robo\Task\BaseTask;
7 7
 use Robo\Contract\CommandInterface;
8
-use Symfony\Component\Process\Process;
9 8
 
10 9
 /**
11 10
  * Executes Codeception tests
Please login to merge, or discard this patch.
src/Task/Testing/Atoum.php 2 patches
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -83,7 +83,6 @@
 block discarded – undo
83 83
 
84 84
     /**
85 85
      * Path to the bootstrap file.
86
-
87 86
      * @param string $file
88 87
      *
89 88
      * @return $this
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
     /**
49 49
      * Tag or Tags to filter.
50 50
      *
51
-     * @param string|string[] $tags
51
+     * @param string $tags
52 52
      *
53 53
      * @return $this
54 54
      */
@@ -125,6 +125,7 @@  discard block
 block discarded – undo
125 125
      * Test file or test files to run.
126 126
      *
127 127
      * @param string|string[]
128
+     * @param string[] $files
128 129
      *
129 130
      * @return $this
130 131
      */
@@ -138,6 +139,7 @@  discard block
 block discarded – undo
138 139
      *
139 140
      * @param string|string[]
140 141
      *   A single directory or a list of directories.
142
+     * @param string $directories
141 143
      *
142 144
      * @return $this
143 145
      */
Please login to merge, or discard this patch.
src/Task/Development/OpenBrowser.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
      */
36 36
     public function __construct($url)
37 37
     {
38
-        $this->urls = (array) $url;
38
+        $this->urls = (array)$url;
39 39
     }
40 40
 
41 41
     /**
Please login to merge, or discard this patch.