ProcessExecutor::create() - Code Metrics - Inspection of "Add factory methods for CollectionBuilder and Proc..." - consolidation/robo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#546)

by Greg

created 2017-03-18 18:50 UTC

ProcessExecutor::create() A

↳ Parent: ProcessExecutor

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	11
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	11
loc	11
rs	9.4285
cc	1
eloc	7
nc	1
nop	2

<?php

namespace Robo\Common;

use Psr\Log\LoggerAwareInterface;
use Robo\Contract\ConfigAwareInterface;
use Robo\Contract\OutputAwareInterface;
use Robo\Contract\VerbosityThresholdInterface;
use Symfony\Component\Process\Process;

class ProcessExecutor implements ConfigAwareInterface, LoggerAwareInterface, OutputAwareInterface, VerbosityThresholdInterface
{
    use ExecTrait;
    use TaskIO; // uses LoggerAwareTrait and ConfigAwareTrait
    use ProgressIndicatorAwareTrait;
    use OutputAwareTrait;

    /**
     * @param Process $process
     * @return type

     */
    public function __construct(Process $process)
    {
        $this->process = $process;
    }

    public static function create($container, $process)

    {
        $processExecutor = new self($process);

        $processExecutor->setLogger($container->get('logger'));
        $processExecutor->setProgressIndicator($container->get('progressIndicator'));
        $processExecutor->setConfig($container->get('config'));
        $processExecutor->setOutputAdapter($container->get('outputAdapter'));

        return $processExecutor;
    }

    /**
     * @return string
     */
    protected function getCommandDescription()
    {
        return $this->process->getCommandLine();
    }

    public function run()
    {
        return $this->execute($this->process);
    }
}


1		<?php
2
3		namespace Robo\Common;
4
5		use Psr\Log\LoggerAwareInterface;
6		use Robo\Contract\ConfigAwareInterface;
7		use Robo\Contract\OutputAwareInterface;
8		use Robo\Contract\VerbosityThresholdInterface;
9		use Symfony\Component\Process\Process;
10
11		class ProcessExecutor implements ConfigAwareInterface, LoggerAwareInterface, OutputAwareInterface, VerbosityThresholdInterface
12		{
13		use ExecTrait;
14		use TaskIO; // uses LoggerAwareTrait and ConfigAwareTrait
15		use ProgressIndicatorAwareTrait;
16		use OutputAwareTrait;
17
18		/**
19		* @param Process $process
20		* @return type
		0 ignored issues – show Comprehensibility Best Practice introduced 2017-03-18 17:00 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
21		*/
22		public function __construct(Process $process)
23		{
24		$this->process = $process;
25		}
26
27	View Code Duplication	public static function create($container, $process)
		0 ignored issues – show Duplication introduced 2017-03-18 17:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		{
29		$processExecutor = new self($process);
30
31		$processExecutor->setLogger($container->get('logger'));
32		$processExecutor->setProgressIndicator($container->get('progressIndicator'));
33		$processExecutor->setConfig($container->get('config'));
34		$processExecutor->setOutputAdapter($container->get('outputAdapter'));
35
36		return $processExecutor;
37		}
38
39		/**
40		* @return string
41		*/
42		protected function getCommandDescription()
43		{
44		return $this->process->getCommandLine();
45		}
46
47		public function run()
48		{
49		return $this->execute($this->process);
50		}
51		}
52

consolidation / robo

Pull Request — master (#546)

ProcessExecutor::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like