consolidation / robo

src/Task/Docker/Run.php

Doc Comments +2 added lines, -2 removed lines

@@ -126,7 +126,7 @@ 
     }
 
     /**
-     * @param string|\Robo\Contract\CommandInterface $run
+     * @param string $run
      *
      * @return $this
      */
@@ -155,7 +155,7 @@ 
      * inherited from ExecTrait.
      *
      * @param array $env
-     * @return type
+     * @return Run
      */
     public function envVars(array $env)
     {

tests/_helpers/SeeInOutputTrait.php

Doc Comments +4 added lines

@@ -11,6 +11,9 @@ 
     protected $capturedOutput;
     protected $logger;
 
+    /**
+     * @param \League\Container\Container $container
+     */
     public function initSeeInOutputTrait($container, $input = null)
     {
         $this->capturedOutput = '';
@@ -65,6 +68,7 @@ 
     /**
      * Make our output comparisons more platform-agnostic by converting
      * CRLF (Windows) or raw CR (confused output) to a LF (unix/Mac).
+     * @param string $output
      */
     protected function simplify($output)
     {

tests/unit/Common/ResultDataTest.php

Spacing +2 added lines, -2 removed lines

@@ -33,8 +33,8 @@
         $a = new ResultData(ResultData::EXITCODE_OK, '', ['one' => 'first', 'two' => 'second']);
 
         $to_be_merged = [
-            ['one' => 'ignored',],
-            ['three' => 'new',],
+            ['one' => 'ignored', ],
+            ['three' => 'new', ],
         ];
 
         foreach ($to_be_merged as $mergeThis) {

src/Collection/Collection.php

Doc Comments +6 added lines, -5 removed lines

@@ -207,7 +207,7 @@ 
      *
      * @param string $method
      * @param string $name
-     * @param callable|TaskInterface $task
+     * @param callable $task
      * @param string $nameOfTaskToAdd
      *
      * @return $this
@@ -276,7 +276,7 @@ 
     /**
      * Return the list of task names added to this collection.
      *
-     * @return array
+     * @return integer[]
      */
     public function taskNames()
     {
@@ -349,7 +349,7 @@ 
     }
 
     /**
-     * @param int|string $name
+     * @param string $name
      * @param \Robo\Collection\Element $taskGroup
      *
      * @return $this
@@ -635,7 +635,7 @@ 
     }
 
     /**
-     * @param TaskInterface|NestedCollectionInterface|WrappedTaskInterface $task
+     * @param TaskInterface $task
      *
      * @return \Robo\Result
      */
@@ -689,6 +689,7 @@ 
      * runs. Use this time to provide more settings for the task, e.g. from
      * the collection's shared state, which is populated with the results
      * of previous test runs.
+     * @param \Closure $callback
      */
     public function defer($task, $callback)
     {
@@ -711,7 +712,7 @@ 
 
     /**
      * @param TaskInterface|NestedCollectionInterface|WrappedTaskInterface $task
-     * @param $parentCollection
+     * @param CollectionInterface $parentCollection
      */
     protected function setParentCollectionForTask($task, $parentCollection)
     {

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 use Robo\Exception\TaskException;
 use Robo\Exception\TaskExitException;
 use Robo\Contract\CommandInterface;
-
 use Robo\Contract\InflectionInterface;
 use Robo\State\StateAwareInterface;
 use Robo\State\StateAwareTrait;

Spacing +5 added lines, -5 removed lines

@@ -135,7 +135,7 @@ 
     {
         $collection = $this;
         $completionRegistrationTask = new CallableTask(
-            function () use ($collection, $completionTask) {
+            function() use ($collection, $completionTask) {
 
                 $collection->registerCompletion($completionTask);
             },
@@ -178,7 +178,7 @@ 
         $context += ['name' => 'Progress'];
         $context += TaskInfo::getTaskContext($this);
         return $this->addCode(
-            function () use ($level, $text, $context) {
+            function() use ($level, $text, $context) {
                 $context += $this->getState()->getData();
                 $this->printTaskOutput($level, $text, $context);
             }
@@ -194,7 +194,7 @@ 
     {
         $collection = $this;
         $rollbackRegistrationTask = new CallableTask(
-            function () use ($collection, $rollbackTask) {
+            function() use ($collection, $rollbackTask) {
                 $collection->registerRollback($rollbackTask);
             },
             $this
@@ -247,7 +247,7 @@ 
         if ($task instanceof StackBasedTask) {
             $task->stopOnFail(false);
         }
-        $ignoreErrorsInTask = function () use ($task) {
+        $ignoreErrorsInTask = function() use ($task) {
             $data = [];
             try {
                 $result = $this->runSubtask($task);
@@ -679,7 +679,7 @@ 
     {
         return $this->defer(
             $task,
-            function ($task, $state) use ($functionName, $stateKey) {
+            function($task, $state) use ($functionName, $stateKey) {
                 $fn = [$task, $functionName];
                 $value = $state[$stateKey];
                 $fn($value);

src/Collection/CollectionInterface.php

Doc Comments +7 added lines, -7 removed lines

@@ -25,7 +25,7 @@ 
      *
      * @param TaskInterface $task
      *   The task to add to our collection.
-     * @param int|string $name
+     * @param integer $name
      *   An optional name for the task -- missing or UNNAMEDTASK for unnamed tasks.
      *   Names are used for positioning before and after tasks.
      *
@@ -37,7 +37,7 @@ 
      * Add arbitrary code to execute as a task.
      *
      * @param callable $code Code to execute as a task
-     * @param int|string $name
+     * @param integer $name
      *   An optional name for the task -- missing or UNNAMEDTASK for unnamed tasks.
      *   Names are used for positioning before and after tasks.
      *
@@ -109,9 +109,9 @@ 
      *
      * @param string $name
      *   The name of the task to insert before.  The named task MUST exist.
-     * @param callable|TaskInterface $task
+     * @param callable $task
      *   The task to add.
-     * @param int|string $nameOfTaskToAdd
+     * @param integer $nameOfTaskToAdd
      *   The name of the task to add. If not provided, will be associated
      *   with the named task it was added before.
      *
@@ -124,9 +124,9 @@ 
      *
      * @param string $name
      *   The name of the task to insert before.  The named task MUST exist.
-     * @param callable|TaskInterface $task
+     * @param callable $task
      *   The task to add.
-     * @param int|string $nameOfTaskToAdd
+     * @param integer $nameOfTaskToAdd
      *   The name of the task to add. If not provided, will be associated
      *   with the named task it was added after.
      *
@@ -143,7 +143,7 @@ 
      * @param string $text Message to print.
      * @param array $context Extra context data for use by the logger. Note
      *   that the data from the collection state is merged with the provided context.
-     * @param \Psr\Log\LogLevel|string $level The log level to print the information at. Default is NOTICE.
+     * @param string $level The log level to print the information at. Default is NOTICE.
      *
      * @return $this
      */

tests/unit/Task/CollectionTest.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use Robo\Robo;
 use Robo\Result;
 use Robo\State\Data;
-use Robo\Task\BaseTask;
 use Robo\Collection\Collection;
 use Robo\Task\ValueProviderTask;
 use Robo\Task\CollectionTestTask;

Spacing +8 added lines, -8 removed lines

@@ -110,11 +110,11 @@ 
             ->completion($completion1)
             ->rollbackCode(function() use($rollback1) { $rollback1->run(); } )
             ->completionCode(function() use($completion1) { $completion1->run(); } )
-            ->addCode(function () { return 42; })
+            ->addCode(function() { return 42; })
             ->progressMessage("not reached")
             ->rollback($rollback2)
             ->completion($completion2)
-            ->addCode(function () { return 13; });
+            ->addCode(function() { return 13; });
 
         $collection->setLogger($this->guy->logger());
 
@@ -137,15 +137,15 @@ 
 
         $result = $collection
             ->addCode(
-                function (Data $state) {
+                function(Data $state) {
                     $state['one'] = 'first';
                 })
             ->addCode(
-                function (Data $state) {
+                function(Data $state) {
                     $state['two'] = 'second';
                 })
             ->addCode(
-                function (Data $state) {
+                function(Data $state) {
                     $state['three'] = "{$state['one']} and {$state['two']}";
                 })
             ->run();
@@ -169,7 +169,7 @@ 
             ->add($first)
             ->add($second)
             ->addCode(
-                function (Data $state) {
+                function(Data $state) {
                     $state['three'] = "{$state['one']} and {$state['two']}";
                 })
             ->run();
@@ -198,7 +198,7 @@ 
             ->add($third)
                 ->defer(
                     $third,
-                    function ($task, $state) {
+                    function($task, $state) {
                         $task->provideData('three', "{$state['one']} and {$state['two']}");
                     }
                 )
@@ -230,7 +230,7 @@ 
             ->add($third)
                 ->defer(
                     $third,
-                    function ($task, $state) {
+                    function($task, $state) {
                         $task->provideData('three', "{$state['one']} and {$state['two']}");
                     }
                 )

src/Config/Config.php

Doc Comments +1 added lines, -2 removed lines

@@ -139,7 +139,7 @@ 
      * Return the default value for a given configuration item.
      *
      * @param string $key
-     * @param mixed $defaultOverride
+     * @param string|null $defaultOverride
      *
      * @return mixed
      */
@@ -190,7 +190,6 @@ 
     }
 
     /**
-     * @param bool $simulated
      *
      * @return $this
      */

tests/unit/Task/ComposerTest.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 use AspectMock\Test as test;
-
 use Robo\Traits\Common\AdjustQuotes;
 
 class ComposerTest extends \Codeception\TestCase\Test

tests/unit/Task/GulpTest.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 use AspectMock\Test as test;
-
 use Robo\Traits\Common\AdjustQuotes;
 
 class GulpTest extends \Codeception\TestCase\Test

Spacing +9 added lines, -9 removed lines

@@ -23,27 +23,27 @@ 
     public function testGulpGetCommand()
     {
         verify(
-            (new \Robo\Task\Gulp\Run('default','gulp'))->getCommand()
+            (new \Robo\Task\Gulp\Run('default', 'gulp'))->getCommand()
         )->equals($this->adjustQuotes("gulp 'default'"));
 
         verify(
-            (new \Robo\Task\Gulp\Run('another','gulp'))->getCommand()
+            (new \Robo\Task\Gulp\Run('another', 'gulp'))->getCommand()
         )->equals($this->adjustQuotes("gulp 'another'"));
 
         verify(
-            (new \Robo\Task\Gulp\Run('default','gulp'))->silent()->getCommand()
+            (new \Robo\Task\Gulp\Run('default', 'gulp'))->silent()->getCommand()
         )->equals($this->adjustQuotes("gulp 'default' --silent"));
 
         verify(
-            (new \Robo\Task\Gulp\Run('default','gulp'))->noColor()->getCommand()
+            (new \Robo\Task\Gulp\Run('default', 'gulp'))->noColor()->getCommand()
         )->equals($this->adjustQuotes("gulp 'default' --no-color"));
 
         verify(
-            (new \Robo\Task\Gulp\Run('default','gulp'))->color()->getCommand()
+            (new \Robo\Task\Gulp\Run('default', 'gulp'))->color()->getCommand()
         )->equals($this->adjustQuotes("gulp 'default' --color"));
 
         verify(
-            (new \Robo\Task\Gulp\Run('default','gulp'))->simple()->getCommand()
+            (new \Robo\Task\Gulp\Run('default', 'gulp'))->simple()->getCommand()
         )->equals($this->adjustQuotes("gulp 'default' --tasks-simple"));
     }
 
@@ -51,7 +51,7 @@ 
     {
         $gulp = test::double('Robo\Task\Gulp\Run', ['executeCommand' => null, 'getConfig' => new \Robo\Config(), 'logger' => new \Psr\Log\NullLogger()]);
 
-        $task = (new \Robo\Task\Gulp\Run('default','gulp'))->simple();
+        $task = (new \Robo\Task\Gulp\Run('default', 'gulp'))->simple();
         verify($task->getCommand())->equals($this->adjustQuotes("gulp 'default' --tasks-simple"));
         $task->run();
         $gulp->verifyInvoked('executeCommand', [$this->adjustQuotes("gulp 'default' --tasks-simple")]);
@@ -64,13 +64,13 @@ 
         if ($isWindows) {
 
             verify(
-                (new \Robo\Task\Gulp\Run('anotherWith weired!("\') Chars','gulp'))->getCommand()
+                (new \Robo\Task\Gulp\Run('anotherWith weired!("\') Chars', 'gulp'))->getCommand()
             )->equals('gulp "anotherWith weired!(\"\') Chars"');
 
         } else {
 
             verify(
-                (new \Robo\Task\Gulp\Run('anotherWith weired!("\') Chars','gulp'))->getCommand()
+                (new \Robo\Task\Gulp\Run('anotherWith weired!("\') Chars', 'gulp'))->getCommand()
             )->equals("gulp 'anotherWith weired!(\"'\\'') Chars'");
 
         }