consolidation / robo

tests/unit/Task/CollectionTest.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use Robo\Robo;
 use Robo\Result;
 use Robo\State\Data;
-use Robo\Task\BaseTask;
 use Robo\Collection\Collection;
 use Robo\Task\ValueProviderTask;
 use Robo\Task\CollectionTestTask;

Spacing +8 added lines, -8 removed lines

@@ -110,11 +110,11 @@ 
             ->completion($completion1)
             ->rollbackCode(function() use($rollback1) { $rollback1->run(); } )
             ->completionCode(function() use($completion1) { $completion1->run(); } )
-            ->addCode(function () { return 42; })
+            ->addCode(function() { return 42; })
             ->progressMessage("not reached")
             ->rollback($rollback2)
             ->completion($completion2)
-            ->addCode(function () { return 13; });
+            ->addCode(function() { return 13; });
 
         $collection->setLogger($this->guy->logger());
 
@@ -137,15 +137,15 @@ 
 
         $result = $collection
             ->addCode(
-                function (Data $state) {
+                function(Data $state) {
                     $state['one'] = 'first';
                 })
             ->addCode(
-                function (Data $state) {
+                function(Data $state) {
                     $state['two'] = 'second';
                 })
             ->addCode(
-                function (Data $state) {
+                function(Data $state) {
                     $state['three'] = "{$state['one']} and {$state['two']}";
                 })
             ->run();
@@ -169,7 +169,7 @@ 
             ->add($first)
             ->add($second)
             ->addCode(
-                function (Data $state) {
+                function(Data $state) {
                     $state['three'] = "{$state['one']} and {$state['two']}";
                 })
             ->run();
@@ -198,7 +198,7 @@ 
             ->add($third)
                 ->defer(
                     $third,
-                    function ($task, $state) {
+                    function($task, $state) {
                         $task->provideData('three', "{$state['one']} and {$state['two']}");
                     }
                 )
@@ -230,7 +230,7 @@ 
             ->add($third)
                 ->defer(
                     $third,
-                    function ($task, $state) {
+                    function($task, $state) {
                         $task->provideData('three', "{$state['one']} and {$state['two']}");
                     }
                 )

tests/unit/Task/ComposerTest.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 use AspectMock\Test as test;
-
 use Robo\Traits\Common\AdjustQuotes;
 
 class ComposerTest extends \Codeception\TestCase\Test

tests/unit/Task/GulpTest.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 use AspectMock\Test as test;
-
 use Robo\Traits\Common\AdjustQuotes;
 
 class GulpTest extends \Codeception\TestCase\Test

Spacing +9 added lines, -10 removed lines

@@ -24,32 +24,32 @@ 
     {
         $this->assertEquals(
             $this->adjustQuotes("gulp 'default'"),
-            (new \Robo\Task\Gulp\Run('default','gulp'))->getCommand()
+            (new \Robo\Task\Gulp\Run('default', 'gulp'))->getCommand()
         );
 
         $this->assertEquals(
             $this->adjustQuotes("gulp 'another'"),
-            (new \Robo\Task\Gulp\Run('another','gulp'))->getCommand()
+            (new \Robo\Task\Gulp\Run('another', 'gulp'))->getCommand()
         );
 
         $this->assertEquals(
             $this->adjustQuotes("gulp 'default' --silent"),
-            (new \Robo\Task\Gulp\Run('default','gulp'))->silent()->getCommand()
+            (new \Robo\Task\Gulp\Run('default', 'gulp'))->silent()->getCommand()
         );
 
         $this->assertEquals(
             $this->adjustQuotes("gulp 'default' --no-color"),
-            (new \Robo\Task\Gulp\Run('default','gulp'))->noColor()->getCommand()
+            (new \Robo\Task\Gulp\Run('default', 'gulp'))->noColor()->getCommand()
         );
 
         $this->assertEquals(
             $this->adjustQuotes("gulp 'default' --color"),
-            (new \Robo\Task\Gulp\Run('default','gulp'))->color()->getCommand()
+            (new \Robo\Task\Gulp\Run('default', 'gulp'))->color()->getCommand()
         );
 
         $this->assertEquals(
             $this->adjustQuotes("gulp 'default' --tasks-simple"),
-            (new \Robo\Task\Gulp\Run('default','gulp'))->simple()->getCommand()
+            (new \Robo\Task\Gulp\Run('default', 'gulp'))->simple()->getCommand()
         );
     }
 
@@ -57,7 +57,7 @@ 
     {
         $gulp = test::double('Robo\Task\Gulp\Run', ['executeCommand' => null, 'getConfig' => new \Robo\Config(), 'logger' => new \Psr\Log\NullLogger()]);
 
-        $task = (new \Robo\Task\Gulp\Run('default','gulp'))->simple();
+        $task = (new \Robo\Task\Gulp\Run('default', 'gulp'))->simple();
         $this->assertEquals(
             $this->adjustQuotes("gulp 'default' --tasks-simple"),
             $task->getCommand());
@@ -69,12 +69,11 @@ 
     {
         $isWindows = defined('PHP_WINDOWS_VERSION_MAJOR');
         $expected = $isWindows ?
-            'gulp "anotherWith weired!(\"\') Chars"' :
-            "gulp 'anotherWith weired!(\"'\\'') Chars'";
+            'gulp "anotherWith weired!(\"\') Chars"' : "gulp 'anotherWith weired!(\"'\\'') Chars'";
 
         $this->assertEquals(
             $expected,
-            (new \Robo\Task\Gulp\Run('anotherWith weired!("\') Chars','gulp'))->getCommand()
+            (new \Robo\Task\Gulp\Run('anotherWith weired!("\') Chars', 'gulp'))->getCommand()
         );
     }
 }

src/Task/Composer/RequireDependency.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
 
         if (isset($version)) {
             $project = array_map(
-                function ($item) use ($version) {
+                function($item) use ($version) {
                     return "$item:$version";
                 },
                 $project

src/Task/Development/SemVer.php

Spacing +1 added lines, -1 removed lines

@@ -235,7 +235,7 @@
         }
 
         $this->version = array_intersect_key($matches, $this->version);
-        $this->version = array_map(function ($item) {
+        $this->version = array_map(function($item) {
             return $item[0];
         }, $this->version);
     }

src/Common/ConfigAwareTrait.php

Spacing +3 added lines, -3 removed lines

@@ -73,9 +73,9 @@
      */
     private static function getClassKey($key)
     {
-        $configPrefix = static::configPrefix();                            // task.
-        $configClass = static::configClassIdentifier(get_called_class());  // PARTIAL_NAMESPACE.CLASSNAME
-        $configPostFix = static::configPostfix();                          // .settings
+        $configPrefix = static::configPrefix(); // task.
+        $configClass = static::configClassIdentifier(get_called_class()); // PARTIAL_NAMESPACE.CLASSNAME
+        $configPostFix = static::configPostfix(); // .settings
 
         return sprintf('%s%s%s.%s', $configPrefix, $configClass, $configPostFix, $key);
     }

tests/unit/ConfigurationInjectionTest.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 use Robo\Robo;
-
 use Consolidation\Config\Loader\ConfigProcessor;
 use Consolidation\Config\Loader\YamlConfigLoader;
 

src/Common/ProcessUtils.php

Unused Use Statements -2 removed lines

@@ -7,8 +7,6 @@
 
 namespace Robo\Common;
 
-use Symfony\Component\Process\Exception\InvalidArgumentException;
-
 /**
  * ProcessUtils is a bunch of utility methods. We want to allow Robo 1.x
  * to work with Symfony 4.x while remaining backwards compatibility. This

Doc Comments +3 added lines

@@ -74,6 +74,9 @@
         return "'" . str_replace("'", "'\\''", $argument) . "'";
     }
 
+    /**
+     * @param string $char
+     */
     private static function isSurroundedBy($arg, $char)
     {
         return 2 < strlen($arg) && $char === $arg[0] && $char === $arg[strlen($arg) - 1];

src/ClassDiscovery/RelativeNamespaceDiscovery.php

Indentation +2 added lines, -2 removed lines

@@ -91,8 +91,8 @@
     {
         $finder = new Finder();
         $finder->files()
-          ->name($pattern)
-          ->in($directories);
+            ->name($pattern)
+            ->in($directories);
 
         return $finder;
     }

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
         $relativePath = $this->convertNamespaceToPath($this->relativeNamespace);
 
         foreach ($this->classLoader->getPrefixesPsr4() as $baseNamespace => $directories) {
-            $directories = array_filter(array_map(function ($directory) use ($relativePath) {
+            $directories = array_filter(array_map(function($directory) use ($relativePath) {
                 return $directory . $relativePath;
             }, $directories), 'is_dir');