Robo\Common\ProcessExecutor

Complexity

Total Complexity

4

Size/Duplication

Total Lines	41
Duplicated Lines	26.83 %

Coupling/Cohesion

Components	2
Dependencies	5

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	create()	11	11	1
A	getCommandDescription()	0	4	1
A	run()	0	4	1

<?php

namespace Robo\Common;

use Psr\Log\LoggerAwareInterface;
use Robo\Contract\ConfigAwareInterface;
use Robo\Contract\OutputAwareInterface;
use Robo\Contract\VerbosityThresholdInterface;
use Symfony\Component\Process\Process;

class ProcessExecutor implements ConfigAwareInterface, LoggerAwareInterface, OutputAwareInterface, VerbosityThresholdInterface
{
    use ExecTrait;
    use TaskIO; // uses LoggerAwareTrait and ConfigAwareTrait
    use ProgressIndicatorAwareTrait;
    use OutputAwareTrait;

    /**
     * @param Process $process
     * @return type

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct(Process $process)
    {
        $this->process = $process;
    }

    public static function create($container)

This method seems to be duplicated in your project.

    {
        $processExecutor = new self($commandFile);

The variable $commandFile does not exist. Did you forget to declare it?

        $processExecutor->setLogger($container->get('logger'));
        $processExecutor->setProgressIndicator($container->get('progressIndicator'));
        $processExecutor->setConfig($container->get('config'));
        $processExecutor->setOutputAdapter($container->get('outputAdapter'));

        return $processExecutor;
    }

    /**
     * @return string
     */
    protected function getCommandDescription()
    {
        return $this->process->getCommandLine();
    }

    public function run()
    {
        return $this->execute($this->process);
    }
}