consolidation / robo

src/Task/Filesystem/FlattenDir.php

Doc Comments +1 added lines, -1 removed lines

@@ -198,7 +198,7 @@
     }
 
     /**
-     * @param array $dirs
+     * @param string[] $dirs
      *
      * @return array|\Robo\Result
      *

Spacing +6 added lines, -6 removed lines

@@ -127,7 +127,7 @@ 
      */
     public function dirPermissions($permission)
     {
-        $this->chmod = (int) $permission;
+        $this->chmod = (int)$permission;
 
         return $this;
     }
@@ -176,7 +176,7 @@ 
     {
         if (!$this->fs->isAbsolutePath($dir)) {
             // attach the relative path to current working directory
-            $dir = getcwd().'/'.$dir;
+            $dir = getcwd() . '/' . $dir;
         }
         $this->parentDir = $dir;
 
@@ -230,7 +230,7 @@ 
             } catch (\InvalidArgumentException $e) {
                 // if finder cannot handle it, try with in()->name()
                 if (strpos($dir, '/') === false) {
-                    $dir = './'.$dir;
+                    $dir = './' . $dir;
                 }
                 $parts = explode('/', $dir);
                 $new_dir = implode('/', array_slice($parts, 0, -1));
@@ -260,7 +260,7 @@ 
      */
     protected function getTarget($file, $to)
     {
-        $target = $to.'/'.basename($file);
+        $target = $to . '/' . basename($file);
         if ($this->parents !== array(0, 0)) {
             // if the parent is set, create additional directories inside target
             // get relative path to parentDir
@@ -268,10 +268,10 @@ 
             // get top parents and bottom parents
             $parts = explode('/', rtrim($rel_path, '/'));
             $prefix_dir = '';
-            $prefix_dir .= ($this->parents[0] > 0 ? implode('/', array_slice($parts, 0, $this->parents[0])).'/' : '');
+            $prefix_dir .= ($this->parents[0] > 0 ? implode('/', array_slice($parts, 0, $this->parents[0])) . '/' : '');
             $prefix_dir .= ($this->parents[1] > 0 ? implode('/', array_slice($parts, (0 - $this->parents[1]), $this->parents[1])) : '');
             $prefix_dir = rtrim($prefix_dir, '/');
-            $target = $to.'/'.$prefix_dir.'/'.basename($file);
+            $target = $to . '/' . $prefix_dir . '/' . basename($file);
         }
 
         return $target;

src/Common/ResourceExistenceChecker.php

Indentation +14 added lines, -14 removed lines

@@ -90,25 +90,25 @@
         $this->checkResources($targets);
     }
 
-   /**
-    * Wrapper method around phps is_dir()
-    *
-    * @param string $directory
-    *
-    * @return bool
-    */
+    /**
+     * Wrapper method around phps is_dir()
+     *
+     * @param string $directory
+     *
+     * @return bool
+     */
     protected function isDir($directory)
     {
         return is_dir($directory);
     }
 
-   /**
-    * Wrapper method around phps file_exists()
-    *
-    * @param string $file
-    *
-    * @return bool
-    */
+    /**
+     * Wrapper method around phps file_exists()
+     *
+     * @param string $file
+     *
+     * @return bool
+     */
     protected function isFile($file)
     {
         return file_exists($file);

Doc Comments +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
      * @param string $type
      *   Allowed values: "file", "dir", "fileAndDir".
      *
-     * @return bool
+     * @return boolean|null
      */
     protected function checkResource($resource, $type)
     {

src/Task/Remote/Rsync.php

Doc Comments +1 added lines, -1 removed lines

@@ -353,7 +353,7 @@
     }
 
     /**
-     * @param array|string $pattern
+     * @param string[] $pattern
      *
      * @return $this
      */

tests/unit/Task/HgTest.php

Unused Use Statements -2 removed lines

@@ -1,7 +1,5 @@
 <?php
 
-use AspectMock\Test as test;
-
 class HgTest extends \Codeception\TestCase\Test
 {
     /**

src/Common/ExecCommand.php

Doc Comments +2 added lines, -2 removed lines

@@ -151,7 +151,7 @@ 
      *
      * @param string $cmd
      *
-     * @return bool|string
+     * @return string|false
      */
     protected function findExecutable($cmd)
     {
@@ -180,7 +180,7 @@ 
     }
 
     /**
-     * @return bool|string
+     * @return string|false
      */
     protected function findProjectBin()
     {

Spacing +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
     protected function findProjectBin()
     {
         $cwd = getcwd();
-        $candidates = [ __DIR__ . '/../../vendor/bin', __DIR__ . '/../../bin', $cwd . '/vendor/bin' ];
+        $candidates = [__DIR__ . '/../../vendor/bin', __DIR__ . '/../../bin', $cwd . '/vendor/bin'];
 
         // If this project is inside a vendor directory, give highest priority
         // to that directory.

tests/unit/Common/CommandArgumentsTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
      *
      * @covers ::args
      *
-     * @param string $expected
+     * @param string $expectedLinux
      * @param array $args
      */
     public function testArgs($expectedLinux, $expectedWindows, $args)

src/Task/Base/Exec.php

Doc Comments +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
     protected $command;
 
     /**
-     * @param string|\Robo\Contract\CommandInterface $command
+     * @param string $command
      */
     public function __construct($command)
     {

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 namespace Robo\Task\Base;
 
-use Robo\Common\ExecTrait;
 use Robo\Contract\CommandInterface;
 use Robo\Contract\PrintedInterface;
 use Robo\Contract\SimulatedInterface;

src/Task/Testing/Codecept.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Robo\Exception\TaskException;
 use Robo\Task\BaseTask;
 use Robo\Contract\CommandInterface;
-use Symfony\Component\Process\Process;
 
 /**
  * Executes Codeception tests

src/Task/Assets/ImageMinify.php

Spacing +10 added lines, -10 removed lines

@@ -182,12 +182,12 @@ 
         // guess the best path for the executables based on __DIR__
         if (($pos = strpos(__DIR__, 'consolidation/robo')) !== false) {
             // the executables should be stored in vendor/bin
-            $this->executableTargetDir = substr(__DIR__, 0, $pos).'bin';
+            $this->executableTargetDir = substr(__DIR__, 0, $pos) . 'bin';
         }
 
         // check if the executables are already available
         foreach ($this->imageminRepos as $exec => $url) {
-            $path = $this->executableTargetDir.'/'.$exec;
+            $path = $this->executableTargetDir . '/' . $exec;
             // if this is Windows add a .exe extension
             if (substr($this->getOS(), 0, 3) == 'win') {
                 $path .= '.exe';
@@ -289,7 +289,7 @@ 
             } catch (\InvalidArgumentException $e) {
                 // if finder cannot handle it, try with in()->name()
                 if (strpos($dir, '/') === false) {
-                    $dir = './'.$dir;
+                    $dir = './' . $dir;
                 }
                 $parts = explode('/', $dir);
                 $new_dir = implode('/', array_slice($parts, 0, -1));
@@ -319,7 +319,7 @@ 
      */
     protected function getTarget($file, $to)
     {
-        $target = $to.'/'.basename($file);
+        $target = $to . '/' . basename($file);
 
         return $target;
     }
@@ -432,7 +432,7 @@ 
     protected function getOS()
     {
         $os = php_uname('s');
-        $os .= '/'.php_uname('m');
+        $os .= '/' . php_uname('m');
         // replace x86_64 to x64, because the imagemin repo uses that
         $os = str_replace('x86_64', 'x64', $os);
         // replace i386, i686, etc to x86, because of imagemin
@@ -492,10 +492,10 @@ 
         $this->printTaskInfo('Downloading the {executable} executable from the imagemin repository', ['executable' => $executable]);
 
         $os = $this->getOS();
-        $url = $this->imageminRepos[$executable].'/blob/master/vendor/'.$os.'/'.$executable.'?raw=true';
+        $url = $this->imageminRepos[$executable] . '/blob/master/vendor/' . $os . '/' . $executable . '?raw=true';
         if (substr($os, 0, 3) == 'win') {
             // if it is win, add a .exe extension
-            $url = $this->imageminRepos[$executable].'/blob/master/vendor/'.$os.'/'.$executable.'.exe?raw=true';
+            $url = $this->imageminRepos[$executable] . '/blob/master/vendor/' . $os . '/' . $executable . '.exe?raw=true';
         }
         $data = @file_get_contents($url, false, null);
         if ($data === false) {
@@ -525,10 +525,10 @@ 
             mkdir($this->executableTargetDir);
         }
         // save the executable into the target dir
-        $path = $this->executableTargetDir.'/'.$executable;
+        $path = $this->executableTargetDir . '/' . $executable;
         if (substr($os, 0, 3) == 'win') {
             // if it is win, add a .exe extension
-            $path = $this->executableTargetDir.'/'.$executable.'.exe';
+            $path = $this->executableTargetDir . '/' . $executable . '.exe';
         }
         $result = file_put_contents($path, $data);
         if ($result === false) {
@@ -540,7 +540,7 @@ 
         chmod($path, 0755);
 
         // if everything successful, store the executable path
-        $this->executablePaths[$executable] = $this->executableTargetDir.'/'.$executable;
+        $this->executablePaths[$executable] = $this->executableTargetDir . '/' . $executable;
         // if it is win, add a .exe extension
         if (substr($os, 0, 3) == 'win') {
             $this->executablePaths[$executable] .= '.exe';