Issues in SvnTest.php - All Issues - Inspection of "Add StdinHandler to the standard Robo DI container..." - consolidation/robo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8b8afe...5f2bbe )

by Greg

created 2018-12-14 02:12 UTC

tests/unit/Task/SvnTest.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use AspectMock\Test as test;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Robo\Robo;

class SvnTest extends \Codeception\TestCase\Test
{
    /**
     * @var \AspectMock\Proxy\ClassProxy
     */
    protected $svn;

    protected function _before()
    {
        $progressBar = test::double('Symfony\Component\Console\Helper\ProgressBar');
        $nullOutput = new \Symfony\Component\Console\Output\NullOutput();

        $progressIndicator = new \Robo\Common\ProgressIndicator($progressBar, $nullOutput);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->svn = test::double('Robo\Task\Vcs\SvnStack', [
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
            'executeCommand' => new \AspectMock\Proxy\Anything(),
            'output' => $nullOutput,
            'logger' => new \Psr\Log\NullLogger(),
            'logger' => Robo::logger(),
            'getConfig' => Robo::config(),
            'progressIndicator' => $progressIndicator,
        ]);
    }

    // tests
    public function testSvnStackRun()
    {
        $this->svn->construct()->update()->add()->run();
        $this->svn->verifyInvoked('executeCommand', ['svn update && svn add']);
    }

    public function testSvnStackCommands()
    {
        verify(
            (new \Robo\Task\Vcs\SvnStack('guest', 'foo'))
                ->checkout('svn://server/trunk')
                ->update()
                ->add()
                ->commit('changed')
                ->getCommand()
        )->equals("svn --username guest --password foo checkout svn://server/trunk && svn --username guest --password foo update && svn --username guest --password foo add && svn --username guest --password foo commit -m 'changed'");
    }

}


1			<?php
2
3			use AspectMock\Test as test;
			0 ignored issues – show Bug introduced 2016-09-13 23:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `test`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
4			use Robo\Robo;
5
6			class SvnTest extends \Codeception\TestCase\Test
7			{
8			/**
9			* @var \AspectMock\Proxy\ClassProxy
10			*/
11			protected $svn;
12
13			protected function _before()
14			{
15			$progressBar = test::double('Symfony\Component\Console\Helper\ProgressBar');
16			$nullOutput = new \Symfony\Component\Console\Output\NullOutput();
17
18			$progressIndicator = new \Robo\Common\ProgressIndicator($progressBar, $nullOutput);
			0 ignored issues – show Documentation introduced 2016-10-16 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$progressBar` is of type `object<AspectMock\Proxy\...oxy\InstanceProxy>\|null`, but the function expects a `object<Symfony\Component...ole\Helper\ProgressBar>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
19
20			$this->svn = test::double('Robo\Task\Vcs\SvnStack', [
			0 ignored issues – show Documentation Bug introduced 2016-09-13 23:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\AspectMock\Test::double...=> $progressIndicator))` can also be of type `object<AspectMock\Proxy\InstanceProxy>`. However, the property `$svn` is declared as type `object<AspectMock\Proxy\ClassProxy>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
21			'executeCommand' => new \AspectMock\Proxy\Anything(),
22			'output' => $nullOutput,
23			'logger' => new \Psr\Log\NullLogger(),
24			'logger' => Robo::logger(),
25			'getConfig' => Robo::config(),
26			'progressIndicator' => $progressIndicator,
27			]);
28			}
29
30			// tests
31			public function testSvnStackRun()
32			{
33			$this->svn->construct()->update()->add()->run();
34			$this->svn->verifyInvoked('executeCommand', ['svn update && svn add']);
35			}
36
37			public function testSvnStackCommands()
38			{
39			verify(
40			(new \Robo\Task\Vcs\SvnStack('guest', 'foo'))
41			->checkout('svn://server/trunk')
42			->update()
43			->add()
44			->commit('changed')
45			->getCommand()
46			)->equals("svn --username guest --password foo checkout svn://server/trunk && svn --username guest --password foo update && svn --username guest --password foo add && svn --username guest --password foo commit -m 'changed'");
47			}
48
49			}
50

consolidation / robo

Push — master ( 8b8afe...5f2bbe )

tests/unit/Task/SvnTest.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like