Issues in SemVerTest.php - All Issues - Inspection of "Add StdinHandler to the standard Robo DI container..." - consolidation/robo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8b8afe...5f2bbe )

by Greg

created 2018-12-14 02:12 UTC

tests/unit/Task/SemVerTest.php (1 issue)

Showing only issues like (Show All)

Check for unnecessary variable assignments.

Unused Code Major

Greg Anderson 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use AspectMock\Test as test;

class SemVerTest extends \Codeception\TestCase\Test
{
    public function testSemver()
    {
        $semver = test::double('Robo\Task\Development\SemVer', ['dump' => null]);
        $res = (new \Robo\Task\Development\SemVer())
            ->increment('major')
            ->prerelease('RC')
            ->increment('patch')
            ->run();
        verify($res->getMessage())->equals('v1.0.1-RC.1');
        $semver->verifyInvoked('dump');
    }

    public function testSemverIncrementMinorAfterIncrementedPatch()
    {
        $semver = test::double('Robo\Task\Development\SemVer', ['dump' => null]);
        $res = (new \Robo\Task\Development\SemVer())
            ->increment('patch')
            ->run();
        verify($res->getMessage())->equals('v0.0.1');
        $res = (new \Robo\Task\Development\SemVer())
            ->increment('minor')
            ->run();
        verify($res->getMessage())->equals('v0.1.0');
        $semver->verifyInvoked('dump');
    }

    public function testSemverIncrementMajorAfterIncrementedMinorAndPatch()
    {
        $semver = test::double('Robo\Task\Development\SemVer', ['dump' => null]);
        $res = (new \Robo\Task\Development\SemVer())
            ->increment('patch')
            ->run();
        verify($res->getMessage())->equals('v0.0.1');
        $res = (new \Robo\Task\Development\SemVer())
            ->increment('minor')
            ->run();
        verify($res->getMessage())->equals('v0.1.0');
        $res = (new \Robo\Task\Development\SemVer())
            ->increment('major')
            ->run();
        verify($res->getMessage())->equals('v1.0.0');
        $semver->verifyInvoked('dump');
    }

    public function testSemverParseFileWithWindowsLineEndings()
    {
        $fixturePath = tempnam(sys_get_temp_dir(), 'semver');
        $semverFile = str_replace("\n", "\r\n", file_get_contents(codecept_data_dir().'.semver'));
        file_put_contents($fixturePath, $semverFile);

        $res = (new \Robo\Task\Development\SemVer($fixturePath))
            ->run();
        verify($res->getMessage())->equals('v1.0.1-RC.1');
        @unlink($fixturePath);
    }

    public function testThrowsExceptionWhenIncrementWithWrongParameter()
    {
        \PHPUnit_Framework_TestCase::setExpectedExceptionRegExp(
            'Robo\Exception\TaskException',
            '/Bad argument, only one of the following is allowed: major, minor, patch/'
        );
        $res = (new \Robo\Task\Development\SemVer())
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            ->increment('wrongParameter');
    }

    public function testThrowsExceptionWhenSemverFileNotWriteable()
    {
        \PHPUnit_Framework_TestCase::setExpectedExceptionRegExp(
            'Robo\Exception\TaskException',
            '/Failed to write semver file./'
        );
        (new \Robo\Task\Development\SemVer('/.semver'))
            ->increment('major')
            ->run();
    }
}


1			<?php
2
3			use AspectMock\Test as test;
4
5			class SemVerTest extends \Codeception\TestCase\Test
6			{
7			public function testSemver()
8			{
9			$semver = test::double('Robo\Task\Development\SemVer', ['dump' => null]);
10			$res = (new \Robo\Task\Development\SemVer())
11			->increment('major')
12			->prerelease('RC')
13			->increment('patch')
14			->run();
15			verify($res->getMessage())->equals('v1.0.1-RC.1');
16			$semver->verifyInvoked('dump');
17			}
18
19			public function testSemverIncrementMinorAfterIncrementedPatch()
20			{
21			$semver = test::double('Robo\Task\Development\SemVer', ['dump' => null]);
22			$res = (new \Robo\Task\Development\SemVer())
23			->increment('patch')
24			->run();
25			verify($res->getMessage())->equals('v0.0.1');
26			$res = (new \Robo\Task\Development\SemVer())
27			->increment('minor')
28			->run();
29			verify($res->getMessage())->equals('v0.1.0');
30			$semver->verifyInvoked('dump');
31			}
32
33			public function testSemverIncrementMajorAfterIncrementedMinorAndPatch()
34			{
35			$semver = test::double('Robo\Task\Development\SemVer', ['dump' => null]);
36			$res = (new \Robo\Task\Development\SemVer())
37			->increment('patch')
38			->run();
39			verify($res->getMessage())->equals('v0.0.1');
40			$res = (new \Robo\Task\Development\SemVer())
41			->increment('minor')
42			->run();
43			verify($res->getMessage())->equals('v0.1.0');
44			$res = (new \Robo\Task\Development\SemVer())
45			->increment('major')
46			->run();
47			verify($res->getMessage())->equals('v1.0.0');
48			$semver->verifyInvoked('dump');
49			}
50
51			public function testSemverParseFileWithWindowsLineEndings()
52			{
53			$fixturePath = tempnam(sys_get_temp_dir(), 'semver');
54			$semverFile = str_replace("\n", "\r\n", file_get_contents(codecept_data_dir().'.semver'));
55			file_put_contents($fixturePath, $semverFile);
56
57			$res = (new \Robo\Task\Development\SemVer($fixturePath))
58			->run();
59			verify($res->getMessage())->equals('v1.0.1-RC.1');
60			@unlink($fixturePath);
61			}
62
63			public function testThrowsExceptionWhenIncrementWithWrongParameter()
64			{
65			\PHPUnit_Framework_TestCase::setExpectedExceptionRegExp(
66			'Robo\Exception\TaskException',
67			'/Bad argument, only one of the following is allowed: major, minor, patch/'
68			);
69			$res = (new \Robo\Task\Development\SemVer())
			0 ignored issues – show Unused Code introduced 2016-09-13 23:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$res` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
70			->increment('wrongParameter');
71			}
72
73			public function testThrowsExceptionWhenSemverFileNotWriteable()
74			{
75			\PHPUnit_Framework_TestCase::setExpectedExceptionRegExp(
76			'Robo\Exception\TaskException',
77			'/Failed to write semver file./'
78			);
79			(new \Robo\Task\Development\SemVer('/.semver'))
80			->increment('major')
81			->run();
82			}
83			}
84

consolidation / robo

Push — master ( 8b8afe...5f2bbe )

tests/unit/Task/SemVerTest.php (1 issue)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like