These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | namespace Robo\Task\Archive; |
||
3 | |||
4 | trait loadTasks |
||
5 | { |
||
6 | /** |
||
7 | * @param $filename |
||
8 | * |
||
9 | * @return Pack |
||
10 | */ |
||
11 | protected function taskPack($filename) |
||
12 | { |
||
13 | return $this->task(Pack::class, $filename); |
||
0 ignored issues
–
show
|
|||
14 | } |
||
15 | |||
16 | /** |
||
17 | * @param $filename |
||
18 | * |
||
19 | * @return Extract |
||
20 | */ |
||
21 | protected function taskExtract($filename) |
||
22 | { |
||
23 | return $this->task(Extract::class, $filename); |
||
0 ignored issues
–
show
It seems like
task() must be provided by classes using this trait. How about adding it as abstract method to this trait?
This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable {
public function equalIds(Idable $other) {
return $this->getId() === $other->getId();
}
}
The trait Adding the
Loading history...
|
|||
24 | } |
||
25 | } |
||
26 |
This check looks for methods that are used by a trait but not required by it.
To illustrate, let’s look at the following code example
The trait
Idable
provides a methodequalsId
that in turn relies on the methodgetId()
. If this method does not exist on a class mixing in this trait, the method will fail.Adding the
getId()
as an abstract method to the trait will make sure it is available.