ComposerTest::testComposerConfigCommand() - Code Metrics - Inspection of "Add composer init task, and general composer round..." - consolidation/robo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#586)

by Greg

created 2017-06-01 23:57 UTC

ComposerTest::testComposerConfigCommand() B

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	24
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	24
rs	8.9713
c	0
b	0
f	0
cc	1
eloc	20
nc	1
nop	0

<?php
use AspectMock\Test as test;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

class ComposerTest extends \Codeception\TestCase\Test
namespace YourVendor;

class YourClass { }
{
    protected $container;

    /**
     * @var \AspectMock\Proxy\ClassProxy
     */
    protected $baseComposer;

    protected function _before()
    {
        $this->baseComposer = test::double('Robo\Task\Composer\Base', [
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
            'output' => new \Symfony\Component\Console\Output\NullOutput(),
            'logger' => new \Psr\Log\NullLogger(),
        ]);
    }
    // tests
    public function testComposerInstall()

    {
        $composer = test::double('Robo\Task\Composer\Install', ['executeCommand' => null, 'getConfig' => new \Robo\Config(), 'logger' => new \Psr\Log\NullLogger()]);


        (new \Robo\Task\Composer\Install('composer'))->run();
        $composer->verifyInvoked('executeCommand', ['composer install --no-interaction']);

        (new \Robo\Task\Composer\Install('composer'))
            ->preferSource()
            ->run();
        $composer->verifyInvoked('executeCommand', ['composer install --prefer-source --no-interaction']);

        (new \Robo\Task\Composer\Install('composer'))
            ->optimizeAutoloader()
            ->run();
        $composer->verifyInvoked('executeCommand', ['composer install --optimize-autoloader --no-interaction']);
    }

    public function testComposerInstallAnsi()
    {
        $config = new \Robo\Config();

        $config->setDecorated(true);
        $config->setInteractive(true);
        $composer = test::double('Robo\Task\Composer\Install', ['executeCommand' => null, 'getConfig' => $config, 'logger' => new \Psr\Log\NullLogger()]);

        (new \Robo\Task\Composer\Install('composer'))->run();
        $composer->verifyInvoked('executeCommand', ['composer install --ansi']);

        (new \Robo\Task\Composer\Install('composer'))
            ->preferSource()
            ->run();
        $composer->verifyInvoked('executeCommand', ['composer install --prefer-source --ansi']);

        (new \Robo\Task\Composer\Install('composer'))
            ->optimizeAutoloader()
            ->run();
        $composer->verifyInvoked('executeCommand', ['composer install --optimize-autoloader --ansi']);
    }

    public function testComposerUpdate()

    {
        $composer = test::double('Robo\Task\Composer\Update', ['executeCommand' => null, 'getConfig' => new \Robo\Config(), 'logger' => new \Psr\Log\NullLogger()]);


        (new \Robo\Task\Composer\Update('composer'))->run();
        $composer->verifyInvoked('executeCommand', ['composer update --no-interaction']);

        (new \Robo\Task\Composer\Update('composer'))
            ->optimizeAutoloader()
            ->run();
        $composer->verifyInvoked('executeCommand', ['composer update --optimize-autoloader --no-interaction']);
    }

    public function testComposerDumpAutoload()
    {
        $composer = test::double('Robo\Task\Composer\DumpAutoload', ['executeCommand' => null, 'getConfig' => new \Robo\Config(), 'logger' => new \Psr\Log\NullLogger()]);


        (new \Robo\Task\Composer\DumpAutoload('composer'))->run();
        $composer->verifyInvoked('executeCommand', ['composer dump-autoload --no-interaction']);

        (new \Robo\Task\Composer\DumpAutoload('composer'))
            ->noDev()
            ->run();
        $composer->verifyInvoked('executeCommand', ['composer dump-autoload --no-dev --no-interaction']);

        (new \Robo\Task\Composer\DumpAutoload('composer'))
            ->optimize()
            ->run();
        $composer->verifyInvoked('executeCommand', ['composer dump-autoload --optimize --no-interaction']);

        (new \Robo\Task\Composer\DumpAutoload('composer'))
            ->optimize()
            ->noDev()
            ->run();
        $composer->verifyInvoked('executeCommand', ['composer dump-autoload --optimize --no-dev --no-interaction']);
    }

    public function testComposerValidate()
    {
        $composer = test::double('Robo\Task\Composer\Validate', ['executeCommand' => null, 'getConfig' => new \Robo\Config(), 'logger' => new \Psr\Log\NullLogger()]);


        (new \Robo\Task\Composer\Validate('composer'))->run();
        $composer->verifyInvoked('executeCommand', ['composer validate --no-interaction']);

        (new \Robo\Task\Composer\Validate('composer'))
            ->noCheckAll()
            ->run();
        $composer->verifyInvoked('executeCommand', ['composer validate --no-check-all --no-interaction']);

        (new \Robo\Task\Composer\Validate('composer'))
            ->noCheckLock()
            ->run();
        $composer->verifyInvoked('executeCommand', ['composer validate --no-check-lock --no-interaction']);

        (new \Robo\Task\Composer\Validate('composer'))
            ->noCheckPublish()
            ->run();
        $composer->verifyInvoked('executeCommand', ['composer validate --no-check-publish --no-interaction']);

        (new \Robo\Task\Composer\Validate('composer'))
            ->withDependencies()
            ->run();
        $composer->verifyInvoked('executeCommand', ['composer validate --with-dependencies --no-interaction']);

        (new \Robo\Task\Composer\Validate('composer'))
            ->strict()
            ->run();
        $composer->verifyInvoked('executeCommand', ['composer validate --strict --no-interaction']);
    }

    public function testComposerInstallCommand()
    {
        verify(
            (new \Robo\Task\Composer\Install('composer'))->setConfig(new \Robo\Config())->getCommand()

        )->equals('composer install --no-interaction');

        verify(
            (new \Robo\Task\Composer\Install('composer'))
                ->setConfig(new \Robo\Config())

                ->noDev()
                ->preferDist()
                ->optimizeAutoloader()
                ->getCommand()
        )->equals('composer install --optimize-autoloader --prefer-dist --no-dev --no-interaction');
    }

    public function testComposerUpdateCommand()
    {
        verify(
            (new \Robo\Task\Composer\Update('composer'))->setConfig(new \Robo\Config())->getCommand()

        )->equals('composer update --no-interaction');

        verify(
            (new \Robo\Task\Composer\Update('composer'))
                ->setConfig(new \Robo\Config())

                ->noDev()
                ->preferDist()
                ->getCommand()
        )->equals('composer update --prefer-dist --no-dev --no-interaction');

        verify(
            (new \Robo\Task\Composer\Update('composer'))
                ->setConfig(new \Robo\Config())

                ->noDev()
                ->preferDist()
                ->optimizeAutoloader()
                ->getCommand()
        )->equals('composer update --optimize-autoloader --prefer-dist --no-dev --no-interaction');
    }

    public function testComposerDumpAutoloadCommand()
    {
        verify(
            (new \Robo\Task\Composer\DumpAutoload('composer'))->setConfig(new \Robo\Config())->getCommand()

        )->equals('composer dump-autoload --no-interaction');

        verify(
            (new \Robo\Task\Composer\DumpAutoload('composer'))
                ->setConfig(new \Robo\Config())

                ->noDev()
                ->getCommand()
        )->equals('composer dump-autoload --no-dev --no-interaction');

        verify(
            (new \Robo\Task\Composer\DumpAutoload('composer'))
                ->setConfig(new \Robo\Config())

                ->optimize()
                ->getCommand()
        )->equals('composer dump-autoload --optimize --no-interaction');

        verify(
            (new \Robo\Task\Composer\DumpAutoload('composer'))
                ->setConfig(new \Robo\Config())

                ->optimize()
                ->noDev()
                ->getCommand()
        )->equals('composer dump-autoload --optimize --no-dev --no-interaction');
    }

    public function testComposerRemove()
    {
        verify(
            (new \Robo\Task\Composer\Remove('composer'))->setConfig(new \Robo\Config())->getCommand()

        )->equals('composer remove --no-interaction');
        verify(
            (new \Robo\Task\Composer\Remove('composer'))
                ->setConfig(new \Robo\Config())

                ->dev()
                ->noProgress()
                ->noUpdate()
                ->getCommand()
        )->equals('composer remove --dev --no-progress --no-update --no-interaction');
    }

    public function testComposerValidateCommand()
    {
        verify(
            (new \Robo\Task\Composer\Validate('composer'))->setConfig(new \Robo\Config())->getCommand()

        )->equals('composer validate --no-interaction');

        verify(
            (new \Robo\Task\Composer\Validate('composer'))
                ->setConfig(new \Robo\Config())

                ->noCheckAll()
                ->getCommand()
        )->equals('composer validate --no-check-all --no-interaction');

        verify(
            (new \Robo\Task\Composer\Validate('composer'))
                ->setConfig(new \Robo\Config())

                ->noCheckLock()
                ->getCommand()
        )->equals('composer validate --no-check-lock --no-interaction');

        verify(
            (new \Robo\Task\Composer\Validate('composer'))
                ->setConfig(new \Robo\Config())

                ->noCheckPublish()
                ->getCommand()
        )->equals('composer validate --no-check-publish --no-interaction');

        verify(
            (new \Robo\Task\Composer\Validate('composer'))
                ->setConfig(new \Robo\Config())

                ->withDependencies()
                ->getCommand()
        )->equals('composer validate --with-dependencies --no-interaction');

        verify(
            (new \Robo\Task\Composer\Validate('composer'))
                ->setConfig(new \Robo\Config())

                ->strict()
                ->getCommand()
        )->equals('composer validate --strict --no-interaction');

        verify(
            (new \Robo\Task\Composer\Validate('composer'))
                ->setConfig(new \Robo\Config())

                ->noCheckAll()
                ->noCheckLock()
                ->noCheckPublish()
                ->withDependencies()
                ->strict()
                ->getCommand()
        )->equals('composer validate --no-check-all --no-check-lock --no-check-publish --with-dependencies --strict --no-interaction');
    }

    public function testComposerInitCommand()
    {
        verify(
            (new \Robo\Task\Composer\Init('composer'))->setConfig(new \Robo\Config())->getCommand()

        )->equals('composer init --no-interaction');

        verify(
            (new \Robo\Task\Composer\Init('composer'))
                ->setConfig(new \Robo\Config())

                ->projectName('foo/bar')
                ->description('A test project')
                ->dependency('baz/boz', '^2.4.8')
                ->projectType('project')
                ->homepage('https://foo.bar.com')
                ->stability('beta')
                ->license('MIT')
                ->repository('https://packages.drupal.org/8')
                ->getCommand()
        )->equals("composer init --name foo/bar --description 'A test project' --require 'baz/boz:^2.4.8' --type project --homepage 'https://foo.bar.com' --stability beta --license MIT --repository 'https://packages.drupal.org/8' --no-interaction");

    }

    public function testComposerConfigCommand()
    {
        verify(
            (new \Robo\Task\Composer\Config('composer'))
                ->setConfig(new \Robo\Config())

                ->set('bin-dir', 'bin/')
                ->getCommand()
        )->equals("composer config bin-dir bin/ --no-interaction");

        verify(
            (new \Robo\Task\Composer\Config('composer'))
                ->setConfig(new \Robo\Config())

                ->useGlobal()
                ->set('bin-dir', 'bin/')
                ->getCommand()
        )->equals("composer config --global bin-dir bin/ --no-interaction");

        verify(
            (new \Robo\Task\Composer\Config('composer'))
                ->setConfig(new \Robo\Config())

                ->repository('drupalorg', 'https://packages.drupal.org/8', 'composer')
                ->getCommand()
        )->equals("composer config repositories.drupalorg composer 'https://packages.drupal.org/8' --no-interaction");
    }

    public function testComposerRequireCommand()
    {
        verify(
            (new \Robo\Task\Composer\RequireDependency('composer'))
                ->setConfig(new \Robo\Config())

                ->dependency('foo/bar', '^2.4.8')
                ->getCommand()
        )->equals("composer require 'foo/bar:^2.4.8' --no-interaction");
    }

    public function testComposerCreateProjectCommand()
    {
        verify(
            (new \Robo\Task\Composer\CreateProject('composer'))
                ->setConfig(new \Robo\Config())

                ->source('foo/bar')
                ->version('^2.4.8')
                ->target('mybar')
                ->repository('https://packages.drupal.org/8')
                ->keepVcs()
                ->noInstall()
                ->getCommand()
        )->equals("composer create-project --repository 'https://packages.drupal.org/8' --keep-vcs --no-install foo/bar mybar '^2.4.8' --no-interaction");
    }
}


1		<?php
2		use AspectMock\Test as test;
		0 ignored issues – show Bug introduced 2017-04-19 01:04 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `test`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
3
4		class ComposerTest extends \Codeception\TestCase\Test
		0 ignored issues – show Coding Style Compatibility introduced 2016-09-13 23:47 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
5		{
6		protected $container;
7
8		/**
9		* @var \AspectMock\Proxy\ClassProxy
10		*/
11		protected $baseComposer;
12
13		protected function _before()
14		{
15		$this->baseComposer = test::double('Robo\Task\Composer\Base', [
		0 ignored issues – show Documentation Bug introduced 2016-09-13 23:47 UTC by Report Bug Copy Issue Report It seems like `\AspectMock\Test::double...\Psr\Log\NullLogger()))` can also be of type `object<AspectMock\Proxy\InstanceProxy>`. However, the property `$baseComposer` is declared as type `object<AspectMock\Proxy\ClassProxy>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
16		'output' => new \Symfony\Component\Console\Output\NullOutput(),
17		'logger' => new \Psr\Log\NullLogger(),
18		]);
19		}
20		// tests
21	View Code Duplication	public function testComposerInstall()
		0 ignored issues – show Duplication introduced 2016-09-13 23:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		{
23		$composer = test::double('Robo\Task\Composer\Install', ['executeCommand' => null, 'getConfig' => new \Robo\Config(), 'logger' => new \Psr\Log\NullLogger()]);
		0 ignored issues – show Deprecated Code introduced 2017-03-25 00:06 UTC by Report Bug Copy Issue Report The class `Robo\Config` has been deprecated with message: Use \Robo\Config\Config This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
24
25		(new \Robo\Task\Composer\Install('composer'))->run();
26		$composer->verifyInvoked('executeCommand', ['composer install --no-interaction']);
27
28		(new \Robo\Task\Composer\Install('composer'))
29		->preferSource()
30		->run();
31		$composer->verifyInvoked('executeCommand', ['composer install --prefer-source --no-interaction']);
32
33		(new \Robo\Task\Composer\Install('composer'))
34		->optimizeAutoloader()
35		->run();

consolidation / robo

Pull Request — master (#586)

ComposerTest::testComposerConfigCommand() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like