Issues in WatchTest.php - All Issues - Inspection of "Improved param injection (#822)" - consolidation/robo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d3a073...5737c8 )

by Greg

created 2019-01-01 22:06 UTC

tests/unit/Task/WatchTest.php (2 issues)

Labels

Severity

Minor 2

Bartosz 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Tests\Unit\Task;

use AspectMock\Test as test;

class WatchTest extends \Codeception\TestCase\Test
{
    /**
     * @var \AspectMock\Proxy\AnythingClassProxy
     */
    protected $resourceWatcher;

    public function _before()
    {
        if (!class_exists('Lurker\\ResourceWatcher')) {
            $this->resourceWatcher = test::spec(
                'Lurker\ResourceWatcher',
                [
                    'start' => true,
                    'track' => true,
                    'addListener' => true
                ]
            )->make();
        } else {
            $this->resourceWatcher = test::double(
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
                'Lurker\ResourceWatcher',
                [
                    'start' => true,
                    'track' => true,
                    'addListener' => true
                ]
            );
        }
    }

    public function testMonitorWithOneEvent()
    {
        $task = new \Robo\Task\Base\Watch($this);

        $task->monitor(
            'src',
            function () {
                //do nothing
            },
            1 // CREATE
        )->run();

        $this->resourceWatcher->verifyInvokedOnce('track');
    }

    public function testMonitorWithTwoEvents()
    {
        $task = new \Robo\Task\Base\Watch($this);

        $task->monitor(
            'src',
            function () {
                //do nothing
            },
            [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                1, //CREATE
                4, //DELETE
            ]
        )->run();

        $this->resourceWatcher->verifyInvokedMultipleTimes('track', 2);
    }
}


1			<?php
2
3			namespace Tests\Unit\Task;
4
5			use AspectMock\Test as test;
6
7			class WatchTest extends \Codeception\TestCase\Test
8			{
9			/**
10			* @var \AspectMock\Proxy\AnythingClassProxy
11			*/
12			protected $resourceWatcher;
13
14			public function _before()
15			{
16			if (!class_exists('Lurker\\ResourceWatcher')) {
17			$this->resourceWatcher = test::spec(
18			'Lurker\ResourceWatcher',
19			[
20			'start' => true,
21			'track' => true,
22			'addListener' => true
23			]
24			)->make();
25			} else {
26			$this->resourceWatcher = test::double(
			0 ignored issues – show Documentation Bug introduced 2018-07-16 20:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\AspectMock\Test::double...'addListener' => true))` can also be of type `object<AspectMock\Proxy\ClassProxy>` or `object<AspectMock\Proxy\InstanceProxy>`. However, the property `$resourceWatcher` is declared as type `object<AspectMock\Proxy\AnythingClassProxy>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
27			'Lurker\ResourceWatcher',
28			[
29			'start' => true,
30			'track' => true,
31			'addListener' => true
32			]
33			);
34			}
35			}
36
37			public function testMonitorWithOneEvent()
38			{
39			$task = new \Robo\Task\Base\Watch($this);
40
41			$task->monitor(
42			'src',
43			function () {
44			//do nothing
45			},
46			1 // CREATE
47			)->run();
48
49			$this->resourceWatcher->verifyInvokedOnce('track');
50			}
51
52			public function testMonitorWithTwoEvents()
53			{
54			$task = new \Robo\Task\Base\Watch($this);
55
56			$task->monitor(
57			'src',
58			function () {
59			//do nothing
60			},
61			[
			0 ignored issues – show Documentation introduced 2018-07-16 20:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array(1, 4)` is of type `array<integer,integer,{"...nteger","1":"integer"}>`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
62			1, //CREATE
63			4, //DELETE
64			]
65			)->run();
66
67			$this->resourceWatcher->verifyInvokedMultipleTimes('track', 2);
68			}
69			}
70

consolidation / robo

Push — master ( d3a073...5737c8 )

tests/unit/Task/WatchTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like