Issues in loadTasks.php - All Issues - Inspection of "Improved param injection (#822)" - consolidation/robo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d3a073...5737c8 )

by Greg

created 2019-01-01 22:06 UTC

src/Task/Assets/loadTasks.php (4 issues)

Labels

Bug 4

Severity

Minor 4

Greg Anderson 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Robo\Task\Assets;

trait loadTasks
{
    /**
    * @param string $input
    *
     * @return \Robo\Task\Assets\Minify
    */
    protected function taskMinify($input)
    {
        return $this->task(Minify::class, $input);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param string|string[] $input
     *
     * @return \Robo\Task\Assets\ImageMinify
     */
    protected function taskImageMinify($input)
    {
        return $this->task(ImageMinify::class, $input);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

   /**
    * @param array $input
    *
    * @return \Robo\Task\Assets\Less
    */
    protected function taskLess($input)
    {
        return $this->task(Less::class, $input);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param array $input
     *
     * @return \Robo\Task\Assets\Scss
     */
    protected function taskScss($input)
    {
        return $this->task(Scss::class, $input);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2			namespace Robo\Task\Assets;
3
4			trait loadTasks
5			{
6			/**
7			* @param string $input
8			*
9			* @return \Robo\Task\Assets\Minify
10			*/
11			protected function taskMinify($input)
12			{
13			return $this->task(Minify::class, $input);
			0 ignored issues – show Bug introduced 2016-09-13 23:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `task()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
14			}
15
16			/**
17			* @param string\|string[] $input
18			*
19			* @return \Robo\Task\Assets\ImageMinify
20			*/
21			protected function taskImageMinify($input)
22			{
23			return $this->task(ImageMinify::class, $input);
			0 ignored issues – show Bug introduced 2016-09-13 23:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `task()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24			}
25
26			/**
27			* @param array $input
28			*
29			* @return \Robo\Task\Assets\Less
30			*/
31			protected function taskLess($input)
32			{
33			return $this->task(Less::class, $input);
			0 ignored issues – show Bug introduced 2016-09-13 23:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `task()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34			}
35
36			/**
37			* @param array $input
38			*
39			* @return \Robo\Task\Assets\Scss
40			*/
41			protected function taskScss($input)
42			{
43			return $this->task(Scss::class, $input);
			0 ignored issues – show Bug introduced 2016-09-13 23:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `task()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
44			}
45			}
46

consolidation / robo

Push — master ( d3a073...5737c8 )

src/Task/Assets/loadTasks.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like