Completed
Pull Request — master (#924)
by Greg
02:13
created
src/Runner.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
     public function __construct($roboClass = null, $roboFile = null)
82 82
     {
83 83
         // set the const as class properties to allow overwriting in child classes
84
-        $this->roboClass = $roboClass ? $roboClass : self::ROBOCLASS ;
84
+        $this->roboClass = $roboClass ? $roboClass : self::ROBOCLASS;
85 85
         $this->roboFile  = $roboFile ? $roboFile : self::ROBOFILE;
86 86
         $this->dir = getcwd();
87 87
     }
Please login to merge, or discard this patch.
src/Application.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
     {
41 41
         $createRoboFile = new Command('init');
42 42
         $createRoboFile->setDescription("Intitalizes basic RoboFile in current dir");
43
-        $createRoboFile->setCode(function () use ($roboClass, $roboFile) {
43
+        $createRoboFile->setCode(function() use ($roboClass, $roboFile) {
44 44
             $output = Robo::output();
45 45
             $output->writeln("<comment>  ~~~ Welcome to Robo! ~~~~ </comment>");
46 46
             $output->writeln("<comment>  " . basename($roboFile) . " will be created in the current directory </comment>");
Please login to merge, or discard this patch.
src/Task/Development/GenerateMarkdownDoc.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -705,7 +705,7 @@  discard block
 block discarded – undo
705 705
         return implode(
706 706
             "\n",
707 707
             array_map(
708
-                function ($line) use ($indent) {
708
+                function($line) use ($indent) {
709 709
                     return substr($line, $indent);
710 710
                 },
711 711
                 explode("\n", $doc)
@@ -727,7 +727,7 @@  discard block
 block discarded – undo
727 727
         $params = implode(
728 728
             ', ',
729 729
             array_map(
730
-                function ($p) {
730
+                function($p) {
731 731
                     return $this->documentParam($p);
732 732
                 },
733 733
                 $reflectedMethod->getParameters()
Please login to merge, or discard this patch.
src/ClassDiscovery/RelativeNamespaceDiscovery.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
         $relativePath = $this->convertNamespaceToPath($this->relativeNamespace);
54 54
 
55 55
         foreach ($this->classLoader->getPrefixesPsr4() as $baseNamespace => $directories) {
56
-            $directories = array_filter(array_map(function ($directory) use ($relativePath) {
56
+            $directories = array_filter(array_map(function($directory) use ($relativePath) {
57 57
                 return $directory . $relativePath;
58 58
             }, $directories), 'is_dir');
59 59
 
Please login to merge, or discard this patch.
src/Collection/CollectionBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -309,7 +309,7 @@
 block discarded – undo
309 309
 
310 310
     /**
311 311
      * @param string $functionName
312
-     * @param int|string $stateKey
312
+     * @param string $stateKey
313 313
      *
314 314
      * @return $this
315 315
      */
Please login to merge, or discard this patch.
tests/functional/ForEachTest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -59,8 +59,8 @@  discard block
 block discarded – undo
59 59
         // set iterable in the __constructor
60 60
         $result = $this
61 61
             ->taskForEach($items)
62
-            ->withBuilder(function (CollectionBuilder $builder, $key, $value) use (&$actual) {
63
-                $builder->addCode(function () use ($key, $value, &$actual) {
62
+            ->withBuilder(function(CollectionBuilder $builder, $key, $value) use (&$actual) {
63
+                $builder->addCode(function() use ($key, $value, &$actual) {
64 64
                     $actual[] = "$key = $value";
65 65
 
66 66
                     return 0;
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         // set iterable with deferTaskConfiguration()
83 83
         $result = $this
84 84
             ->collectionBuilder()
85
-            ->addCode(function (Data $data) use ($items) {
85
+            ->addCode(function(Data $data) use ($items) {
86 86
                 $data['items'] = $items;
87 87
 
88 88
                 return 0;
@@ -91,8 +91,8 @@  discard block
 block discarded – undo
91 91
                 $this
92 92
                     ->taskForEach()
93 93
                     ->deferTaskConfiguration('setIterable', 'items')
94
-                    ->withBuilder(function (CollectionBuilder $builder, $key, $value) use (&$actual) {
95
-                        $builder->addCode(function () use ($key, $value, &$actual) {
94
+                    ->withBuilder(function(CollectionBuilder $builder, $key, $value) use (&$actual) {
95
+                        $builder->addCode(function() use ($key, $value, &$actual) {
96 96
                             $actual[] = "$key = $value";
97 97
 
98 98
                             return 0;
@@ -111,8 +111,8 @@  discard block
 block discarded – undo
111 111
         // call the __constructor() without argument
112 112
         $result = $this
113 113
             ->taskForEach()
114
-            ->withBuilder(function (CollectionBuilder $builder, $key, $value) use (&$actual) {
115
-                $builder->addCode(function () use ($key, $value, &$actual) {
114
+            ->withBuilder(function(CollectionBuilder $builder, $key, $value) use (&$actual) {
115
+                $builder->addCode(function() use ($key, $value, &$actual) {
116 116
                     $actual++;
117 117
 
118 118
                     return 0;
Please login to merge, or discard this patch.
tests/functional/GenerateMarkdownDocTest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -33,13 +33,13 @@  discard block
 block discarded – undo
33 33
 
34 34
         $collection = $this->collectionBuilder();
35 35
         $taskGenerator = $collection->taskGenDoc("TestedRoboTask.md");
36
-        $taskGenerator->filterClasses(function (\ReflectionClass $r) {
36
+        $taskGenerator->filterClasses(function(\ReflectionClass $r) {
37 37
             return !($r->isAbstract() || $r->isTrait()) && $r->implementsInterface('Robo\Contract\TaskInterface');
38 38
         })->prepend("# TestedRoboTask Tasks");
39 39
         $taskGenerator->docClass('TestedRoboTask');
40 40
 
41 41
         $taskGenerator->filterMethods(
42
-            function (\ReflectionMethod $m) {
42
+            function(\ReflectionMethod $m) {
43 43
                 if ($m->isConstructor() || $m->isDestructor() || $m->isStatic()) {
44 44
                     return false;
45 45
                 }
@@ -65,21 +65,21 @@  discard block
 block discarded – undo
65 65
                 return !in_array($m->name, $undocumentedMethods) && $m->isPublic(); // methods are not documented
66 66
             }
67 67
         )->processClassSignature(
68
-            function ($c) {
68
+            function($c) {
69 69
                 return "## " . preg_replace('~Task$~', '', $c->getShortName()) . "\n";
70 70
             }
71 71
         )->processClassDocBlock(
72
-            function (\ReflectionClass $c, $doc) {
72
+            function(\ReflectionClass $c, $doc) {
73 73
                 $doc = preg_replace('~@method .*?(.*?)\)~', '* `$1)` ', $doc);
74
-                $doc = str_replace('\\'.$c->name, '', $doc);
74
+                $doc = str_replace('\\' . $c->name, '', $doc);
75 75
                 return $doc;
76 76
             }
77 77
         )->processMethodSignature(
78
-            function (\ReflectionMethod $m, $text) {
78
+            function(\ReflectionMethod $m, $text) {
79 79
                 return str_replace('#### *public* ', '* `', $text) . '`';
80 80
             }
81 81
         )->processMethodDocBlock(
82
-            function (\ReflectionMethod $m, $text) {
82
+            function(\ReflectionMethod $m, $text) {
83 83
 
84 84
                 return $text ? ' ' . trim(strtok($text, "\n"), "\n") : '';
85 85
             }
Please login to merge, or discard this patch.
tests/functional/AssetsTest.php 1 patch
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -25,29 +25,29 @@
 block discarded – undo
25 25
     public function testCssMinification()
26 26
     {
27 27
         if (version_compare(PHP_VERSION, '7.2.0') >= 0) {
28
-          $this->markTestSkipped('natxet/cssmin uses deprecated "each()" function (PHP 7.2+)');
28
+            $this->markTestSkipped('natxet/cssmin uses deprecated "each()" function (PHP 7.2+)');
29 29
         }
30 30
 
31 31
         $this->fixtures->createAndCdToSandbox();
32 32
 
33
-				$sampleCss = $this->fixtures->dataFile('sample.css');
34
-				$outputCss = 'minifiedSample.css';
33
+                $sampleCss = $this->fixtures->dataFile('sample.css');
34
+                $outputCss = 'minifiedSample.css';
35 35
 
36
-				$initialFileSize = filesize($sampleCss);
36
+                $initialFileSize = filesize($sampleCss);
37 37
 
38
-				$result = $this->taskMinify($sampleCss)
39
-				  ->to('minifiedSample.css')
40
-				  ->run();
38
+                $result = $this->taskMinify($sampleCss)
39
+                    ->to('minifiedSample.css')
40
+                    ->run();
41 41
         $this->assertTrue($result->wasSuccessful(), $result->getMessage());
42 42
 
43
-				$this->assertFileExists($outputCss);
44
-				$minifiedFileSize = filesize($outputCss);
45
-				$outputCssContents = file_get_contents($outputCss);
43
+                $this->assertFileExists($outputCss);
44
+                $minifiedFileSize = filesize($outputCss);
45
+                $outputCssContents = file_get_contents($outputCss);
46 46
 
47
-				$this->assertLessThan($initialFileSize, $minifiedFileSize, 'Minified file is smaller than the source file');
48
-				$this->assertGreaterThan(0, $minifiedFileSize, 'Minified file is not empty');
49
-				$this->assertContains('body', $outputCssContents, 'Minified file has some content from the source file');
50
-				$this->assertNotContains('Sample css file', $outputCssContents, 'Minified file does not contain comment from source file');
47
+                $this->assertLessThan($initialFileSize, $minifiedFileSize, 'Minified file is smaller than the source file');
48
+                $this->assertGreaterThan(0, $minifiedFileSize, 'Minified file is not empty');
49
+                $this->assertContains('body', $outputCssContents, 'Minified file has some content from the source file');
50
+                $this->assertNotContains('Sample css file', $outputCssContents, 'Minified file does not contain comment from source file');
51 51
     }
52 52
 
53 53
 }
Please login to merge, or discard this patch.
tests/functional/WriteFileTest.php 1 patch
Indentation   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -27,10 +27,10 @@  discard block
 block discarded – undo
27 27
     {
28 28
         // write lines with WriteToFile task
29 29
         $result = $this->taskWriteToFile('blogpost.md')
30
-           ->line('****')
31
-           ->line('hello world')
32
-           ->line('****')
33
-           ->run();
30
+            ->line('****')
31
+            ->line('hello world')
32
+            ->line('****')
33
+            ->run();
34 34
         $this->assertTrue($result->wasSuccessful(), $result->getMessage());
35 35
         $this->assertFileExists('blogpost.md');
36 36
         $contents = file_get_contents('blogpost.md');
@@ -46,9 +46,9 @@  discard block
 block discarded – undo
46 46
     public function appendToFile()
47 47
     {
48 48
         $result = $this->taskWriteToFile('a.txt')
49
-           ->append()
50
-           ->line('hello world')
51
-           ->run();
49
+            ->append()
50
+            ->line('hello world')
51
+            ->run();
52 52
         $this->assertTrue($result->wasSuccessful(), $result->getMessage());
53 53
         $this->assertFileExists('a.txt');
54 54
         $contents = file_get_contents('a.txt');
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
     public function testWouldChange()
63 63
     {
64 64
         $writeTask = $this->taskWriteToFile('a.txt')
65
-           ->append();
65
+            ->append();
66 66
         $this->assertEquals(false, $writeTask->wouldChange(), "No changes to test file.");
67 67
         $writeTask->line('hello world');
68 68
         $this->assertEquals(true, $writeTask->wouldChange(), "Test file would change.");
@@ -90,15 +90,15 @@  discard block
 block discarded – undo
90 90
     {
91 91
         // append lines with WriteToFile task, but only if pattern does not match
92 92
         $result = $this->taskWriteToFile('blogpost.md')
93
-           ->line('****')
94
-           ->line('hello world')
95
-           ->line('****')
96
-           ->appendUnlessMatches('/hello/', 'Should not add this')
97
-           ->appendUnlessMatches('/goodbye/', 'Should add this')
98
-           ->appendIfMatches('/hello/', ' and should also add this')
99
-           ->appendIfMatches('/goodbye/', ' but should not add this')
100
-           ->appendIfMatches('/should/', '!')
101
-           ->run();
93
+            ->line('****')
94
+            ->line('hello world')
95
+            ->line('****')
96
+            ->appendUnlessMatches('/hello/', 'Should not add this')
97
+            ->appendUnlessMatches('/goodbye/', 'Should add this')
98
+            ->appendIfMatches('/hello/', ' and should also add this')
99
+            ->appendIfMatches('/goodbye/', ' but should not add this')
100
+            ->appendIfMatches('/should/', '!')
101
+            ->run();
102 102
         $this->assertTrue($result->wasSuccessful(), $result->getMessage());
103 103
         $this->assertFileExists('blogpost.md');
104 104
         $contents = file_get_contents('blogpost.md');
Please login to merge, or discard this patch.