possible assignment of non-compatible types.
These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | |||
3 | use AspectMock\Test as test; |
||
4 | |||
5 | class HgTest extends \Codeception\TestCase\Test |
||
6 | { |
||
7 | /** |
||
8 | * @var \AspectMock\Proxy\ClassProxy |
||
9 | */ |
||
10 | protected $hg; |
||
11 | |||
12 | /** |
||
13 | * @var \Robo\Task\Vcs\HgStack |
||
14 | */ |
||
15 | protected $hgStack; |
||
16 | |||
17 | protected function _before() |
||
18 | { |
||
19 | $this->hg = Test::double('Robo\Task\Vcs\HgStack', [ |
||
0 ignored issues
–
show
|
|||
20 | 'executeCommand' => new \AspectMock\Proxy\Anything(), |
||
21 | 'output' => new \Symfony\Component\Console\Output\NullOutput(), |
||
22 | 'logger' => new \Psr\Log\NullLogger(), |
||
23 | ]); |
||
24 | $this->hgStack = (new \Robo\Task\Vcs\HgStack('hg')); |
||
25 | } |
||
26 | |||
27 | // tests |
||
28 | public function testHgStackRun() |
||
29 | { |
||
30 | $this->hgStack->stopOnFail()->add()->pull()->run(); |
||
31 | $this->hg->verifyInvoked('executeCommand', ['hg add']); |
||
32 | $this->hg->verifyInvoked('executeCommand', ['hg pull']); |
||
33 | |||
34 | (new \Robo\Task\Vcs\HgStack('hg'))->add()->pull()->run(); |
||
35 | $this->hg->verifyInvoked('executeCommand', ['hg add && hg pull']); |
||
36 | } |
||
37 | |||
38 | public function testHgStackPull() |
||
39 | { |
||
40 | verify( |
||
41 | $this->hgStack |
||
42 | ->pull() |
||
43 | ->getCommand() |
||
44 | )->equals('hg pull'); |
||
45 | } |
||
46 | |||
47 | public function testHgStackAddFiles() |
||
48 | { |
||
49 | verify( |
||
50 | $this->hgStack |
||
51 | ->add('*.php', '*.css') |
||
52 | ->getCommand() |
||
53 | )->equals('hg add -I *.php -X *.css'); |
||
54 | } |
||
55 | |||
56 | View Code Duplication | public function testHgStackCommands() |
|
57 | { |
||
58 | verify( |
||
59 | $this->hgStack |
||
60 | ->cloneRepo('https://bitbucket.org/durin42/hgsubversion') |
||
61 | ->pull() |
||
62 | ->add() |
||
63 | ->commit('changed') |
||
64 | ->push() |
||
65 | ->tag('0.6.0') |
||
66 | ->push('0.6.0') |
||
67 | ->getCommand() |
||
68 | )->equals("hg clone https://bitbucket.org/durin42/hgsubversion && hg pull && hg add && hg commit -m 'changed' && hg push && hg tag 0.6.0 && hg push -b '0.6.0'"); |
||
69 | } |
||
70 | |||
71 | View Code Duplication | public function testHgStackCommandsWithTagMessage() |
|
72 | { |
||
73 | verify( |
||
74 | $this->hgStack |
||
75 | ->cloneRepo('https://bitbucket.org/durin42/hgsubversion') |
||
76 | ->pull() |
||
77 | ->add() |
||
78 | ->commit('changed') |
||
79 | ->push() |
||
80 | ->tag('0.6.0', 'message') |
||
81 | ->push('0.6.0') |
||
82 | ->getCommand() |
||
83 | )->equals("hg clone https://bitbucket.org/durin42/hgsubversion && hg pull && hg add && hg commit -m 'changed' && hg push && hg tag -m 'message' 0.6.0 && hg push -b '0.6.0'"); |
||
84 | } |
||
85 | } |
||
86 |
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.
For example, imagine you have a variable
$accountId
that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to theid
property of an instance of theAccount
class. This class holds a proper account, so the id value must no longer be false.Either this assignment is in error or a type check should be added for that assignment.