Issues in loadTasks.php - All Issues - Inspection of "Add test to ensure rollback order is in reverse (#..." - consolidation/robo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a20e35...2a3e96 )

by Greg

created 2018-12-13 15:27 UTC

src/Task/Filesystem/loadTasks.php (8 issues)

Labels

Bug 8

Severity

Minor 8

Greg Anderson 8

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Robo\Task\Filesystem;

trait loadTasks
{
    /**
     * @param string|string[] $dirs
     *
     * @return \Robo\Task\Filesystem\CleanDir
     */
    protected function taskCleanDir($dirs)
    {
        return $this->task(CleanDir::class, $dirs);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param string|string[] $dirs
     *
     * @return \Robo\Task\Filesystem\DeleteDir
     */
    protected function taskDeleteDir($dirs)
    {
        return $this->task(DeleteDir::class, $dirs);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param string $prefix
     * @param string $base
     * @param bool $includeRandomPart
     *
     * @return \Robo\Task\Filesystem\WorkDir
     */
    protected function taskTmpDir($prefix = 'tmp', $base = '', $includeRandomPart = true)
    {
        return $this->task(TmpDir::class, $prefix, $base, $includeRandomPart);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param string $finalDestination
     *
     * @return \Robo\Task\Filesystem\TmpDir
     */
    protected function taskWorkDir($finalDestination)
    {
        return $this->task(WorkDir::class, $finalDestination);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param string|string[] $dirs
     *
     * @return \Robo\Task\Filesystem\CopyDir
     */
    protected function taskCopyDir($dirs)
    {
        return $this->task(CopyDir::class, $dirs);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param string|string[] $dirs
     *
     * @return \Robo\Task\Filesystem\MirrorDir
     */
    protected function taskMirrorDir($dirs)
    {
        return $this->task(MirrorDir::class, $dirs);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param string|string[] $dirs
     *
     * @return \Robo\Task\Filesystem\FlattenDir
     */
    protected function taskFlattenDir($dirs)
    {
        return $this->task(FlattenDir::class, $dirs);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @return \Robo\Task\Filesystem\FilesystemStack
     */
    protected function taskFilesystemStack()
    {
        return $this->task(FilesystemStack::class);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2			namespace Robo\Task\Filesystem;
3
4			trait loadTasks
5			{
6			/**
7			* @param string\|string[] $dirs
8			*
9			* @return \Robo\Task\Filesystem\CleanDir
10			*/
11			protected function taskCleanDir($dirs)
12			{
13			return $this->task(CleanDir::class, $dirs);
			0 ignored issues – show Bug introduced 2016-09-13 23:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `task()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
14			}
15
16			/**
17			* @param string\|string[] $dirs
18			*
19			* @return \Robo\Task\Filesystem\DeleteDir
20			*/
21			protected function taskDeleteDir($dirs)
22			{
23			return $this->task(DeleteDir::class, $dirs);
			0 ignored issues – show Bug introduced 2016-09-13 23:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `task()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24			}
25
26			/**
27			* @param string $prefix
28			* @param string $base
29			* @param bool $includeRandomPart
30			*
31			* @return \Robo\Task\Filesystem\WorkDir
32			*/
33			protected function taskTmpDir($prefix = 'tmp', $base = '', $includeRandomPart = true)
34			{
35			return $this->task(TmpDir::class, $prefix, $base, $includeRandomPart);
			0 ignored issues – show Bug introduced 2016-09-13 23:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `task()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
36			}
37
38			/**
39			* @param string $finalDestination
40			*
41			* @return \Robo\Task\Filesystem\TmpDir
42			*/
43			protected function taskWorkDir($finalDestination)
44			{
45			return $this->task(WorkDir::class, $finalDestination);
			0 ignored issues – show Bug introduced 2016-09-13 23:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `task()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
46			}
47
48			/**
49			* @param string\|string[] $dirs
50			*
51			* @return \Robo\Task\Filesystem\CopyDir
52			*/
53			protected function taskCopyDir($dirs)
54			{
55			return $this->task(CopyDir::class, $dirs);
			0 ignored issues – show Bug introduced 2017-04-19 01:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `task()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
56			}
57
58			/**
59			* @param string\|string[] $dirs
60			*
61			* @return \Robo\Task\Filesystem\MirrorDir
62			*/
63			protected function taskMirrorDir($dirs)
64			{
65			return $this->task(MirrorDir::class, $dirs);
			0 ignored issues – show Bug introduced 2016-09-13 23:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `task()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
66			}
67
68			/**
69			* @param string\|string[] $dirs
70			*
71			* @return \Robo\Task\Filesystem\FlattenDir
72			*/
73			protected function taskFlattenDir($dirs)
74			{
75			return $this->task(FlattenDir::class, $dirs);
			0 ignored issues – show Bug introduced 2016-09-13 23:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `task()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
76			}
77
78			/**
79			* @return \Robo\Task\Filesystem\FilesystemStack
80			*/
81			protected function taskFilesystemStack()
82			{
83			return $this->task(FilesystemStack::class);
			0 ignored issues – show Bug introduced 2016-09-13 23:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `task()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
84			}
85			}
86

consolidation / robo

Push — master ( a20e35...2a3e96 )

src/Task/Filesystem/loadTasks.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like