Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 9 | class RelativeNamespaceDiscoveryTest extends \Codeception\Test\Unit |
||
|
|
|||
| 10 | { |
||
| 11 | View Code Duplication | public function testGetClasses() |
|
| 12 | { |
||
| 13 | $classLoader = new ClassLoader(); |
||
| 14 | $classLoader->addPsr4('\\Robo\\PluginTest\\', [realpath(__DIR__.'/../../plugins')]); |
||
| 15 | $service = new RelativeNamespaceDiscovery($classLoader); |
||
| 16 | $service->setRelativeNamespace('Robo\Plugin'); |
||
| 17 | $service->setSearchPattern('*Commands.php'); |
||
| 18 | $classes = $service->getClasses(); |
||
| 19 | |||
| 20 | $this->assertContains('\Robo\PluginTest\Robo\Plugin\Commands\FirstCustomCommands', $classes); |
||
| 21 | $this->assertContains('\Robo\PluginTest\Robo\Plugin\Commands\SecondCustomCommands', $classes); |
||
| 22 | $this->assertNotContains('\Robo\PluginTest\Robo\Plugin\Commands\NotValidClassName', $classes); |
||
| 23 | } |
||
| 24 | |||
| 25 | View Code Duplication | public function testGetFile() |
|
| 26 | { |
||
| 27 | $classLoader = new ClassLoader(); |
||
| 28 | $classLoader->addPsr4('\\Robo\\PluginTest\\', [realpath(__DIR__.'/../../plugins')]); |
||
| 29 | $service = new RelativeNamespaceDiscovery($classLoader); |
||
| 30 | $service->setRelativeNamespace('Robo\Plugin'); |
||
| 31 | |||
| 32 | $actual = $service->getFile('\Robo\PluginTest\Robo\Plugin\Commands\FirstCustomCommands'); |
||
| 33 | $this->assertStringEndsWith('FirstCustomCommands.php', $actual); |
||
| 34 | |||
| 35 | $actual = $service->getFile('\Robo\PluginTest\Robo\Plugin\Commands\SecondCustomCommands'); |
||
| 36 | $this->assertStringEndsWith('SecondCustomCommands.php', $actual); |
||
| 37 | } |
||
| 38 | |||
| 39 | /** |
||
| 40 | * @dataProvider testConvertPathToNamespaceData |
||
| 41 | * |
||
| 42 | * @param $path |
||
| 43 | * @param $expected |
||
| 44 | */ |
||
| 45 | View Code Duplication | public function testConvertPathToNamespace($path, $expected) |
|
| 52 | |||
| 53 | public function testConvertPathToNamespaceData() |
||
| 62 | |||
| 63 | /** |
||
| 64 | * @dataProvider testConvertNamespaceToPathData |
||
| 65 | * |
||
| 66 | * @param $namespace |
||
| 67 | * @param $expected |
||
| 68 | */ |
||
| 69 | View Code Duplication | public function testConvertNamespaceToPath($namespace, $expected) |
|
| 76 | |||
| 77 | public function testConvertNamespaceToPathData() |
||
| 85 | |||
| 86 | protected function callProtected($object, $method, $args = []) |
||
| 92 | } |
||
| 93 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.