ForEachCest::setIterableInConstructor() - Code Metrics - Inspection of "Issue #656: Add \Robo\Collection\TaskForEach::setI..." - consolidation/robo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#659)

unknown

created 2017-12-16 11:43 UTC

ForEachCest::setIterableInConstructor() B

↳ Parent: ForEachCest

Complexity

Conditions	1
Paths	1

Size

Total Lines	30
Code Lines	19

Duplication

Lines	7
Ratio	23.33 %

Importance

Changes

Metric	Value
dl	7
loc	30
rs	8.8571
c	0
b	0
f	0
cc	1
eloc	19
nc	1
nop	1

<?php

use Robo\Collection\CollectionBuilder;
use Robo\State\Data;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

class ForEachCest {
namespace YourVendor;

class YourClass { }

    public function setIterableInConstructor(CliGuy $I)
    {
        $expected = [
            'a = b',
            'c = d',
            'e = f',
        ];

        $actual = [];

        $items = [
            'a' => 'b',
            'c' => 'd',
            'e' => 'f',
        ];

        $I->wantTo('set iterable in the __constructor');
        $I
            ->taskForEach($items)
            ->withBuilder(function (CollectionBuilder $builder, $key, $value) use (&$actual) {

                $builder->addCode(function () use ($key, $value, &$actual) {
                    $actual[] = "$key = $value";

                    return 0;
                });
            })
            ->run();

        $I->assertEquals($expected, $actual);
    }

    public function setIterableWithDeferTaskConfiguration(CliGuy $I)
    {
        $I->wantTo('set iterable with deferTaskConfiguration()');

        $expected = [
            'a = b',
            'c = d',
            'e = f',
        ];
        $actual = [];
        $I
            ->collectionBuilder()
            ->addCode(function (Data $data) {
                $data['items'] = [
                    'a' => 'b',
                    'c' => 'd',
                    'e' => 'f',
                ];

                return 0;
            })
            ->addTask(
                $I
                    ->taskForEach()
                    ->deferTaskConfiguration('setIterable', 'items')
                    ->withBuilder(function (CollectionBuilder $builder, $key, $value) use (&$actual) {

                        $builder->addCode(function () use ($key, $value, &$actual) {
                            $actual[] = "$key = $value";

                            return 0;
                        });
                    })
            )
            ->run();

        $I->assertEquals($expected, $actual);
    }
}


1		<?php
2
3		use Robo\Collection\CollectionBuilder;
4		use Robo\State\Data;
		0 ignored issues – show Bug introduced 2017-12-16 11:45 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Data`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
5
6		class ForEachCest {
		0 ignored issues – show Coding Style Compatibility introduced 2017-12-16 11:45 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7
8		public function setIterableInConstructor(CliGuy $I)
9		{
10		$expected = [
11		'a = b',
12		'c = d',
13		'e = f',
14		];
15
16		$actual = [];
17
18		$items = [
19		'a' => 'b',
20		'c' => 'd',
21		'e' => 'f',
22		];
23
24		$I->wantTo('set iterable in the __constructor');
25		$I
26		->taskForEach($items)
27	View Code Duplication	->withBuilder(function (CollectionBuilder $builder, $key, $value) use (&$actual) {
		0 ignored issues – show Duplication introduced 2017-12-16 11:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		$builder->addCode(function () use ($key, $value, &$actual) {
29		$actual[] = "$key = $value";
30
31		return 0;
32		});
33		})
34		->run();
35
36		$I->assertEquals($expected, $actual);
37		}
38
39		public function setIterableWithDeferTaskConfiguration(CliGuy $I)
40		{
41		$I->wantTo('set iterable with deferTaskConfiguration()');
42
43		$expected = [
44		'a = b',
45		'c = d',
46		'e = f',
47		];
48		$actual = [];
49		$I
50		->collectionBuilder()
51		->addCode(function (Data $data) {
52		$data['items'] = [
53		'a' => 'b',
54		'c' => 'd',
55		'e' => 'f',
56		];
57
58		return 0;
59		})
60		->addTask(
61		$I
62		->taskForEach()
63		->deferTaskConfiguration('setIterable', 'items')
64	View Code Duplication	->withBuilder(function (CollectionBuilder $builder, $key, $value) use (&$actual) {
		0 ignored issues – show Duplication introduced 2017-12-16 11:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
65		$builder->addCode(function () use ($key, $value, &$actual) {
66		$actual[] = "$key = $value";
67
68		return 0;
69		});
70		})
71		)
72		->run();
73
74		$I->assertEquals($expected, $actual);
75		}
76		}
77

consolidation / robo

Pull Request — master (#659)

ForEachCest::setIterableInConstructor() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like