Completed
Pull Request — master (#737)
by Greg
03:09
created
src/Runner.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
     public function __construct($roboClass = null, $roboFile = null)
64 64
     {
65 65
         // set the const as class properties to allow overwriting in child classes
66
-        $this->roboClass = $roboClass ? $roboClass : self::ROBOCLASS ;
66
+        $this->roboClass = $roboClass ? $roboClass : self::ROBOCLASS;
67 67
         $this->roboFile  = $roboFile ? $roboFile : self::ROBOFILE;
68 68
         $this->dir = getcwd();
69 69
     }
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
     {
240 240
         /** @var \Robo\ClassDiscovery\RelativeNamespaceDiscovery $discovery */
241 241
         $discovery = Robo::service('relativeNamespaceDiscovery');
242
-        $discovery->setRelativeNamespace($relativeNamespace.'\Commands')
242
+        $discovery->setRelativeNamespace($relativeNamespace . '\Commands')
243 243
             ->setSearchPattern('*Commands.php');
244 244
         return $discovery->getClasses();
245 245
     }
@@ -413,9 +413,9 @@  discard block
 block discarded – undo
413 413
 
414 414
         if (substr($argv[$pos], 0, 12) == '--load-from=') {
415 415
             $this->dir = substr($argv[$pos], 12);
416
-        } elseif (isset($argv[$pos +1])) {
417
-            $this->dir = $argv[$pos +1];
418
-            unset($argv[$pos +1]);
416
+        } elseif (isset($argv[$pos + 1])) {
417
+            $this->dir = $argv[$pos + 1];
418
+            unset($argv[$pos + 1]);
419 419
         }
420 420
         unset($argv[$pos]);
421 421
         // Make adjustments if '--load-from' points at a file.
Please login to merge, or discard this patch.
Doc Comments   +8 added lines, -4 removed lines patch added patch discarded remove patch
@@ -79,6 +79,9 @@  discard block
 block discarded – undo
79 79
         $this->dir = getcwd();
80 80
     }
81 81
 
82
+    /**
83
+     * @param string $errorType
84
+     */
82 85
     protected function errorCondition($msg, $errorType)
83 86
     {
84 87
         $this->errorConditions[$msg] = $errorType;
@@ -126,7 +129,7 @@  discard block
 block discarded – undo
126 129
     }
127 130
 
128 131
     /**
129
-     * @param array $argv
132
+     * @param string[] $argv
130 133
      * @param null|string $appName
131 134
      * @param null|string $appVersion
132 135
      * @param null|\Symfony\Component\Console\Output\OutputInterface $output
@@ -147,6 +150,7 @@  discard block
 block discarded – undo
147 150
 
148 151
     /**
149 152
      * Get a list of locations where config files may be loaded
153
+     * @param string $userConfig
150 154
      * @return string[]
151 155
      */
152 156
     protected function getConfigFilePaths($userConfig)
@@ -162,7 +166,7 @@  discard block
 block discarded – undo
162 166
      * @param null|\Symfony\Component\Console\Input\InputInterface $input
163 167
      * @param null|\Symfony\Component\Console\Output\OutputInterface $output
164 168
      * @param null|\Robo\Application $app
165
-     * @param array[] $commandFiles
169
+     * @param null|string $commandFiles
166 170
      * @param null|ClassLoader $classLoader
167 171
      *
168 172
      * @return int
@@ -258,9 +262,9 @@  discard block
 block discarded – undo
258 262
     }
259 263
 
260 264
     /**
261
-     * @param $relativeNamespace
265
+     * @param string $relativeNamespace
262 266
      *
263
-     * @return array|string[]
267
+     * @return string[]
264 268
      */
265 269
     protected function discoverCommandClasses($relativeNamespace)
266 270
     {
Please login to merge, or discard this patch.
examples/src/Robo/Plugin/Commands/ExampleCommands.php 3 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -348,6 +348,9 @@
 block discarded – undo
348 348
 {
349 349
     protected $message;
350 350
 
351
+    /**
352
+     * @param string $message
353
+     */
351 354
     public function __construct($message)
352 355
     {
353 356
         $this->message = $message;
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 namespace RoboExample\Robo\Plugin\Commands;
3 3
 
4 4
 use Robo\Result;
5
-
6 5
 use Consolidation\AnnotatedCommand\CommandData;
7 6
 use Consolidation\OutputFormatters\Options\FormatterOptions;
8 7
 use Consolidation\OutputFormatters\StructuredData\RowsOfFields;
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
      */
30 30
     public function tryWatch()
31 31
     {
32
-        $this->taskWatch()->monitor(['composer.json', 'composer.lock'], function () {
32
+        $this->taskWatch()->monitor(['composer.json', 'composer.lock'], function() {
33 33
             $this->taskComposerUpdate()->run();
34 34
         })->run();
35 35
     }
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->say('The <b>expression</b> <bogus>is</bogus> <info>a < b</> it even works');
43 43
         $answer = $this->ask('how are you?');
44
-        $this->say('You are '.$answer);
44
+        $this->say('You are ' . $answer);
45 45
         $yes = $this->confirm('Do you want one more question?');
46 46
         if (!$yes) {
47 47
             return Result::cancelled();
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
         $lang = $this->askDefault('what is your favorite scripting language?', 'PHP');
50 50
         $this->say($lang);
51 51
         $pin = $this->askHidden('Ok, now tell your PIN code (it is hidden)');
52
-        $this->yell('Ha-ha, your pin code is: '.$pin);
52
+        $this->yell('Ha-ha, your pin code is: ' . $pin);
53 53
         $this->say('Bye!');
54 54
     }
55 55
 
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
         // using yaml or json output formats.
174 174
         $data->addRendererFunction(
175 175
             // n.b. There is a fourth parameter $rowData that may be added here.
176
-            function ($key, $cellData, FormatterOptions $options) {
176
+            function($key, $cellData, FormatterOptions $options) {
177 177
                 if ($key == 'name') {
178 178
                     return "<info>$cellData</>";
179 179
                 }
@@ -203,10 +203,10 @@  discard block
 block discarded – undo
203 203
     public function tryFormatters($somthing = 'default', $options = ['format' => 'table', 'fields' => ''])
204 204
     {
205 205
         $outputData = [
206
-            'en' => [ 'first' => 'One',  'second' => 'Two',  'third' => 'Three' ],
207
-            'de' => [ 'first' => 'Eins', 'second' => 'Zwei', 'third' => 'Drei'  ],
208
-            'jp' => [ 'first' => 'Ichi', 'second' => 'Ni',   'third' => 'San'   ],
209
-            'es' => [ 'first' => 'Uno',  'second' => 'Dos',  'third' => 'Tres'  ],
206
+            'en' => ['first' => 'One', 'second' => 'Two', 'third' => 'Three'],
207
+            'de' => ['first' => 'Eins', 'second' => 'Zwei', 'third' => 'Drei'],
208
+            'jp' => ['first' => 'Ichi', 'second' => 'Ni', 'third' => 'San'],
209
+            'es' => ['first' => 'Uno', 'second' => 'Dos', 'third' => 'Tres'],
210 210
         ];
211 211
         return new RowsOfFields($outputData);
212 212
     }
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
     public function alterFormatters($result, CommandData $commandData)
242 242
     {
243 243
         if ($commandData->input()->getOption('french')) {
244
-            $result['fr'] = [ 'first' => 'Un',  'second' => 'Deux',  'third' => 'Trois'  ];
244
+            $result['fr'] = ['first' => 'Un', 'second' => 'Deux', 'third' => 'Trois'];
245 245
         }
246 246
 
247 247
         return $result;
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
             ->taskForEach($processList)
397 397
                 ->iterationMessage('Processing {value}')
398 398
                 ->call(
399
-                    function ($value) use($delay) {
399
+                    function($value) use($delay) {
400 400
                         // TaskForEach::call should only be used to do
401 401
                         // non-Robo operations. To use Robo tasks in an
402 402
                         // iterator, @see TaskForEach::withBuilder.
@@ -418,7 +418,7 @@  discard block
 block discarded – undo
418 418
             ->taskCleanDir($workdir)
419 419
             ->taskForEach($processList)
420 420
                 ->withBuilder(
421
-                    function ($builder, $key, $value) use ($workdir) {
421
+                    function($builder, $key, $value) use ($workdir) {
422 422
                         return $builder
423 423
                             ->taskFilesystemStack()
424 424
                                 ->mkdir("$workdir/$value");
Please login to merge, or discard this patch.
src/Config/Config.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -45,6 +45,7 @@
 block discarded – undo
45 45
 
46 46
     /**
47 47
      * {@inheritdoc}
48
+     * @param string $name
48 49
      */
49 50
     public function addContext($name, ConfigInterface $config)
50 51
     {
Please login to merge, or discard this patch.