AAA_RunnerErrorTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	_before()	0	4	1
A	testHandleError()	0	10	1
B	testErrorIsHandled()	0	34	1

<?php
use Robo\Robo;

use Robo\Config\ConfigProcessor;
use Robo\Config\YamlConfigLoader;

/**
 * This test must run first. :(
 */
class AAA_RunnerErrorTest extends \Codeception\TestCase\Test

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var \Robo\Runner
     */
    private $runner;

    /**
     * @var \CodeGuy
     */
    protected $guy;

    public function _before()
    {
        $this->runner = new \Robo\Runner('\Robo\RoboFileFixture');
    }

    public function testHandleError()
    {
        $tmpLevel = error_reporting();

        $this->assertFalse($this->runner->handleError());
        error_reporting(0);
        $this->assertTrue($this->runner->handleError());

        error_reporting($tmpLevel);
    }

    public function testErrorIsHandled()
    {
        $tmpLevel = error_reporting();

        // Set error_get_last to a known state.  Note that it can never be
        // reset; see http://php.net/manual/en/function.error-get-last.php
        @trigger_error('control');

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        $error_description = error_get_last();
        $this->assertEquals('control', $error_description['message']);
        @trigger_error('');

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        $error_description = error_get_last();
        $this->assertEquals('', $error_description['message']);

        // Set error_reporting to a non-zero value.  In this instance,
        // 'trigger_error' would abort our test script, so we use
        // @trigger_error so that execution will continue.  With our
        // error handler in place, the value of error_get_last() does
        // not change.
        error_reporting(E_USER_ERROR);
        set_error_handler(array($this->runner, 'handleError'));
        @trigger_error('test error', E_USER_ERROR);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        $error_description = error_get_last();
        $this->assertEquals('', $error_description['message']);

        // Set error_reporting to zero.  Now, even 'trigger_error'
        // does not abort execution.  The value of error_get_last()
        // still does not change.
        error_reporting(0);
        trigger_error('test error 2', E_USER_ERROR);
        $error_description = error_get_last();
        $this->assertEquals('', $error_description['message']);

        error_reporting($tmpLevel);
    }
}