consolidation / robo

tests/cli/CopyDirRecursiveExcludeCept.php

Spacing +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 $I = new CliGuy($scenario);
 
 $I->wantTo('copy dir recursively with CopyDir task, but exclude a file');
-$I->amInPath(codecept_data_dir().'sandbox');
+$I->amInPath(codecept_data_dir() . 'sandbox');
 $I->seeDirFound('some/deeply/nested');
 $I->seeDirFound('some/deeply/nested2');
 $I->seeDirFound('some/deeply/nested3');

src/Task/Development/SemVer.php

Spacing +1 added lines, -1 removed lines

@@ -235,7 +235,7 @@
         }
 
         $this->version = array_intersect_key($matches, $this->version);
-        $this->version = array_map(function ($item) {
+        $this->version = array_map(function($item) {
             return $item[0];
         }, $this->version);
     }

src/Common/ConfigAwareTrait.php

Spacing +3 added lines, -3 removed lines

@@ -73,9 +73,9 @@
      */
     private static function getClassKey($key)
     {
-        $configPrefix = static::configPrefix();                            // task.
-        $configClass = static::configClassIdentifier(get_called_class());  // PARTIAL_NAMESPACE.CLASSNAME
-        $configPostFix = static::configPostfix();                          // .settings
+        $configPrefix = static::configPrefix(); // task.
+        $configClass = static::configClassIdentifier(get_called_class()); // PARTIAL_NAMESPACE.CLASSNAME
+        $configPostFix = static::configPostfix(); // .settings
 
         return sprintf('%s%s%s.%s', $configPrefix, $configClass, $configPostFix, $key);
     }

tests/unit/ConfigurationInjectionTest.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 use Robo\Robo;
-
 use Consolidation\Config\Loader\ConfigProcessor;
 use Consolidation\Config\Loader\YamlConfigLoader;
 

src/GlobalOptionsEventListener.php

Doc Comments +1 added lines, -1 removed lines

@@ -83,7 +83,7 @@
      * the input string contains no '=' character, then the value will be 'true'.
      *
      * @param string $value
-     * @return array
+     * @return boolean[]
      */
     protected function splitConfigKeyValue($value)
     {

src/SelfUpdateCommand.php

Spacing +7 added lines, -7 removed lines

@@ -55,7 +55,7 @@ 
             'http' => [
                 'method' => 'GET',
                 'header' => [
-                    'User-Agent: ' . $this->applicationName  . ' (' . $this->gitHubRepository . ')' . ' Self-Update (PHP)'
+                    'User-Agent: ' . $this->applicationName . ' (' . $this->gitHubRepository . ')' . ' Self-Update (PHP)'
                 ]
             ]
         ];
@@ -65,14 +65,14 @@ 
         $releases = file_get_contents('https://api.github.com/repos/' . $this->gitHubRepository . '/releases', false, $context);
         $releases = json_decode($releases);
 
-        if (! isset($releases[0])) {
+        if (!isset($releases[0])) {
             throw new \Exception('API error - no release found at GitHub repository ' . $this->gitHubRepository);
         }
 
         $version = $releases[0]->tag_name;
         $url     = $releases[0]->assets[0]->browser_download_url;
 
-        return [ $version, $url ];
+        return [$version, $url];
     }
 
     /**
@@ -89,20 +89,20 @@ 
         $tempFilename  = dirname($localFilename) . '/' . basename($localFilename, '.phar') . '-temp.phar';
 
         // check for permissions in local filesystem before start connection process
-        if (! is_writable($tempDirectory = dirname($tempFilename))) {
+        if (!is_writable($tempDirectory = dirname($tempFilename))) {
             throw new \Exception(
                 $programName . ' update failed: the "' . $tempDirectory .
                 '" directory used to download the temp file could not be written'
             );
         }
 
-        if (! is_writable($localFilename)) {
+        if (!is_writable($localFilename)) {
             throw new \Exception(
                 $programName . ' update failed: the "' . $localFilename . '" file could not be written (execute with sudo)'
             );
         }
 
-        list( $latest, $downloadUrl ) = $this->getLatestReleaseFromGithub();
+        list($latest, $downloadUrl) = $this->getLatestReleaseFromGithub();
 
 
         if ($this->currentVersion == $latest) {
@@ -131,7 +131,7 @@ 
             $this->_exit();
         } catch (\Exception $e) {
             @unlink($tempFilename);
-            if (! $e instanceof \UnexpectedValueException && ! $e instanceof \PharException) {
+            if (!$e instanceof \UnexpectedValueException && !$e instanceof \PharException) {
                 throw $e;
             }
             $output->writeln('<error>The download is corrupted (' . $e->getMessage() . ').</error>');

Doc Comments +5 added lines

@@ -22,6 +22,11 @@
 
     protected $applicationName;
 
+    /**
+     * @param string $applicationName
+     * @param string $currentVersion
+     * @param string $gitHubRepository
+     */
     public function __construct($applicationName = null, $currentVersion = null, $gitHubRepository = null)
     {
         $this->applicationName = $applicationName;

src/Common/ProcessUtils.php

Unused Use Statements -2 removed lines

@@ -7,8 +7,6 @@
 
 namespace Robo\Common;
 
-use Symfony\Component\Process\Exception\InvalidArgumentException;
-
 /**
  * ProcessUtils is a bunch of utility methods. We want to allow Robo 1.x
  * to work with Symfony 4.x while remaining backwards compatibility. This

Doc Comments +3 added lines

@@ -72,6 +72,9 @@
         return "'".str_replace("'", "'\\''", $argument)."'";
     }
 
+    /**
+     * @param string $char
+     */
     private static function isSurroundedBy($arg, $char)
     {
         return 2 < strlen($arg) && $char === $arg[0] && $char === $arg[strlen($arg) - 1];

Spacing +4 added lines, -4 removed lines

@@ -34,7 +34,7 @@ 
      */
     public static function escapeArgument($argument)
     {
-        @trigger_error('The '.__METHOD__.'() method is a copy of a method that was deprecated by Symfony 3.3 and removed in Symfony 4; it will be removed in Robo 2.0.', E_USER_DEPRECATED);
+        @trigger_error('The ' . __METHOD__ . '() method is a copy of a method that was deprecated by Symfony 3.3 and removed in Symfony 4; it will be removed in Robo 2.0.', E_USER_DEPRECATED);
 
         //Fix for PHP bug #43784 escapeshellarg removes % from given string
         //Fix for PHP bug #49446 escapeshellarg doesn't work on Windows
@@ -52,7 +52,7 @@ 
                     $escapedArgument .= '\\"';
                 } elseif (self::isSurroundedBy($part, '%')) {
                     // Avoid environment variable expansion
-                    $escapedArgument .= '^%"'.substr($part, 1, -1).'"^%';
+                    $escapedArgument .= '^%"' . substr($part, 1, -1) . '"^%';
                 } else {
                     // escape trailing backslash
                     if ('\\' === substr($part, -1)) {
@@ -63,13 +63,13 @@ 
                 }
             }
             if ($quote) {
-                $escapedArgument = '"'.$escapedArgument.'"';
+                $escapedArgument = '"' . $escapedArgument . '"';
             }
 
             return $escapedArgument;
         }
 
-        return "'".str_replace("'", "'\\''", $argument)."'";
+        return "'" . str_replace("'", "'\\''", $argument) . "'";
     }
 
     private static function isSurroundedBy($arg, $char)

tests/cli/ForEachCest.php

Spacing +7 added lines, -7 removed lines

@@ -41,8 +41,8 @@ 
         $I->wantTo('set iterable in the __constructor');
         $I
             ->taskForEach($example['items'])
-            ->withBuilder(function (CollectionBuilder $builder, $key, $value) use (&$actual) {
-                $builder->addCode(function () use ($key, $value, &$actual) {
+            ->withBuilder(function(CollectionBuilder $builder, $key, $value) use (&$actual) {
+                $builder->addCode(function() use ($key, $value, &$actual) {
                     $actual[] = "$key = $value";
 
                     return 0;
@@ -63,7 +63,7 @@ 
         $I->wantTo('set iterable with deferTaskConfiguration()');
         $I
             ->collectionBuilder()
-            ->addCode(function (Data $data) use ($example) {
+            ->addCode(function(Data $data) use ($example) {
                 $data['items'] = $example['items'];
 
                 return 0;
@@ -72,8 +72,8 @@ 
                 $I
                     ->taskForEach()
                     ->deferTaskConfiguration('setIterable', 'items')
-                    ->withBuilder(function (CollectionBuilder $builder, $key, $value) use (&$actual) {
-                        $builder->addCode(function () use ($key, $value, &$actual) {
+                    ->withBuilder(function(CollectionBuilder $builder, $key, $value) use (&$actual) {
+                        $builder->addCode(function() use ($key, $value, &$actual) {
                             $actual[] = "$key = $value";
 
                             return 0;
@@ -91,8 +91,8 @@ 
         $I->wantTo('call the __constructor() without argument');
         $I
             ->taskForEach()
-            ->withBuilder(function (CollectionBuilder $builder, $key, $value) use (&$actual) {
-                $builder->addCode(function () use ($key, $value, &$actual) {
+            ->withBuilder(function(CollectionBuilder $builder, $key, $value) use (&$actual) {
+                $builder->addCode(function() use ($key, $value, &$actual) {
                     $actual++;
 
                     return 0;

src/ClassDiscovery/RelativeNamespaceDiscovery.php

Indentation +2 added lines, -2 removed lines

@@ -91,8 +91,8 @@
     {
         $finder = new Finder();
         $finder->files()
-          ->name($pattern)
-          ->in($directories);
+            ->name($pattern)
+            ->in($directories);
 
         return $finder;
     }

Doc Comments +5 added lines, -3 removed lines

@@ -62,6 +62,7 @@ 
 
     /**
      * {@inheritdoc}
+     * @param string $class
      */
     public function getFile($class)
     {
@@ -70,7 +71,7 @@ 
 
     /**
      * @param $directories
-     * @param $pattern
+     * @param string $pattern
      *
      * @return \Symfony\Component\Finder\Finder
      */
@@ -85,9 +86,9 @@ 
     }
 
     /**
-     * @param $path
+     * @param string $path
      *
-     * @return mixed
+     * @return string
      */
     protected function convertPathToNamespace($path)
     {
@@ -95,6 +96,7 @@ 
     }
 
     /**
+     * @param string $namespace
      * @return string
      */
     public function convertNamespaceToPath($namespace)

Spacing +4 added lines, -4 removed lines

@@ -53,14 +53,14 @@ 
         $relativePath = $this->convertNamespaceToPath($this->relativeNamespace);
 
         foreach ($this->classLoader->getPrefixesPsr4() as $baseNamespace => $directories) {
-            $directories = array_filter(array_map(function ($directory) use ($relativePath) {
-                return $directory.$relativePath;
+            $directories = array_filter(array_map(function($directory) use ($relativePath) {
+                return $directory . $relativePath;
             }, $directories), 'is_dir');
 
             if ($directories) {
                 foreach ($this->search($directories, $this->searchPattern) as $file) {
                     $relativePathName = $file->getRelativePathname();
-                    $classes[] = $baseNamespace.$this->convertPathToNamespace($relativePath.'/'.$relativePathName);
+                    $classes[] = $baseNamespace . $this->convertPathToNamespace($relativePath . '/' . $relativePathName);
                 }
             }
         }
@@ -107,6 +107,6 @@ 
      */
     public function convertNamespaceToPath($namespace)
     {
-        return '/'.str_replace("\\", '/', trim($namespace, '\\'));
+        return '/' . str_replace("\\", '/', trim($namespace, '\\'));
     }
 }