Robo\Common\ExecTrait

Complexity

Total Complexity

40

Size/Duplication

Total Lines	352
Duplicated Lines	3.98 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

20 Methods

Rating	Name	Duplication	Size	Complexity
A	detectInteractive()	0	6	3
A	background()	0	5	1
A	timeout()	0	5	1
A	idleTimeout()	0	5	1
A	env()	0	5	1
A	setInput()	0	5	1
A	interactive()	0	5	1
A	getPrinted()	0	4	1
A	dir()	0	5	1
A	silent()	0	8	2
A	printed()	0	5	1
A	printOutput()	0	7	2
A	printMetadata()	0	7	2
A	__destruct()	0	6	2
A	run()	0	4	1
A	getCommand()	0	4	1
C	execute()	14	55	11
A	stop()	0	10	3
A	printAction()	0	9	2
A	getResultData()	0	8	2

<?php

namespace Robo\Common;

use Psr\Log\LoggerAwareTrait;
use Robo\Result;
use Symfony\Component\Process\Process;

/**
 * Class ExecTrait
 * @package Robo\Common
 */
trait ExecTrait
{
    /**
     * @var bool
     */
    protected $background = false;

    /**
     * @var null|int
     */
    protected $timeout = null;

    /**
     * @var null|int
     */
    protected $idleTimeout = null;

    /**
     * @var null|array
     */
    protected $env = null;

    /**
     * @var Process
     */
    protected $process;

    /**
     * @var resource|string
     */
    protected $input;

    /**
     * @var boolean
     */
    protected $interactive = false;

    /**
     * @var bool
     */
    protected $isPrinted = true;

    /**
     * @var bool
     */
    protected $isMetadataPrinted = true;

    /**
     * @var string
     */
    protected $workingDirectory;

    /**
     * @return string
     */
    public function getCommand()
    {
        return $this->command;

The property command does not exist. Did you maybe forget to declare it?

    }
    /**
     * Sets $this->interactive() based on posix_isatty().
     */
    public function detectInteractive()
    {
        if (!isset($this->interactive) && function_exists('posix_isatty')) {
            $this->interactive = posix_isatty(STDOUT);
        }
    }

    /**
     * Executes command in background mode (asynchronously)
     *
     * @return $this
     */
    public function background($arg = true)
    {
        $this->background = $arg;
        return $this;
    }

    /**
     * Stop command if it runs longer then $timeout in seconds
     *
     * @param int $timeout
     *
     * @return $this
     */
    public function timeout($timeout)
    {
        $this->timeout = $timeout;
        return $this;
    }

    /**
     * Stops command if it does not output something for a while
     *
     * @param int $timeout
     *
     * @return $this
     */
    public function idleTimeout($timeout)
    {
        $this->idleTimeout = $timeout;
        return $this;
    }

    /**
     * Sets the environment variables for the command
     *
     * @param array $env
     *
     * @return $this
     */
    public function env(array $env)
    {
        $this->env = $env;
        return $this;
    }

    /**
     * Pass an input to the process. Can be resource created with fopen() or string
     *
     * @param resource|string $input
     *
     * @return $this
     */
    public function setInput($input)
    {
        $this->input = $input;
        return $this;
    }

    /**
     * Attach tty to process for interactive input
     *
     * @param $interactive bool
     *
     * @return $this
     */
    public function interactive($interactive)
    {
        $this->interactive = $interactive;
        return $this;
    }


    /**
     * Is command printing its output to screen
     *
     * @return bool
     */
    public function getPrinted()
    {
        return $this->isPrinted;
    }

    /**
     * Changes working directory of command
     *
     * @param string $dir
     *
     * @return $this
     */
    public function dir($dir)
    {
        $this->workingDirectory = $dir;
        return $this;
    }

    /**
     * Shortcut for setting isPrinted() and isMetadataPrinted() to false.
     *
     * @param bool $arg
     *
     * @return $this
     */
    public function silent($arg)
    {
        if (is_bool($arg)) {
            $this->isPrinted = !$arg;
            $this->isMetadataPrinted = !$arg;
        }
        return $this;
    }

    /**
     * Should command output be printed
     *
     * @param bool $arg
     *
     * @return $this
     *
     * @deprecated
     */
    public function printed($arg)
    {
        $this->logger->warning("printed() is deprecated. Please use printOutput().");

The property logger does not exist. Did you maybe forget to declare it?

        return $this->printOutput($arg);
    }

    /**
     * Should command output be printed
     *
     * @param bool $arg
     *
     * @return $this
     */
    public function printOutput($arg)
    {
        if (is_bool($arg)) {
            $this->isPrinted = $arg;
        }
        return $this;
    }

    /**
     * Should command metadata be printed. I,e., command and timer.
     *
     * @param bool $arg
     *
     * @return $this
     */
    public function printMetadata($arg)
    {
        if (is_bool($arg)) {
            $this->isMetadataPrinted = $arg;
        }
        return $this;
    }

    /**
     *
     */
    public function __destruct()
    {
        if (!$this->background()) {
            $this->stop();
        }
    }

    /**
     * {@inheritdoc}
     */
    public function run()
    {
        return $this->execute($this->getCommand());
    }

    /**
     * @param string $command
     * @param callable $output_callback
     *
     * @return \Robo\Result
     */
    protected function execute($command, $output_callback = null)
    {
        if (!$output_callback) {
            $output_callback = function ($type, $buffer) {
                print($buffer);
            };
        }

        if ($this->isMetadataPrinted) {
            $this->printAction();
        }
        $this->process = new Process($command);
        $this->process->setTimeout($this->timeout);
        $this->process->setIdleTimeout($this->idleTimeout);
        $this->process->setWorkingDirectory($this->workingDirectory);

        if ($this->input) {
            $this->process->setInput($this->input);
        }

        if ($this->interactive) {
            $this->process->setTty(true);
        }

        if (isset($this->env)) {
            $this->process->setEnv($this->env);
        }

        if (!$this->background and !$this->isPrinted) {

This code seems to be duplicated across your project.

Using logical operators such as and instead of && is generally not recommended.

            $this->startTimer();

It seems like startTimer() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->process->run();
            $this->stopTimer();

It seems like stopTimer() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return new Result($this, $this->process->getExitCode(),
                $this->process->getOutput(), $this->getResultData());
        }

        if (!$this->background and $this->isPrinted) {

This code seems to be duplicated across your project.

Using logical operators such as and instead of && is generally not recommended.

            $this->startTimer();

It seems like startTimer() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->process->run($output_callback);
            $this->stopTimer();

It seems like stopTimer() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return new Result(
                $this,
                $this->process->getExitCode(),
                $this->process->getOutput(),
                $this->getResultData()
            );
        }

        try {
            $this->process->start();
        } catch (\Exception $e) {
            return Result::fromException($this, $e);
        }
        return Result::success($this);
    }

    /**
     *
     */
    protected function stop()
    {
        if ($this->background && $this->process->isRunning()) {
            $this->process->stop();
            $this->printTaskInfo(

It seems like printTaskInfo() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                "Stopped {command}",
                ['command' => $this->getCommand()]
            );
        }
    }

    /**
     * @param array $context
     */
    protected function printAction($context = [])
    {
        $command = $this->getCommand();
        $dir = $this->workingDirectory ? " in {dir}" : "";
        $this->printTaskInfo("Running {command}$dir", [

It seems like printTaskInfo() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                'command' => $command,
                'dir' => $this->workingDirectory
            ] + $context);
    }

    /**
     * Gets the data array to be passed to Result().
     *
     * @return array
     *   The data array passed to Result().
     */
    protected function getResultData()
    {
        if ($this->isMetadataPrinted) {
            return ['time' => $this->getExecutionTime()];

It seems like getExecutionTime() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return [];
    }
}