consolidation / robo

src/Runner.php

Spacing +5 added lines, -5 removed lines

@@ -44,7 +44,7 @@ 
     public function __construct($roboClass = null, $roboFile = null)
     {
         // set the const as class properties to allow overwriting in child classes
-        $this->roboClass = $roboClass ? $roboClass : self::ROBOCLASS ;
+        $this->roboClass = $roboClass ? $roboClass : self::ROBOCLASS;
         $this->roboFile  = $roboFile ? $roboFile : self::ROBOFILE;
         $this->dir = getcwd();
     }
@@ -79,7 +79,7 @@ 
         require_once $roboFilePath;
 
         if (!class_exists($this->roboClass)) {
-            $output->writeln("<error>Class ".$this->roboClass." was not loaded</error>");
+            $output->writeln("<error>Class " . $this->roboClass . " was not loaded</error>");
             return false;
         }
         return true;
@@ -298,9 +298,9 @@ 
 
         if (substr($argv[$pos], 0, 12) == '--load-from=') {
             $this->dir = substr($argv[$pos], 12);
-        } elseif (isset($argv[$pos +1])) {
-            $this->dir = $argv[$pos +1];
-            unset($argv[$pos +1]);
+        } elseif (isset($argv[$pos + 1])) {
+            $this->dir = $argv[$pos + 1];
+            unset($argv[$pos + 1]);
         }
         unset($argv[$pos]);
         // Make adjustments if '--load-from' points at a file.

Doc Comments +2 added lines, -2 removed lines

@@ -92,7 +92,7 @@ 
     }
 
     /**
-     * @param array $argv
+     * @param string[] $argv
      * @param null|string $appName
      * @param null|string $appVersion
      * @param null|\Symfony\Component\Console\Output\OutputInterface $output
@@ -115,7 +115,7 @@ 
      * @param null|\Symfony\Component\Console\Input\InputInterface $input
      * @param null|\Symfony\Component\Console\Output\OutputInterface $output
      * @param null|\Robo\Application $app
-     * @param array[] $commandFiles
+     * @param null|string $commandFiles
      *
      * @return int
      */

Unused Use Statements -3 removed lines

@@ -1,15 +1,12 @@
 <?php
 namespace Robo;
 
-use League\Container\Container;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\ArgvInput;
 use Symfony\Component\Console\Input\StringInput;
-use Consolidation\AnnotatedCommand\PassThroughArgsInput;
 use Robo\Contract\BuilderAwareInterface;
 use Robo\Common\IO;
 use Robo\Exception\TaskExitException;
-use League\Container\ContainerInterface;
 use League\Container\ContainerAwareInterface;
 use League\Container\ContainerAwareTrait;
 

src/Collection/CollectionBuilder.php

Doc Comments +1 added lines, -1 removed lines

@@ -362,7 +362,7 @@
      * @param InflectionInterface $task
      * @param array $args
      *
-     * @return \Robo\Collection\CompletionWrapper|\Robo\Task\Simulator
+     * @return TaskInterface
      */
     protected function fixTask($task, $args)
     {

Unused Use Statements -5 removed lines

@@ -1,9 +1,7 @@ 
 <?php
 namespace Robo\Collection;
 
-use Guzzle\Inflection\InflectorInterface;
 use Robo\Config;
-use Robo\Common\Timer;
 use Psr\Log\LogLevel;
 use Robo\Contract\InflectionInterface;
 use Robo\Contract\TaskInterface;
@@ -14,13 +12,10 @@ 
 use Robo\Task\Simulator;
 use Robo\Collection\CompletionWrapper;
 use Robo\Collection\Temporary;
-use Robo\Contract\ConfigAwareInterface;
-use Robo\Common\ConfigAwareTrait;
 use ReflectionClass;
 use Robo\Task\BaseTask;
 use Robo\Contract\BuilderAwareInterface;
 use Robo\Contract\CommandInterface;
-use Robo\Exception\TaskException;
 
 /**
  * Creates a collection, and adds tasks to it.  The collection builder

src/Collection/CollectionInterface.php

Doc Comments +7 added lines, -7 removed lines

@@ -25,7 +25,7 @@ 
      *
      * @param TaskInterface $task
      *   The task to add to our collection.
-     * @param int|string $name
+     * @param integer $name
      *   An optional name for the task -- missing or UNNAMEDTASK for unnamed tasks.
      *   Names are used for positioning before and after tasks.
      *
@@ -37,7 +37,7 @@ 
      * Add arbitrary code to execute as a task.
      *
      * @param callable $code Code to execute as a task
-     * @param int|string $name
+     * @param integer $name
      *   An optional name for the task -- missing or UNNAMEDTASK for unnamed tasks.
      *   Names are used for positioning before and after tasks.
      *
@@ -109,9 +109,9 @@ 
      *
      * @param string $name
      *   The name of the task to insert before.  The named task MUST exist.
-     * @param callable|TaskInterface $task
+     * @param callable $task
      *   The task to add.
-     * @param int|string $nameOfTaskToAdd
+     * @param integer $nameOfTaskToAdd
      *   The name of the task to add. If not provided, will be associated
      *   with the named task it was added before.
      *
@@ -124,9 +124,9 @@ 
      *
      * @param string $name
      *   The name of the task to insert before.  The named task MUST exist.
-     * @param callable|TaskInterface $task
+     * @param callable $task
      *   The task to add.
-     * @param int|string $nameOfTaskToAdd
+     * @param integer $nameOfTaskToAdd
      *   The name of the task to add. If not provided, will be associated
      *   with the named task it was added after.
      *
@@ -142,7 +142,7 @@ 
      *
      * @param string $text Message to print.
      * @param array $context Extra context data for use by the logger.
-     * @param \Psr\Log\LogLevel|string $level The log level to print the information at. Default is NOTICE.
+     * @param string $level The log level to print the information at. Default is NOTICE.
      *
      * @return $this
      */

src/Common/ResourceExistenceChecker.php

Doc Comments +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
      * @param string $resource File or folder.
      * @param string $type "file", "dir", "fileAndDir"
      *
-     * @return bool
+     * @return boolean|null
      */
     protected function checkResource($resource, $type)
     {

Indentation +14 added lines, -14 removed lines

@@ -90,25 +90,25 @@
         $this->checkResources($targets);
     }
 
-   /**
-    * Wrapper method around phps is_dir()
-    *
-    * @param string $directory
-    *
-    * @return bool
-    */
+    /**
+     * Wrapper method around phps is_dir()
+     *
+     * @param string $directory
+     *
+     * @return bool
+     */
     protected function isDir($directory)
     {
         return is_dir($directory);
     }
 
-   /**
-    * Wrapper method around phps file_exists()
-    *
-    * @param string $file
-    *
-    * @return bool
-    */
+    /**
+     * Wrapper method around phps file_exists()
+     *
+     * @param string $file
+     *
+     * @return bool
+     */
     protected function isFile($file)
     {
         return file_exists($file);

src/Common/TaskIO.php

Doc Comments +1 added lines, -1 removed lines

@@ -167,7 +167,7 @@
     }
 
     /**
-     * @param $inProgress
+     * @param boolean $inProgress
      */
     protected function showTaskProgress($inProgress)
     {

src/Task/ApiGen/ApiGen.php

Doc Comments +5 added lines, -5 removed lines

@@ -119,7 +119,7 @@ 
     }
 
     /**
-     * @param array|string|Traversable $src one or more source values
+     * @param string $src one or more source values
      *
      * @return $this
      */
@@ -143,7 +143,7 @@ 
     }
 
     /**
-     * @param array|string $exts one or more extensions
+     * @param string $exts one or more extensions
      *
      * @return $this
      */
@@ -154,7 +154,7 @@ 
     }
 
     /**
-     * @param array|string $exclude one or more exclusions
+     * @param string[] $exclude one or more exclusions
      *
      * @return $this
      */
@@ -167,7 +167,7 @@ 
     }
 
     /**
-     * @param array|string|Traversable $path one or more skip-doc-path values
+     * @param \SplDoublyLinkedList $path one or more skip-doc-path values
      *
      * @return $this
      */
@@ -193,7 +193,7 @@ 
     }
 
     /**
-     * @param array|string $charset one or more charsets
+     * @param string[] $charset one or more charsets
      *
      * @return $this
      */

src/Task/Base/loadTasks.php

Doc Comments +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
 trait loadTasks
 {
     /**
-     * @param string|\Robo\Contract\CommandInterface $command
+     * @param string $command
      *
      * @return Exec
      */

src/Task/Docker/Run.php

Doc Comments +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
     }
 
     /**
-     * @param string|\Robo\Contract\CommandInterface $run
+     * @param string $run
      *
      * @return $this
      */

src/Task/Filesystem/FilesystemStack.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 use Robo\Result;
 use Robo\Task\StackBasedTask;
 use Symfony\Component\Filesystem\Filesystem as sfFilesystem;
-use Symfony\Component\Filesystem\Exception\IOExceptionInterface;
 use Symfony\Component\Filesystem\Exception\IOException;
 use Robo\Contract\BuilderAwareInterface;
 use Robo\Common\BuilderAwareTrait;