consolidation / robo

tests/unit/Common/ResourceExistenceChecker.php

Unused Use Statements -2 removed lines

@@ -1,7 +1,5 @@
 <?php
 use Robo\Common\ResourceExistenceChecker;
-use Robo\Result;
-use Robo\Task\BaseTask;
 
 class ResourceExistenceCheckerTest extends \Codeception\TestCase\Test
 {

tests/unit/RunnerTest.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 use Robo\Robo;
-use Symfony\Component\Console\Output\BufferedOutput;
 
 class RunnerTest extends \Codeception\TestCase\Test
 {

tests/unit/Task/CollectionTest.php

Doc Comments +4 added lines

@@ -145,6 +145,10 @@
     protected $key;
     protected $value;
 
+    /**
+     * @param string $key
+     * @param string $value
+     */
     public function __construct($key, $value)
     {
         $this->key = $key;

Unused Use Statements -2 removed lines

@@ -8,9 +8,7 @@
 
 use Robo\Result;
 use Robo\Task\BaseTask;
-use Robo\Contract\TaskInterface;
 use Robo\Collection\Collection;
-use Robo\Robo;
 
 class CollectionTest extends \Codeception\TestCase\Test
 {

Spacing +2 added lines, -2 removed lines

@@ -103,11 +103,11 @@
             ->completion($completion1)
             ->rollbackCode(function() use($rollback1) { $rollback1->run(); } )
             ->completionCode(function() use($completion1) { $completion1->run(); } )
-            ->addCode(function () { return 42; })
+            ->addCode(function() { return 42; })
             ->progressMessage("not reached")
             ->rollback($rollback2)
             ->completion($completion2)
-            ->addCode(function () { return 13; });
+            ->addCode(function() { return 13; });
 
         $collection->setLogger($this->guy->logger());
 

tests/unit/Task/GulpTest.php

Doc Comments +3 added lines

@@ -16,6 +16,9 @@
         ]);
     }
 
+    /**
+     * @param string $expected
+     */
     protected function adjustQuotes($expected)
     {
         $isWindows = defined('PHP_WINDOWS_VERSION_MAJOR');

Spacing +9 added lines, -9 removed lines

@@ -30,27 +30,27 @@ 
     public function testGulpGetCommand()
     {
         verify(
-            (new \Robo\Task\Gulp\Run('default','gulp'))->getCommand()
+            (new \Robo\Task\Gulp\Run('default', 'gulp'))->getCommand()
         )->equals($this->adjustQuotes('gulp "default"'));
 
         verify(
-            (new \Robo\Task\Gulp\Run('another','gulp'))->getCommand()
+            (new \Robo\Task\Gulp\Run('another', 'gulp'))->getCommand()
         )->equals($this->adjustQuotes('gulp "another"'));
 
         verify(
-            (new \Robo\Task\Gulp\Run('default','gulp'))->silent()->getCommand()
+            (new \Robo\Task\Gulp\Run('default', 'gulp'))->silent()->getCommand()
         )->equals($this->adjustQuotes('gulp "default" --silent'));
 
         verify(
-            (new \Robo\Task\Gulp\Run('default','gulp'))->noColor()->getCommand()
+            (new \Robo\Task\Gulp\Run('default', 'gulp'))->noColor()->getCommand()
         )->equals($this->adjustQuotes('gulp "default" --no-color'));
 
         verify(
-            (new \Robo\Task\Gulp\Run('default','gulp'))->color()->getCommand()
+            (new \Robo\Task\Gulp\Run('default', 'gulp'))->color()->getCommand()
         )->equals($this->adjustQuotes('gulp "default" --color'));
 
         verify(
-            (new \Robo\Task\Gulp\Run('default','gulp'))->simple()->getCommand()
+            (new \Robo\Task\Gulp\Run('default', 'gulp'))->simple()->getCommand()
         )->equals($this->adjustQuotes('gulp "default" --tasks-simple'));
     }
 
@@ -58,7 +58,7 @@ 
     {
         $gulp = test::double('Robo\Task\Gulp\Run', ['executeCommand' => null, 'getConfig' => new \Robo\Config(), 'logger' => new \Psr\Log\NullLogger()]);
 
-        $task = (new \Robo\Task\Gulp\Run('default','gulp'))->simple();
+        $task = (new \Robo\Task\Gulp\Run('default', 'gulp'))->simple();
         verify($task->getCommand())->equals($this->adjustQuotes('gulp "default" --tasks-simple'));
         $task->run();
         $gulp->verifyInvoked('executeCommand', [$this->adjustQuotes('gulp "default" --tasks-simple')]);
@@ -71,13 +71,13 @@ 
         if ($isWindows) {
 
             verify(
-                (new \Robo\Task\Gulp\Run('anotherWith weired!("\') Chars','gulp'))->getCommand()
+                (new \Robo\Task\Gulp\Run('anotherWith weired!("\') Chars', 'gulp'))->getCommand()
             )->equals('gulp "anotherWith weired!(\"\') Chars"');
 
         } else {
 
             verify(
-                (new \Robo\Task\Gulp\Run('anotherWith weired!("\') Chars','gulp'))->getCommand()
+                (new \Robo\Task\Gulp\Run('anotherWith weired!("\') Chars', 'gulp'))->getCommand()
             )->equals("gulp 'anotherWith weired!(\"'\\'') Chars'");
 
         }

tests/unit/Task/RsyncTest.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 
-use AspectMock\Test as test;
 use Robo\Robo;
 
 class RsyncTest extends \Codeception\TestCase\Test

tests/_helpers/CodeGuy.php

Indentation +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@
 {
     use _generated\CodeGuyActions;
 
-   /**
-    * Define custom actions here
-    */
+    /**
+     * Define custom actions here
+     */
 }

tests/unit/Task/ApiGenTest.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
             ->extensions('php') // single string value of List
             ->exclude(array('test', 'tmp')) // array value of Traversable
             ->skipDocPath($skippedPaths) // multi-value of Traversable
-            ->charset(array('utf8','iso88591')) // array of List
+            ->charset(array('utf8', 'iso88591')) // array of List
             ->internal('no') // boolean as supported "no"
             ->php(true) // boolean as boolean
             ->tree('Y') // boolean as string

tests/unit/Task/BowerTest.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
     // tests
     public function testBowerInstall()
     {
-        $bower = test::double('Robo\Task\Bower\Install', ['executeCommand' => null, 'logger' => new \Psr\Log\NullLogger(),]);
+        $bower = test::double('Robo\Task\Bower\Install', ['executeCommand' => null, 'logger' => new \Psr\Log\NullLogger(), ]);
         (new \Robo\Task\Bower\Install('bower'))->run();
         $bower->verifyInvoked('executeCommand', ['bower install']);
     }

tests/_data/parascript.php

Spacing +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 
 $message = $argv[1];
 $iterations = $argv[2];
-for ($i=0; $i < $iterations; ++$i) {
+for ($i = 0; $i < $iterations; ++$i) {
     print "$message\n";
     sleep(1);
 }