consolidation / robo

src/Log/ResultPrinter.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Robo\Contract\ProgressIndicatorAwareInterface;
 use Robo\Contract\VerbosityThresholdInterface;
 use Robo\Common\ProgressIndicatorAwareTrait;
-
 use Psr\Log\LogLevel;
 use Psr\Log\LoggerAwareInterface;
 use Psr\Log\LoggerAwareTrait;

src/Common/ExecTrait.php

Spacing +1 added lines, -1 removed lines

@@ -247,7 +247,7 @@
         $this->process = $process;
 
         if (!$output_callback) {
-            $output_callback = function ($type, $buffer) {
+            $output_callback = function($type, $buffer) {
                 $progressWasVisible = $this->hideTaskProgress();
                 $this->writeMessage($buffer);
                 $this->showTaskProgress($progressWasVisible);

src/Task/ApiGen/ApiGen.php

Spacing +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
         if (!is_array($args)) {
             $args = func_get_args();
         }
-        $args = array_map(function ($arg) {
+        $args = array_map(function($arg) {
             if (preg_match('/^\w+$/', trim($arg)) === 1) {
                 $this->operation = $arg;
                 return null;

Doc Comments +5 added lines, -5 removed lines

@@ -165,7 +165,7 @@ 
     }
 
     /**
-     * @param array|string|\Traversable $src
+     * @param string $src
      *   One or more source values.
      *
      * @return $this
@@ -190,7 +190,7 @@ 
     }
 
     /**
-     * @param array|string $exts
+     * @param string $exts
      *   One or more extensions.
      *
      * @return $this
@@ -202,7 +202,7 @@ 
     }
 
     /**
-     * @param array|string $exclude
+     * @param string[] $exclude
      *   One or more exclusions.
      *
      * @return $this
@@ -216,7 +216,7 @@ 
     }
 
     /**
-     * @param array|string|\Traversable $path
+     * @param \SplDoublyLinkedList $path
      *   One or more skip-doc-path values.
      *
      * @return $this
@@ -244,7 +244,7 @@ 
     }
 
     /**
-     * @param array|string $charset
+     * @param string[] $charset
      *   One or more charsets.
      *
      * @return $this

tests/src/RoboFileFixture.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Psr\Log\LoggerAwareTrait;
 use Psr\Log\LoggerAwareInterface;
-
 use Consolidation\AnnotatedCommand\Events\CustomEventAwareInterface;
 use Consolidation\AnnotatedCommand\Events\CustomEventAwareTrait;
 use Consolidation\OutputFormatters\StructuredData\PropertyList;

tests/_helpers/SeeInOutputTrait.php

Doc Comments +4 added lines

@@ -11,6 +11,9 @@ 
     protected $capturedOutput;
     protected $logger;
 
+    /**
+     * @param \League\Container\Container $container
+     */
     public function initSeeInOutputTrait($container, $input = null)
     {
         $this->capturedOutput = '';
@@ -65,6 +68,7 @@ 
     /**
      * Make our output comparisons more platform-agnostic by converting
      * CRLF (Windows) or raw CR (confused output) to a LF (unix/Mac).
+     * @param string $output
      */
     protected function simplify($output)
     {

tests/unit/Common/ResultDataTest.php

Spacing +2 added lines, -2 removed lines

@@ -33,8 +33,8 @@
         $a = new ResultData(ResultData::EXITCODE_OK, '', ['one' => 'first', 'two' => 'second']);
 
         $to_be_merged = [
-            ['one' => 'ignored',],
-            ['three' => 'new',],
+            ['one' => 'ignored', ],
+            ['three' => 'new', ],
         ];
 
         foreach ($to_be_merged as $mergeThis) {

src/Collection/Collection.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 use Robo\Exception\TaskException;
 use Robo\Exception\TaskExitException;
 use Robo\Contract\CommandInterface;
-
 use Robo\Contract\InflectionInterface;
 use Robo\State\StateAwareInterface;
 use Robo\State\StateAwareTrait;

Spacing +5 added lines, -5 removed lines

@@ -135,7 +135,7 @@ 
     {
         $collection = $this;
         $completionRegistrationTask = new CallableTask(
-            function () use ($collection, $completionTask) {
+            function() use ($collection, $completionTask) {
 
                 $collection->registerCompletion($completionTask);
             },
@@ -178,7 +178,7 @@ 
         $context += ['name' => 'Progress'];
         $context += TaskInfo::getTaskContext($this);
         return $this->addCode(
-            function () use ($level, $text, $context) {
+            function() use ($level, $text, $context) {
                 $context += $this->getState()->getData();
                 $this->printTaskOutput($level, $text, $context);
             }
@@ -194,7 +194,7 @@ 
     {
         $collection = $this;
         $rollbackRegistrationTask = new CallableTask(
-            function () use ($collection, $rollbackTask) {
+            function() use ($collection, $rollbackTask) {
                 $collection->registerRollback($rollbackTask);
             },
             $this
@@ -247,7 +247,7 @@ 
         if ($task instanceof StackBasedTask) {
             $task->stopOnFail(false);
         }
-        $ignoreErrorsInTask = function () use ($task) {
+        $ignoreErrorsInTask = function() use ($task) {
             $data = [];
             try {
                 $result = $this->runSubtask($task);
@@ -679,7 +679,7 @@ 
     {
         return $this->defer(
             $task,
-            function ($task, $state) use ($functionName, $stateKey) {
+            function($task, $state) use ($functionName, $stateKey) {
                 $fn = [$task, $functionName];
                 $value = $state[$stateKey];
                 $fn($value);

Doc Comments +4 added lines, -4 removed lines

@@ -212,7 +212,7 @@ 
      *
      * @param string $method
      * @param string $name
-     * @param callable|\Robo\Contract\TaskInterface $task
+     * @param callable $task
      * @param string $nameOfTaskToAdd
      *
      * @return $this
@@ -283,7 +283,7 @@ 
     /**
      * Return the list of task names added to this collection.
      *
-     * @return string[]
+     * @return integer[]
      */
     public function taskNames()
     {
@@ -356,7 +356,7 @@ 
     }
 
     /**
-     * @param int|string $name
+     * @param string $name
      * @param \Robo\Collection\Element $taskGroup
      *
      * @return $this
@@ -648,7 +648,7 @@ 
     }
 
     /**
-     * @param \Robo\Contract\TaskInterface|\Robo\Collection\NestedCollectionInterface|\Robo\Contract\WrappedTaskInterface $task
+     * @param TaskInterface $task
      *
      * @return \Robo\Result
      */

tests/unit/Task/CollectionTest.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use Robo\Robo;
 use Robo\Result;
 use Robo\State\Data;
-use Robo\Task\BaseTask;
 use Robo\Collection\Collection;
 use Robo\Task\ValueProviderTask;
 use Robo\Task\CollectionTestTask;

Spacing +8 added lines, -8 removed lines

@@ -110,11 +110,11 @@ 
             ->completion($completion1)
             ->rollbackCode(function() use($rollback1) { $rollback1->run(); } )
             ->completionCode(function() use($completion1) { $completion1->run(); } )
-            ->addCode(function () { return 42; })
+            ->addCode(function() { return 42; })
             ->progressMessage("not reached")
             ->rollback($rollback2)
             ->completion($completion2)
-            ->addCode(function () { return 13; });
+            ->addCode(function() { return 13; });
 
         $collection->setLogger($this->guy->logger());
 
@@ -137,15 +137,15 @@ 
 
         $result = $collection
             ->addCode(
-                function (Data $state) {
+                function(Data $state) {
                     $state['one'] = 'first';
                 })
             ->addCode(
-                function (Data $state) {
+                function(Data $state) {
                     $state['two'] = 'second';
                 })
             ->addCode(
-                function (Data $state) {
+                function(Data $state) {
                     $state['three'] = "{$state['one']} and {$state['two']}";
                 })
             ->run();
@@ -169,7 +169,7 @@ 
             ->add($first)
             ->add($second)
             ->addCode(
-                function (Data $state) {
+                function(Data $state) {
                     $state['three'] = "{$state['one']} and {$state['two']}";
                 })
             ->run();
@@ -198,7 +198,7 @@ 
             ->add($third)
                 ->defer(
                     $third,
-                    function ($task, $state) {
+                    function($task, $state) {
                         $task->provideData('three', "{$state['one']} and {$state['two']}");
                     }
                 )
@@ -230,7 +230,7 @@ 
             ->add($third)
                 ->defer(
                     $third,
-                    function ($task, $state) {
+                    function($task, $state) {
                         $task->provideData('three', "{$state['one']} and {$state['two']}");
                     }
                 )

tests/unit/Task/ComposerTest.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 use AspectMock\Test as test;
-
 use Robo\Traits\Common\AdjustQuotes;
 
 class ComposerTest extends \Codeception\TestCase\Test