GitTest

Complexity

Total Complexity

8

Size/Duplication

Total Lines	91
Duplicated Lines	43.96 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testGitStackShallowCloneCommand()	0	10	1
A	testGitStackShallowCloneCommandWithDifferentDepth()	0	10	1

<?php

use AspectMock\Test as test;

This use statement conflicts with another class in this namespace, test.

class GitTest extends \Codeception\TestCase\Test

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var \AspectMock\Proxy\ClassProxy
     */
    protected $git;

    protected function _before()
    {
        $this->git = test::double('Robo\Task\Vcs\GitStack', [

It seems like \AspectMock\Test::double('Robo\\Task\\Vcs\\GitStack', array('executeCommand' => new \AspectMock\Proxy\Anything(), 'output' => new \Symfony\Component\Console\Output\NullOutput(), 'logger' => new \Psr\Log\NullLogger())) can also be of type object<AspectMock\Proxy\InstanceProxy>. However, the property $git is declared as type object<AspectMock\Proxy\ClassProxy>. Maybe add an additional type check?

            'executeCommand' => new \AspectMock\Proxy\Anything(),
            'output' => new \Symfony\Component\Console\Output\NullOutput(),
            'logger' => new \Psr\Log\NullLogger(),
        ]);
    }

    // tests
    public function testGitStackRun()
    {
        (new \Robo\Task\Vcs\GitStack('git'))->stopOnFail()->add('-A')->pull()->run();
        $this->git->verifyInvoked('executeCommand', ['git add -A']);
        $this->git->verifyInvoked('executeCommand', ['git pull']);

        (new \Robo\Task\Vcs\GitStack('git'))->add('-A')->pull()->run();
        $this->git->verifyInvoked('executeCommand', ['git add -A && git pull']);
    }

    public function testGitStackCommands()

This method seems to be duplicated in your project.

    {
        $linuxCmd = "git clone http://github.com/consolidation-org/Robo && git pull && git add -A && git commit -m 'changed' && git push && git tag 0.6.0 && git push origin 0.6.0";

        $winCmd = 'git clone http://github.com/consolidation-org/Robo && git pull && git add -A && git commit -m "changed" && git push && git tag 0.6.0 && git push origin 0.6.0';

        $cmd = stripos(PHP_OS, 'WIN') === 0 ? $winCmd : $linuxCmd;

        verify(
            (new \Robo\Task\Vcs\GitStack())
                ->cloneRepo('http://github.com/consolidation-org/Robo')
                ->pull()
                ->add('-A')
                ->commit('changed')
                ->push()
                ->tag('0.6.0')
                ->push('origin', '0.6.0')
                ->getCommand()
        )->equals($cmd);
    }

    public function testGitStackCommandsWithTagMessage()

This method seems to be duplicated in your project.

    {
        $linuxCmd = "git clone http://github.com/consolidation-org/Robo && git pull && git add -A && git commit -m 'changed' && git push && git tag -m 'message' 0.6.0 && git push origin 0.6.0";

        $winCmd = 'git clone http://github.com/consolidation-org/Robo && git pull && git add -A && git commit -m "changed" && git push && git tag -m \'message\' 0.6.0 && git push origin 0.6.0';

        $cmd = stripos(PHP_OS, 'WIN') === 0 ? $winCmd : $linuxCmd;

        verify(
            (new \Robo\Task\Vcs\GitStack())
                ->cloneRepo('http://github.com/consolidation-org/Robo')
                ->pull()
                ->add('-A')
                ->commit('changed')
                ->push()
                ->tag('0.6.0', 'message')
                ->push('origin', '0.6.0')
                ->getCommand()
        )->equals($cmd);
    }

    public function testGitStackShallowCloneCommand()
    {
        $cmd = 'git clone --depth 1 http://github.com/consolidation-org/Robo ./deployment-path';

        verify(
            (new \Robo\Task\Vcs\GitStack())
                ->cloneShallow('http://github.com/consolidation-org/Robo', './deployment-path')
                ->getCommand()
        )->equals($cmd);
    }

    public function testGitStackShallowCloneCommandWithDifferentDepth()
    {
        $cmd = 'git clone --depth 3 http://github.com/consolidation-org/Robo . --branch feature';

        verify(
            (new \Robo\Task\Vcs\GitStack())
                ->cloneShallow('http://github.com/consolidation-org/Robo', '.', 'feature', 3)
                ->getCommand()
        )->equals($cmd);
    }
}