consolidation /
robo
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 4 | View Code Duplication | class PhpspecTest extends \Codeception\TestCase\Test |
|
| 5 | { |
||
| 6 | /** |
||
| 7 | * @var \AspectMock\Proxy\ClassProxy |
||
| 8 | */ |
||
| 9 | protected $phpspec; |
||
| 10 | |||
| 11 | protected function _before() |
||
| 19 | |||
| 20 | // tests |
||
| 21 | public function testPhpSpecRun() |
||
| 26 | |||
| 27 | public function testPHPSpecCommand() |
||
| 43 | } |
||
| 44 |
Loading history...
Let’s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let’s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: