Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | class PHPServerTest extends \Codeception\TestCase\Test |
||
6 | { |
||
7 | /** |
||
8 | * @var \AspectMock\Proxy\ClassProxy |
||
9 | */ |
||
10 | protected $process; |
||
11 | |||
12 | View Code Duplication | protected function _before() |
|
23 | |||
24 | public function testServerBackgroundRun() |
||
32 | |||
33 | public function testServerRun() |
||
41 | |||
42 | public function testServerCommand() |
||
57 | } |
||
58 |
Let’s assume that you have a directory layout like this:
and let’s assume the following content of
Bar.php
:If both files
OtherDir/Foo.php
andSomeDir/Foo.php
are loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php
However, as
OtherDir/Foo.php
does not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php
, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: