Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | class GitTest extends \Codeception\TestCase\Test |
||
6 | { |
||
7 | /** |
||
8 | * @var \AspectMock\Proxy\ClassProxy |
||
9 | */ |
||
10 | protected $git; |
||
11 | |||
12 | protected function _before() |
||
13 | { |
||
14 | $this->git = test::double('Robo\Task\Vcs\GitStack', [ |
||
15 | 'executeCommand' => new \AspectMock\Proxy\Anything(), |
||
16 | 'output' => new \Symfony\Component\Console\Output\NullOutput(), |
||
17 | 'logger' => new \Psr\Log\NullLogger(), |
||
18 | ]); |
||
19 | } |
||
20 | |||
21 | // tests |
||
22 | public function testGitStackRun() |
||
23 | { |
||
24 | (new \Robo\Task\Vcs\GitStack('git'))->stopOnFail()->add('-A')->pull()->run(); |
||
25 | $this->git->verifyInvoked('executeCommand', ['git add -A']); |
||
26 | $this->git->verifyInvoked('executeCommand', ['git pull']); |
||
27 | |||
28 | (new \Robo\Task\Vcs\GitStack('git'))->add('-A')->pull()->run(); |
||
29 | $this->git->verifyInvoked('executeCommand', ['git add -A && git pull']); |
||
30 | } |
||
31 | |||
32 | View Code Duplication | public function testGitStackCommands() |
|
33 | { |
||
34 | $linuxCmd = "git clone http://github.com/consolidation-org/Robo && git pull && git add -A && git commit -m 'changed' && git push && git tag 0.6.0 && git push origin 0.6.0"; |
||
35 | |||
36 | $winCmd = 'git clone http://github.com/consolidation-org/Robo && git pull && git add -A && git commit -m "changed" && git push && git tag 0.6.0 && git push origin 0.6.0'; |
||
37 | |||
38 | $cmd = stripos(PHP_OS, 'WIN') === 0 ? $winCmd : $linuxCmd; |
||
39 | |||
40 | $this->assertEquals( |
||
41 | $cmd, |
||
42 | (new \Robo\Task\Vcs\GitStack()) |
||
43 | ->cloneRepo('http://github.com/consolidation-org/Robo') |
||
44 | ->pull() |
||
45 | ->add('-A') |
||
46 | ->commit('changed') |
||
47 | ->push() |
||
48 | ->tag('0.6.0') |
||
49 | ->push('origin', '0.6.0') |
||
50 | ->getCommand() |
||
51 | ); |
||
52 | } |
||
53 | |||
54 | View Code Duplication | public function testGitStackCommandsWithTagMessage() |
|
55 | { |
||
56 | $linuxCmd = "git clone http://github.com/consolidation-org/Robo && git pull && git add -A && git commit -m 'changed' && git push && git tag -m 'message' 0.6.0 && git push origin 0.6.0"; |
||
57 | |||
58 | $winCmd = 'git clone http://github.com/consolidation-org/Robo && git pull && git add -A && git commit -m "changed" && git push && git tag -m \'message\' 0.6.0 && git push origin 0.6.0'; |
||
59 | |||
60 | $cmd = stripos(PHP_OS, 'WIN') === 0 ? $winCmd : $linuxCmd; |
||
61 | |||
62 | $this->assertEquals( |
||
63 | $cmd, |
||
64 | (new \Robo\Task\Vcs\GitStack()) |
||
65 | ->cloneRepo('http://github.com/consolidation-org/Robo') |
||
66 | ->pull() |
||
67 | ->add('-A') |
||
68 | ->commit('changed') |
||
69 | ->push() |
||
70 | ->tag('0.6.0', 'message') |
||
71 | ->push('origin', '0.6.0') |
||
72 | ->getCommand() |
||
73 | ); |
||
74 | } |
||
75 | |||
76 | public function testGitStackShallowCloneCommand() |
||
87 | |||
88 | public function testGitStackShallowCloneCommandWithDifferentDepth() |
||
99 | } |
||
100 |
Let’s assume that you have a directory layout like this:
and let’s assume the following content of
Bar.php
:If both files
OtherDir/Foo.php
andSomeDir/Foo.php
are loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php
However, as
OtherDir/Foo.php
does not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php
, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: