Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class ReorderFields |
||
9 | { |
||
10 | /** |
||
11 | * Given a simple list of user-supplied field keys or field labels, |
||
12 | * return a reordered version of the field labels matching the |
||
13 | * user selection. |
||
14 | * |
||
15 | * @param string|array $fields The user-selected fields |
||
16 | * @param array $fieldLabels An associative array mapping the field |
||
17 | * key to the field label |
||
18 | * @param array $data The data that will be rendered. |
||
19 | * |
||
20 | * @return array |
||
21 | */ |
||
22 | public function reorder($fields, $fieldLabels, $data) |
||
33 | |||
34 | View Code Duplication | protected function reorderFieldLabels($fields, $fieldLabels, $data) |
|
46 | |||
47 | protected function getSelectedFieldKeys($fields, $fieldLabels) |
||
63 | } |
||
64 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.