RowsOfFields - Code Metrics - Inspection of "Add ability to select columns from unstructured da..." - consolidation/output-formatters - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#69)

by Greg

created 2018-10-15 18:02 UTC

RowsOfFields A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	40
Duplicated Lines	22.5 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	3
dl	9
loc	40
ccs	16
cts	16
cp	1
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	convert()	9	9	2
A	restructure()	0	5	1
A	getListData()	0	4	1
A	defaultOptions()	0	6	1

How to fix Duplicated Code

<?php
namespace Consolidation\OutputFormatters\StructuredData;

use Consolidation\OutputFormatters\Options\FormatterOptions;

/**
 * Holds an array where each element of the array is one row,
 * and each row contains an associative array where the keys
 * are the field names, and the values are the field data.
 *
 * It is presumed that every row contains the same keys.
 */
class RowsOfFields extends AbstractStructuredList implements ConversionInterface
{
    /**
     * @inheritdoc
     */
    public function convert(FormatterOptions $options)

    {
        $defaults = $this->defaultOptions();
        $fields = $this->getFields($options, $defaults);
        if (FieldProcessor::hasUnstructuredFieldAccess($fields)) {
            return new UnstructuredListData($this->getArrayCopy());
        }
        return $this;
    }

    /**
     * Restructure this data for output by converting it into a table
     * transformation object.
     *
     * @param FormatterOptions $options Options that affect output formatting.
     * @return Consolidation\OutputFormatters\Transformations\TableTransformation
     */
    public function restructure(FormatterOptions $options)
    {
        $data = $this->getArrayCopy();
        return $this->createTableTransformation($data, $options);
    }

    public function getListData(FormatterOptions $options)
    {
        return array_keys($this->getArrayCopy());
    }

    protected function defaultOptions()
    {
        return [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            FormatterOptions::LIST_ORIENTATION => false,
        ] + parent::defaultOptions();
    }
}


1			<?php
2			namespace Consolidation\OutputFormatters\StructuredData;
3
4			use Consolidation\OutputFormatters\Options\FormatterOptions;
5
6			/**
7			* Holds an array where each element of the array is one row,
8			* and each row contains an associative array where the keys
9			* are the field names, and the values are the field data.
10			*
11			* It is presumed that every row contains the same keys.
12			*/
13			class RowsOfFields extends AbstractStructuredList implements ConversionInterface
14			{
15			/**
16			* @inheritdoc
17			*/
18		View Code Duplication	public function convert(FormatterOptions $options)
			0 ignored issues – show Duplication introduced 2018-10-14 04:26 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19			{
20			$defaults = $this->defaultOptions();
21	9		$fields = $this->getFields($options, $defaults);
22			if (FieldProcessor::hasUnstructuredFieldAccess($fields)) {
23	9		return new UnstructuredListData($this->getArrayCopy());
24	9		}
25			return $this;
26	4		}
27
28	4		/**
29	4		* Restructure this data for output by converting it into a table
30			* transformation object.
31			*
32	2		* @param FormatterOptions $options Options that affect output formatting.
33			* @return Consolidation\OutputFormatters\Transformations\TableTransformation
34	2		*/
35			public function restructure(FormatterOptions $options)
36			{
37	7		$data = $this->getArrayCopy();
38			return $this->createTableTransformation($data, $options);
39	7		}
40
41	7		public function getListData(FormatterOptions $options)
42	7		{
43			return array_keys($this->getArrayCopy());
44	7		}
45
46	7		protected function defaultOptions()
47			{
48			return [
			0 ignored issues – show Best Practice introduced 2016-09-19 17:12 UTC by Report Bug Copy Issue Report The expression `return array(\Consolidat...rent::defaultOptions();` seems to be an `array`, but some of its elements' types (`false`) are incompatible with the return type of the parent method `Consolidation\OutputForm...redList::defaultOptions` of type `array<,array>`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return new Author('Johannes'); } } class BlogPost extends Post { public function getAuthor() { return 'Johannes'; } } class ForumPost extends Post { / ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
49	7		FormatterOptions::LIST_ORIENTATION => false,
50			] + parent::defaultOptions();
51	7		}
52			}
53

consolidation / output-formatters

Pull Request — master (#69)

RowsOfFields A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like